trigger
Unit Tests
| Test | Status |
|---|---|
| TriggerTypeAdapters_test | ✅ Passed |
Errors in Documentation Links
python/trigger/tpreplay_application/README.md
- [ERROR] file:///home/runner/work/trigger/trigger/python/include/trigger/Issues.hpp File not found. Check if file exists and path is correct
- [403] https://docs.dunescience.org/cgi-bin/private/ShowDocument?docid=32918 Rejected status code: 403 Forbidden
README.md
- [403] https://docs.dunescience.org/cgi-bin/private/ShowDocument?docid=28497 Rejected status code: 403 Forbidden
Clang Formatting
| File | Status |
|---|---|
| include/trigger/AlgorithmPlugins.hpp | ❌ Needs formatting |
| include/trigger/Issues.hpp | ❌ Needs formatting |
| include/trigger/Latency.hpp | ✅ Already formatted |
| include/trigger/Set.hpp | ❌ Needs formatting |
| include/trigger/TASet.hpp | ❌ Needs formatting |
| include/trigger/TAWrapper.hpp | ❌ Needs formatting |
| include/trigger/TCSet.hpp | ❌ Needs formatting |
| include/trigger/TCWrapper.hpp | ❌ Needs formatting |
| include/trigger/TPSet.hpp | ❌ Needs formatting |
| include/trigger/TriggerActivity_serialization.hpp | ✅ Already formatted |
| include/trigger/TriggerCandidate_serialization.hpp | ❌ Needs formatting |
| include/trigger/TriggerDataHandlingModel.hpp | ✅ Already formatted |
| include/trigger/TriggerPrimitiveTypeAdapter.hpp | ❌ Needs formatting |
| include/trigger/TriggerPrimitive_serialization.hpp | ✅ Already formatted |
| include/trigger/detail/TriggerDataHandlingModel.hxx | ✅ Already formatted |
| include/trigger/serialize.hpp | ✅ Already formatted |
| plugins/DataSubscriberModule.cpp | ❌ Needs formatting |
| plugins/DataSubscriberModule.hpp | ❌ Needs formatting |
| plugins/FixedTimeTCMakerModule.cpp | ❌ Needs formatting |
| plugins/FixedTimeTCMakerModule.hpp | ❌ Needs formatting |
| plugins/MLTModule.cpp | ❌ Needs formatting |
| plugins/MLTModule.hpp | ✅ Already formatted |
| plugins/RandomTCMakerModule.cpp | ❌ Needs formatting |
| plugins/RandomTCMakerModule.hpp | ✅ Already formatted |
| plugins/TPReplayModule.cpp | ✅ Already formatted |
| plugins/TPReplayModule.hpp | ✅ Already formatted |
| plugins/TriggerDataHandlerModule.cpp | ❌ Needs formatting |
| plugins/TriggerDataHandlerModule.hpp | ❌ Needs formatting |
| plugins/TriggerDecisionMakerSupernovaPlugin.cpp | ✅ Already formatted |
| src/LivetimeCounter.cpp | ❌ Needs formatting |
| src/TAProcessor.cpp | ❌ Needs formatting |
| src/TCProcessor.cpp | ❌ Needs formatting |
| src/TPProcessor.cpp | ❌ Needs formatting |
| src/TPRequestHandler.cpp | ❌ Needs formatting |
| src/TokenManager.cpp | ✅ Already formatted |
| src/trigger/HSISourceModel.hpp | ❌ Needs formatting |
| src/trigger/LivetimeCounter.hpp | ❌ Needs formatting |
| src/trigger/TAProcessor.hpp | ❌ Needs formatting |
| src/trigger/TCProcessor.hpp | ❌ Needs formatting |
| src/trigger/TPProcessor.hpp | ❌ Needs formatting |
| src/trigger/TPRequestHandler.hpp | ❌ Needs formatting |
| src/trigger/TokenManager.hpp | ✅ Already formatted |
| src/trigger/TriggerGenericMaker.hpp | ❌ Needs formatting |
| test/apps/generate_tpset_from_hdf5.cxx | ✅ Already formatted |
| test/apps/print_ds_fragments.cxx | ❌ Needs formatting |
| test/apps/print_trigger_type.cxx | ❌ Needs formatting |
| test/apps/set_serialization_speed.cxx | ❌ Needs formatting |
| test/apps/taset_serialization.cxx | ✅ Already formatted |
| test/plugins/TASetSink.cpp | ❌ Needs formatting |
| test/plugins/TASetSink.hpp | ❌ Needs formatting |
| test/plugins/TPSetSink.cpp | ❌ Needs formatting |
| test/plugins/TPSetSink.hpp | ✅ Already formatted |
| unittest/AlgorithmPlugins_test.cxx | ❌ Needs formatting |
| unittest/BufferManager_test.cxx | ✅ Already formatted |
| unittest/TokenManager_test.cxx | ❌ Needs formatting |
| unittest/TriggerObjectOverlay_test.cxx | ❌ Needs formatting |
| unittest/TriggerTypeAdapters_test.cxx | ❌ Needs formatting |
| unittest/TxSet_test.cxx | ✅ Already formatted |
include/trigger/Issues.hpp
Errors
- Line 166: Using C-style cast. Use static_cast
(...) instead - Line 176: Using C-style cast. Use static_cast
(...) instead - Line 197: An unsigned integer appears to be used here.
- Line 202: An unsigned integer appears to be used here.
- Line 207: An unsigned integer appears to be used here.
- Line 286: Using C-style cast. Use static_cast
(...) instead
include/trigger/Latency.hpp
Errors
- Line 21: An unsigned integer appears to be used here.
- Line 32: Constructors callable with one argument should be marked explicit.
- Line 43: An unsigned integer appears to be used here.
- Line 46: An unsigned integer appears to be used here.
- Line 76: An unsigned integer appears to be used here.
- Line 79: An unsigned integer appears to be used here.
- Line 81: An unsigned integer appears to be used here.
- Line 82: An unsigned integer appears to be used here.
- Line 83: An unsigned integer appears to be used here.
- Line 93: An unsigned integer appears to be used here.
include/trigger/TAWrapper.hpp
Errors
- Line 59: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 90: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 26: An unsigned integer appears to be used here.
- Line 31: Constructors callable with one argument should be marked explicit.
- Line 73: Using C-style cast. Use one of the C++ cast operators instead
- Line 78: Using C-style cast. Use one of the C++ cast operators instead
- Line 26: Add #include
for vector<>
include/trigger/TCWrapper.hpp
Errors
- Line 56: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 24: An unsigned integer appears to be used here.
- Line 28: Constructors callable with one argument should be marked explicit.
- Line 70: Using C-style cast. Use one of the C++ cast operators instead
- Line 75: Using C-style cast. Use one of the C++ cast operators instead
- Line 24: Add #include
for vector<>
include/trigger/TriggerPrimitiveTypeAdapter.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 41: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 46: An unsigned integer appears to be used here.
plugins/DataSubscriberModule.cpp
Errors
- Line 86: Add #include
for vector<> - Line 39: Add #include
for string - Line 107: Add #include
for make_shared<>
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 73: do not use C-style cast to convert between unrelated types
- Line 78: do not use C-style cast to convert between unrelated types
- Line 78: do not use pointer arithmetic
- Line 18: nested namespaces can be concatenated
- Line 70: do not use C-style cast to convert between unrelated types
- Line 75: do not use C-style cast to convert between unrelated types
- Line 75: do not use pointer arithmetic
- Line 16: nested namespaces can be concatenated
- Line 22: nested namespaces can be concatenated
- Line 83: variable 'tc_type' is not initialized
- Line 112: 'start' overrides a member function but is not marked 'override'
- Line 123: 'stop' overrides a member function but is not marked 'override'
- Line 159: C-style casts are discouraged; use static_cast
plugins/DataSubscriberModule.hpp
Errors
- Line 8: #ifndef header guard has wrong style, please use: TRIGGER_PLUGINS_DATASUBSCRIBERMODULE_HPP_
- Line 55: #endif line should be "#endif // TRIGGER_PLUGINS_DATASUBSCRIBERMODULE_HPP_"
- Line 48: Add #include
for shared_ptr<>
plugins/FixedTimeTCMakerModule.cpp
Errors
- Line 99: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 99: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 99: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 20: Add #include
for string - Line 29: Add #include
for shared_ptr<> - Line 121: Add #include
for move
Warnings
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
plugins/FixedTimeTCMakerModule.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: TRIGGER_PLUGINS_FIXEDTIMETCMAKERMODULE_HPP_
- Line 68: #endif line should be "#endif // TRIGGER_PLUGINS_FIXEDTIMETCMAKERMODULE_HPP_"
- Line 57: An unsigned integer appears to be used here.
- Line 24: Add #include
for string - Line 54: Add #include
for shared_ptr<>
plugins/MLTModule.cpp
Errors
- Line 47: An unsigned integer appears to be used here.
- Line 328: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 361: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 361: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 361: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 372: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 383: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 390: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 400: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 117: Add #include
for string - Line 105: Add #include
- Line 68: Add #include
for shared_ptr<> - Line 368: Add #include
for move
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 53: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'mapped_type' (aka 'int') is implementation-defined
- Line 56: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'mapped_type' (aka 'int') is implementation-defined
- Line 59: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'mapped_type' (aka 'int') is implementation-defined
- Line 62: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'mapped_type' (aka 'int') is implementation-defined
- Line 243: use std::make_shared instead
- Line 404: 'decision' used after it was moved
- Line 53: nested namespaces can be concatenated
- Line 262: C-style casts are discouraged; use static_cast
- Line 25: nested namespaces can be concatenated
- Line 50: explicitly defaulted move constructor is implicitly deleted
- Line 52: explicitly defaulted move assignment operator is implicitly deleted
plugins/MLTModule.hpp
Errors
- Line 102: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 118: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 163: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 191: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 204: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 213: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 217: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 14: #ifndef header guard has wrong style, please use: TRIGGER_PLUGINS_MLTMODULE_HPP_
- Line 294: #endif line should be "#endif // TRIGGER_PLUGINS_MLTMODULE_HPP_"
- Line 92: An unsigned integer appears to be used here.
- Line 231: An unsigned integer appears to be used here.
- Line 227: Add #include
for pair<>
plugins/RandomTCMakerModule.cpp
Errors
- Line 146: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 152: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 152: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 152: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 216: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 216: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 216: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 222: An unsigned integer appears to be used here.
- Line 227: An unsigned integer appears to be used here.
- Line 233: An unsigned integer appears to be used here.
- Line 51: Add #include
for shared_ptr<> - Line 281: Add #include
for move
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 145: prefer a lambda to std::bind
- Line 146: do not use reinterpret_cast
- Line 159: narrowing conversion from 'TrgRate' (aka 'double') to 'float'
- Line 202: narrowing conversion from 'TrgRate' (aka 'double') to 'float'
- Line 227: narrowing conversion from 'float' to 'uint64_t' (aka 'unsigned long')
- Line 227: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'float'
- Line 232: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 233: casting (double + 0.5) to integer leads to incorrect rounding; consider using lround (#include
) instead - Line 247: variable 'initial_timestamp' is not initialized
- Line 266: variable 'actual_timestamp' is not initialized
- Line 44: nested namespaces can be concatenated
- Line 25: nested namespaces can be concatenated
- Line 50: explicitly defaulted move constructor is implicitly deleted
- Line 52: explicitly defaulted move assignment operator is implicitly deleted
plugins/RandomTCMakerModule.hpp
Errors
- Line 7: #ifndef header guard has wrong style, please use: TRIGGER_PLUGINS_RANDOMTCMAKERMODULE_HPP_
- Line 138: #endif line should be "#endif // TRIGGER_PLUGINS_RANDOMTCMAKERMODULE_HPP_"
- Line 112: An unsigned integer appears to be used here.
- Line 117: An unsigned integer appears to be used here.
- Line 125: An unsigned integer appears to be used here.
plugins/TPReplayModule.cpp
Errors
- Line 54: Using deprecated casting style. Use static_cast
(...) instead - Line 131: "cout" should not be used for output in DUNE DAQ software.
- Line 348: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
- Line 357: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
- Line 375: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 376: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 390: If an else has a brace on one side, it should have it on both
- Line 394: If an else has a brace on one side, it should have it on both
- Line 398: If an else has a brace on one side, it should have it on both
- Line 441: Small and focused functions are preferred: TPReplayModule::read_tps() has 114 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 564: Small and focused functions are preferred: TPReplayModule::do_work() has 84 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 309: Add #include
for set<> - Line 528: Add #include
for move - Line 446: Add #include
for deque<> - Line 279: Add #include
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 54: redundant cast to the same type
- Line 225: narrowing conversion from 'double' to 'float'
- Line 225: narrowing conversion from 'rep' (aka 'long') to 'double'
- Line 324: use auto when initializing with a cast to avoid duplicating the type name
- Line 334: do not use pointer arithmetic
- Line 337: use auto when initializing with a cast to avoid duplicating the type name
- Line 353: variable 'plane' is not initialized
- Line 355: narrowing conversion from 'uint' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 375: do not use reinterpret_cast
- Line 376: do not use reinterpret_cast
- Line 376: do not use pointer arithmetic
- Line 486: narrowing conversion from 'double' to 'int'
- Line 486: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 489: narrowing conversion from 'double' to 'int'
- Line 489: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 540: 'tpv' used after it was moved
- Line 552: narrowing conversion from 'double' to 'float'
- Line 552: narrowing conversion from 'rep' (aka 'long') to 'double'
- Line 46: nested namespaces can be concatenated
plugins/TPReplayModule.hpp
Errors
- Line 113: An unsigned integer appears to be used here.
- Line 95: Add #include
for deque<> - Line 95: Add #include
- Line 109: Add #include
for set<> - Line 110: Add #include
for unordered_set<>
plugins/TriggerDataHandlerModule.cpp
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 73: do not use C-style cast to convert between unrelated types
- Line 78: do not use C-style cast to convert between unrelated types
- Line 78: do not use pointer arithmetic
- Line 18: nested namespaces can be concatenated
- Line 70: do not use C-style cast to convert between unrelated types
- Line 75: do not use C-style cast to convert between unrelated types
- Line 75: do not use pointer arithmetic
- Line 16: nested namespaces can be concatenated
- Line 17: nested namespaces can be concatenated
- Line 29: nested namespaces can be concatenated
- Line 37: nested namespaces can be concatenated
- Line 29: nested namespaces can be concatenated
- Line 32: using declarations in the global namespace in headers are prohibited
plugins/TriggerDataHandlerModule.hpp
Errors
- Line 8: #ifndef header guard has wrong style, please use: TRIGGER_PLUGINS_TRIGGERDATAHANDLERMODULE_HPP_
- Line 47: #endif line should be "#endif // TRIGGER_PLUGINS_TRIGGERDATAHANDLERMODULE_HPP_"
- Line 39: Add #include
for shared_ptr<>
plugins/TriggerDecisionMakerSupernovaPlugin.cpp
Warnings
- Line 69: function-like macro 'DEFINE_DUNE_TD_MAKER' used; consider a 'constexpr' template function
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
src/LivetimeCounter.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 81: Add #include
for string - Line 45: Add #include
src/TAProcessor.cpp
Errors
- Line 184: Namespace should be terminated with '// namespace trigger '
- Line 151: Add #include
for shared_ptr<> - Line 156: Add #include
for vector<> - Line 161: Add #include
for move
Warnings
- Line 69: function-like macro 'DEFINE_DUNE_TD_MAKER' used; consider a 'constexpr' template function
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 73: do not use C-style cast to convert between unrelated types
- Line 78: do not use C-style cast to convert between unrelated types
- Line 78: do not use pointer arithmetic
- Line 30: using decl 'TLVL_BOOKKEEPING' is unused
- Line 31: using decl 'TLVL_TAKE_NOTE' is unused
- Line 36: nested namespaces can be concatenated
- Line 169: redundant return statement at the end of a function with a void return type
- Line 29: nested namespaces can be concatenated
src/TCProcessor.cpp
Errors
- Line 277: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 47: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 47: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 47: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 131: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 131: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 131: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 286: If an else has a brace on one side, it should have it on both
- Line 354: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 354: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 354: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 391: If an else has a brace on one side, it should have it on both
- Line 619: An unsigned integer appears to be used here.
- Line 759: Using C-style cast. Use static_cast
(...) instead - Line 779: Consider using rand_r(...) instead of rand(...) for improved thread safety.
- Line 858: Namespace should be terminated with '// namespace trigger '
- Line 32: Add #include
for unique_ptr<> - Line 828: Add #include
for vector<> - Line 646: Add #include
for pair<> - Line 612: Add #include
for string - Line 742: Add #include
- Line 794: Add #include
for set<>
Warnings
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 70: do not use C-style cast to convert between unrelated types
- Line 75: do not use C-style cast to convert between unrelated types
- Line 75: do not use pointer arithmetic
- Line 23: using decl 'TLVL_BOOKKEEPING' is unused
- Line 24: using decl 'TLVL_TAKE_NOTE' is unused
- Line 29: nested namespaces can be concatenated
- Line 119: use emplace_back instead of push_back
- Line 125: use emplace_back instead of push_back
- Line 182: use auto when declaring iterators
- Line 293: redundant return statement at the end of a function with a void return type
- Line 359: use auto when declaring iterators
- Line 407: use auto when declaring iterators
- Line 471: use auto when declaring iterators
- Line 488: redundant return statement at the end of a function with a void return type
- Line 506: use auto when declaring iterators
- Line 527: variable 'earliest_tc_time' is not initialized
- Line 572: use auto when declaring iterators
- Line 642: redundant return statement at the end of a function with a void return type
- Line 652: redundant return statement at the end of a function with a void return type
- Line 662: use emplace_back instead of push_back
- Line 667: redundant return statement at the end of a function with a void return type
- Line 681: redundant return statement at the end of a function with a void return type
- Line 706: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 727: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 738: redundant return statement at the end of a function with a void return type
- Line 753: redundant return statement at the end of a function with a void return type
- Line 759: narrowing conversion from 'double' to 'float'
- Line 759: C-style casts are discouraged; use static_cast
- Line 759: rand() has limited randomness; use C++11 random library instead
- Line 779: rand() has limited randomness; use C++11 random library instead
- Line 821: redundant return statement at the end of a function with a void return type
- Line 830: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 37: nested namespaces can be concatenated
src/TPProcessor.cpp
Errors
- Line 187: Namespace should be terminated with '// namespace trigger '
- Line 157: Add #include
for vector<> - Line 153: Add #include
for shared_ptr<> - Line 163: Add #include
for move
Warnings
- Line 69: function-like macro 'DEFINE_DUNE_TD_MAKER' used; consider a 'constexpr' template function
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
- Line 16: nested namespaces can be concatenated
- Line 82: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long')
- Line 27: using decl 'TLVL_BOOKKEEPING' is unused
- Line 28: using decl 'TLVL_TAKE_NOTE' is unused
- Line 34: nested namespaces can be concatenated
- Line 172: redundant return statement at the end of a function with a void return type
- Line 29: nested namespaces can be concatenated
src/TPRequestHandler.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 121: Namespace should be terminated with '// namespace trigger '
- Line 103: Add #include
for move - Line 64: Add #include
for vector<>
Warnings
- Line 16: nested namespaces can be concatenated
- Line 7: nested namespaces can be concatenated
- Line 100: std::move of the variable 'tp' of the trivially-copyable type 'trgdataformats::TriggerPrimitive' has no effect; remove std::move()
- Line 118: redundant return statement at the end of a function with a void return type
- Line 32: using declarations in the global namespace in headers are prohibited
src/TokenManager.cpp
Warnings
- Line 25: nested namespaces can be concatenated
- Line 50: explicitly defaulted move constructor is implicitly deleted
- Line 52: explicitly defaulted move assignment operator is implicitly deleted
src/trigger/HSISourceModel.hpp
Errors
- Line 8: #ifndef header guard has wrong style, please use: TRIGGER_SRC_TRIGGER_HSISOURCEMODEL_HPP_
- Line 243: #endif line should be "#endif // TRIGGER_SRC_TRIGGER_HSISOURCEMODEL_HPP_"
- Line 12: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 13: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 14: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 15: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 16: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 18: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 19: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 21: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 22: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 23: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 24: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 25: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 26: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 27: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 28: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 29: Found other header after system header. Should be: HSISourceModel.hh, other non-system headers, system headers.
- Line 93: An unsigned integer appears to be used here.
- Line 142: An unsigned integer appears to be used here.
- Line 146: An unsigned integer appears to be used here.
- Line 170: If an else has a brace on one side, it should have it on both
- Line 221: An unsigned integer appears to be used here.
- Line 224: An unsigned integer appears to be used here.
- Line 231: An unsigned integer appears to be used here.
- Line 198: Add #include
for move - Line 218: Add #include
for shared_ptr<> - Line 221: Add #include
src/trigger/LivetimeCounter.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: TRIGGER_SRC_TRIGGER_LIVETIMECOUNTER_HPP_
- Line 80: #endif line should be "#endif // TRIGGER_SRC_TRIGGER_LIVETIMECOUNTER_HPP_"
- Line 30: An unsigned integer appears to be used here.
- Line 38: Single-parameter constructors should be marked explicit.
src/trigger/TAProcessor.hpp
Errors
- Line 93: #endif line should be "#endif // TRIGGER_SRC_TRIGGER_TAPROCESSOR_HPP_"
- Line 74: An unsigned integer appears to be used here.
- Line 70: Add #include
for shared_ptr<> - Line 68: Add #include
for vector<>
src/trigger/TCProcessor.hpp
Errors
- Line 179: An unsigned integer appears to be used here.
- Line 176: Add #include
for shared_ptr<> - Line 170: Add #include
for vector<> - Line 162: Add #include
- Line 96: Add #include
for string - Line 163: Add #include
for pair<>
src/trigger/TPProcessor.hpp
Errors
- Line 74: An unsigned integer appears to be used here.
- Line 70: Add #include
for shared_ptr<> - Line 68: Add #include
for vector<>
src/trigger/TPRequestHandler.hpp
Errors
- Line 20: "datahandlinglibs/ReadoutLogging.hpp" already included at sourcecode/trigger/src/trigger/TPRequestHandler.hpp:17
- Line 39: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 70: An unsigned integer appears to be used here.
- Line 72: An unsigned integer appears to be used here.
- Line 73: An unsigned integer appears to be used here.
- Line 80: An unsigned integer appears to be used here.
src/trigger/TriggerGenericMaker.hpp
Errors
- Line 419: If an else has a brace on one side, it should have it on both
- Line 463: If an else has a brace on one side, it should have it on both
- Line 531: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 581: Add #include
for move
test/apps/generate_tpset_from_hdf5.cxx
Errors
- Line 11: An "." or ".." was used in an #include; relative paths are disallowed.
- Line 39: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 41: An unsigned integer appears to be used here.
- Line 42: An unsigned integer appears to be used here.
- Line 50: "cout" should not be used for output in DUNE DAQ software.
- Line 79: "cout" should not be used for output in DUNE DAQ software.
- Line 113: "cout" should not be used for output in DUNE DAQ software.
- Line 61: Add #include
for string - Line 54: Add #include
for vector<> - Line 62: Add #include
for unique_ptr<>
Warnings
- Line 16: nested namespaces can be concatenated
- Line 46: nested namespaces can be concatenated
- Line 73: use auto when initializing with a cast to avoid duplicating the type name
- Line 77: do not use pointer arithmetic
test/apps/print_ds_fragments.cxx
Errors
- Line 31: "cout" should not be used for output in DUNE DAQ software.
- Line 32: "cout" should not be used for output in DUNE DAQ software.
- Line 44: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 45: "cout" should not be used for output in DUNE DAQ software.
- Line 55: "cout" should not be used for output in DUNE DAQ software.
- Line 57: "cout" should not be used for output in DUNE DAQ software.
- Line 62: "cout" should not be used for output in DUNE DAQ software.
- Line 70: "cout" should not be used for output in DUNE DAQ software.
- Line 77: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 81: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 88: "cout" should not be used for output in DUNE DAQ software.
- Line 95: "cout" should not be used for output in DUNE DAQ software.
- Line 96: "cout" should not be used for output in DUNE DAQ software.
- Line 101: "cout" should not be used for output in DUNE DAQ software.
- Line 109: "cout" should not be used for output in DUNE DAQ software.
- Line 116: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 120: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 139: "cout" should not be used for output in DUNE DAQ software.
- Line 140: "cout" should not be used for output in DUNE DAQ software.
- Line 157: "cout" should not be used for output in DUNE DAQ software.
- Line 105: Add #include
for unique_ptr<> - Line 129: Add #include
for string - Line 152: Add #include
for move
Warnings
- Line 44: do not use reinterpret_cast
- Line 48: do not use pointer arithmetic
- Line 77: do not use reinterpret_cast
- Line 81: do not use reinterpret_cast
- Line 81: do not use pointer arithmetic
- Line 116: do not use reinterpret_cast
- Line 120: do not use reinterpret_cast
- Line 120: do not use pointer arithmetic
- Line 148: 'frag_ptr' used after it was moved
- Line 151: 'frag_ptr' used after it was moved
test/apps/print_trigger_type.cxx
Errors
- Line 37: "cout" should not be used for output in DUNE DAQ software.
- Line 24: Add #include
for string
test/apps/set_serialization_speed.cxx
Warnings
- Line 36: random number generator seeded with a default argument will generate a predictable sequence of values
- Line 66: use auto when initializing with a template cast to avoid duplicating the type name
- Line 67: narrowing conversion from 'seqno_t' (aka 'unsigned long') to signed type 'int' is implementation-defined
- Line 71: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 90: use auto when initializing with a template cast to avoid duplicating the type name
test/apps/taset_serialization.cxx
Warnings
- Line 23: use auto when initializing with a template cast to avoid duplicating the type name
test/plugins/TASetSink.cpp
Errors
- Line 63: If an else has a brace on one side, it should have it on both
- Line 81: An unsigned integer appears to be used here.
- Line 22: Add #include
for string - Line 31: Add #include
for shared_ptr<>
Warnings
- Line 19: nested namespaces can be concatenated
- Line 145: narrowing conversion from 'triggeralgs::timestamp_t' (aka 'unsigned long') to 'double'
- Line 24: nested namespaces can be concatenated
test/plugins/TASetSink.hpp
Errors
- Line 45: "virtual" is redundant since function is already declared as "override"
- Line 38: Add #include
for string
test/plugins/TPSetSink.cpp
Errors
- Line 31: Add #include
for shared_ptr<>
Warnings
- Line 20: nested namespaces can be concatenated
- Line 116: narrowing conversion from 'triggeralgs::timestamp_t' (aka 'unsigned long') to 'double'
- Line 23: nested namespaces can be concatenated
test/plugins/TPSetSink.hpp
Errors
- Line 44: "virtual" is redundant since function is already declared as "override"
unittest/AlgorithmPlugins_test.cxx
Errors
- Line 27: Add #include
for unique_ptr<> - Line 38: Add #include
for vector<>
Warnings
- Line 69: function-like macro 'DEFINE_DUNE_TD_MAKER' used; consider a 'constexpr' template function
- Line 24: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: macro 'TLVL_GENERATION' used to declare a constant; consider using a 'constexpr' constant
- Line 28: macro 'TLVL_CANDIDATE' used to declare a constant; consider using a 'constexpr' constant
unittest/BufferManager_test.cxx
Warnings
- Line 22: modification of 'std' namespace can result in undefined behavior
- Line 33: variable 'generator' is not initialized
unittest/TokenManager_test.cxx
Errors
- Line 85: Add #include
for move
Warnings
- Line 25: nested namespaces can be concatenated
- Line 50: explicitly defaulted move constructor is implicitly deleted
- Line 52: explicitly defaulted move assignment operator is implicitly deleted
unittest/TriggerObjectOverlay_test.cxx
Errors
- Line 75: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Warnings
- Line 75: do not use reinterpret_cast
- Line 78: use auto when initializing with a template cast to avoid duplicating the type name
- Line 147: use auto when initializing with a template cast to avoid duplicating the type name
unittest/TriggerTypeAdapters_test.cxx
Warnings
- Line 18: nested namespaces can be concatenated
- Line 73: do not use C-style cast to convert between unrelated types
- Line 78: do not use C-style cast to convert between unrelated types
- Line 78: do not use pointer arithmetic
- Line 18: nested namespaces can be concatenated
- Line 70: do not use C-style cast to convert between unrelated types
- Line 75: do not use C-style cast to convert between unrelated types
- Line 75: do not use pointer arithmetic
- Line 16: nested namespaces can be concatenated