trgtools
Unit Tests
No unit tests written.
Clang Formatting
| File | Status |
|---|---|
| apps/copy_tpstream.cxx | ❌ Needs formatting |
| apps/emulate_from_tpstream.cxx | ❌ Needs formatting |
| apps/process_tpstream.cxx | ❌ Needs formatting |
| apps/tapipe.cxx | ❌ Needs formatting |
| include/trgtools/EmulationUnit.hpp | ❌ Needs formatting |
| include/trgtools/TAEmulationUnit.hpp | ❌ Needs formatting |
| include/trgtools/TAEmulationWorker.hpp | ❌ Needs formatting |
| include/trgtools/TCEmulationUnit.hpp | ✅ Already formatted |
| include/trgtools/detail/EmulationUnit.hxx | ❌ Needs formatting |
| pybindsrc/module.cpp | ✅ Already formatted |
| pybindsrc/registrators.hpp | ❌ Needs formatting |
| src/TAEmulationWorker.cpp | ❌ Needs formatting |
| unittest/TPGtools_unittest.cxx | ✅ Already formatted |
apps/copy_tpstream.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 77: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 8: Found other header after system header. Should be: copy_tpstream.hh, other non-system headers, system headers.
- Line 35: "cerr" should not be used for output in DUNE DAQ software.
- Line 62: "cout" should not be used for output in DUNE DAQ software.
- Line 63: "cerr" should not be used for output in DUNE DAQ software.
- Line 56: Add #include
for string - Line 52: Add #include
for make_unique<>
Warnings
- Line 29: multiple declarations in a single statement reduces readability
apps/emulate_from_tpstream.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 14: Found other header after system header. Should be: emulate_from_tpstream.hh, other non-system headers, system headers.
- Line 15: Found other header after system header. Should be: emulate_from_tpstream.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: emulate_from_tpstream.hh, other non-system headers, system headers.
- Line 34: An unsigned integer appears to be used here.
- Line 85: "cout" should not be used for output in DUNE DAQ software.
- Line 90: "cout" should not be used for output in DUNE DAQ software.
- Line 167: An unsigned integer appears to be used here.
- Line 175: An unsigned integer appears to be used here.
- Line 176: An unsigned integer appears to be used here.
- Line 180: An unsigned integer appears to be used here.
- Line 181: An unsigned integer appears to be used here.
- Line 198: "cout" should not be used for output in DUNE DAQ software.
- Line 203: "cout" should not be used for output in DUNE DAQ software.
- Line 214: An unsigned integer appears to be used here.
- Line 215: An unsigned integer appears to be used here.
- Line 217: An unsigned integer appears to be used here.
- Line 248: An unsigned integer appears to be used here.
- Line 250: An unsigned integer appears to be used here.
- Line 302: "cout" should not be used for output in DUNE DAQ software.
- Line 304: "cout" should not be used for output in DUNE DAQ software.
- Line 313: An unsigned integer appears to be used here.
- Line 314: An unsigned integer appears to be used here.
- Line 325: An unsigned integer appears to be used here.
- Line 327: An unsigned integer appears to be used here.
- Line 343: "cout" should not be used for output in DUNE DAQ software.
- Line 358: An unsigned integer appears to be used here.
- Line 359: An unsigned integer appears to be used here.
- Line 370: An unsigned integer appears to be used here.
- Line 371: An unsigned integer appears to be used here.
- Line 410: "cout" should not be used for output in DUNE DAQ software.
- Line 411: "cout" should not be used for output in DUNE DAQ software.
- Line 450: "cout" should not be used for output in DUNE DAQ software.
- Line 456: "cout" should not be used for output in DUNE DAQ software.
- Line 460: Small and focused functions are preferred: main() has 126 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 414: Add #include
for string - Line 371: Add #include
- Line 427: Add #include
for unique_ptr<> - Line 445: Add #include
for vector<> - Line 454: Add #include
for move - Line 401: Add #include
for sort - Line 327: Add #include
for numeric_limits<>
Warnings
- Line 125: use auto when initializing with a template cast to avoid duplicating the type name
- Line 217: use auto when initializing with a template cast to avoid duplicating the type name
- Line 348: loop variable is copied but only used as const reference; consider making it a const reference
- Line 349: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 390: moving a temporary object prevents copy elision
- Line 391: moving a temporary object prevents copy elision
- Line 23: nested namespaces can be concatenated
- Line 17: nested namespaces can be concatenated
- Line 116: redundant access specifier has the same accessibility as the previous access specifier
- Line 17: nested namespaces can be concatenated
- Line 13: nested namespaces can be concatenated
- Line 89: do not manage memory manually; consider a container or a smart pointer
- Line 92: do not use pointer arithmetic
- Line 100: do not manage memory manually; use RAII
apps/process_tpstream.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 25: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 372: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 13: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 14: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 15: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 16: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 18: Found other header after system header. Should be: process_tpstream.hh, other non-system headers, system headers.
- Line 37: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
- Line 43: An unsigned integer appears to be used here.
- Line 110: An unsigned integer appears to be used here.
- Line 119: An unsigned integer appears to be used here.
- Line 121: An unsigned integer appears to be used here.
- Line 167: An unsigned integer appears to be used here.
- Line 169: An unsigned integer appears to be used here.
- Line 208: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 208: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 208: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 221: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 221: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 221: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 243: An unsigned integer appears to be used here.
- Line 244: An unsigned integer appears to be used here.
- Line 285: An unsigned integer appears to be used here.
- Line 295: An unsigned integer appears to be used here.
- Line 312: An unsigned integer appears to be used here.
- Line 346: An unsigned integer appears to be used here.
- Line 374: Small and focused functions are preferred: main() has 140 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 338: Add #include
for unique_ptr<> - Line 224: Add #include
for string - Line 336: Add #include
for vector<> - Line 356: Add #include
for move
Warnings
- Line 119: multiple declarations in a single statement reduces readability
- Line 284: use auto when initializing with a cast to avoid duplicating the type name
- Line 287: do not use pointer arithmetic
- Line 295: do not use pointer arithmetic
- Line 295: do not use pointer arithmetic
- Line 297: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 23: nested namespaces can be concatenated
- Line 17: nested namespaces can be concatenated
- Line 17: nested namespaces can be concatenated
- Line 13: nested namespaces can be concatenated
- Line 89: do not manage memory manually; consider a container or a smart pointer
- Line 92: do not use pointer arithmetic
- Line 100: do not manage memory manually; use RAII
apps/tapipe.cxx
Errors
- Line 18: Found other header after system header. Should be: tapipe.hh, other non-system headers, system headers.
- Line 19: Found other header after system header. Should be: tapipe.hh, other non-system headers, system headers.
- Line 20: Found other header after system header. Should be: tapipe.hh, other non-system headers, system headers.
- Line 21: Found other header after system header. Should be: tapipe.hh, other non-system headers, system headers.
- Line 30: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
- Line 31: Single-parameter constructors should be marked explicit.
- Line 136: "cout" should not be used for output in DUNE DAQ software.
- Line 137: "cerr" should not be used for output in DUNE DAQ software.
- Line 207: An unsigned integer appears to be used here.
- Line 217: An unsigned integer appears to be used here.
- Line 264: Small and focused functions are preferred: main() has 87 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 134: Add #include
for make_unique<> - Line 119: Add #include
for string - Line 148: Add #include
for set<> - Line 160: Add #include
- Line 225: Add #include
for vector<>
Warnings
- Line 78: a trailing return type is disallowed for this function declaration
- Line 95: a trailing return type is disallowed for this function declaration
- Line 104: a trailing return type is disallowed for this function declaration
- Line 110: a trailing return type is disallowed for this function declaration
- Line 202: use auto when initializing with a cast to avoid duplicating the type name
- Line 209: do not use pointer arithmetic
- Line 217: do not use pointer arithmetic
- Line 217: do not use pointer arithmetic
- Line 218: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
- Line 248: do not manage memory manually; consider a container or a smart pointer
- Line 253: do not use pointer arithmetic
- Line 259: do not manage memory manually; use RAII
include/trgtools/EmulationUnit.hpp
Errors
- Line 1: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 10: #ifndef header guard has wrong style, please use: TRGTOOLS_INCLUDE_TRGTOOLS_EMULATIONUNIT_HPP_
- Line 57: #endif line should be "#endif // TRGTOOLS_INCLUDE_TRGTOOLS_EMULATIONUNIT_HPP_"
- Line 34: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 34: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 34: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 38: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
- Line 39: An unsigned integer appears to be used here.
- Line 44: Add #include
for string - Line 42: Add #include
for move
include/trgtools/TAEmulationUnit.hpp
Errors
- Line 1: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 10: #ifndef header guard has wrong style, please use: TRGTOOLS_INCLUDE_TRGTOOLS_TAEMULATIONUNIT_HPP_
- Line 27: #endif line should be "#endif // TRGTOOLS_INCLUDE_TRGTOOLS_TAEMULATIONUNIT_HPP_"
include/trgtools/TAEmulationWorker.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 138: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 148: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 1: #ifndef header guard has wrong style, please use: TRGTOOLS_INCLUDE_TRGTOOLS_TAEMULATIONWORKER_HPP_
- Line 178: #endif line should be "#endif // TRGTOOLS_INCLUDE_TRGTOOLS_TAEMULATIONWORKER_HPP_"
- Line 15: Found other header after system header. Should be: TAEmulationWorker.hh, other non-system headers, system headers.
- Line 16: Found other header after system header. Should be: TAEmulationWorker.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: TAEmulationWorker.hh, other non-system headers, system headers.
- Line 18: Found other header after system header. Should be: TAEmulationWorker.hh, other non-system headers, system headers.
- Line 40: An unsigned integer appears to be used here.
- Line 66: An unsigned integer appears to be used here.
- Line 74: An unsigned integer appears to be used here.
- Line 99: An unsigned integer appears to be used here.
- Line 116: Access specifier "private" has already appeared in class TAEmulationWorker
- Line 130: An unsigned integer appears to be used here.
- Line 163: An unsigned integer appears to be used here.
- Line 166: An unsigned integer appears to be used here.
- Line 169: An unsigned integer appears to be used here.
- Line 171: An unsigned integer appears to be used here.
- Line 176: Namespace should be terminated with '// namespace dunedaq::trgtools '
- Line 166: Add #include
for unique_ptr<> - Line 166: Add #include
for vector<> - Line 130: Add #include
for pair<> - Line 166: Add #include
- Line 124: Add #include
for string - Line 158: Add #include
for queue<>
include/trgtools/TCEmulationUnit.hpp
Errors
- Line 1: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 10: #ifndef header guard has wrong style, please use: TRGTOOLS_INCLUDE_TRGTOOLS_TCEMULATIONUNIT_HPP_
- Line 29: #endif line should be "#endif // TRGTOOLS_INCLUDE_TRGTOOLS_TCEMULATIONUNIT_HPP_"
pybindsrc/module.cpp
Warnings
- Line 14: namespace alias decl 'py' is unused
pybindsrc/registrators.hpp
Errors
- Line 21: Namespace should be terminated with '// namespace dunedaq::trgtools::python '
src/TAEmulationWorker.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: An unsigned integer appears to be used here.
- Line 13: An unsigned integer appears to be used here.
- Line 20: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 174: An unsigned integer appears to be used here.
- Line 194: If an else has a brace on one side, it should have it on both
- Line 209: "cout" should not be used for output in DUNE DAQ software.
- Line 259: An unsigned integer appears to be used here.
- Line 299: An unsigned integer appears to be used here.
- Line 304: An unsigned integer appears to be used here.
- Line 304: Add #include
for unique_ptr<> - Line 304: Add #include
for vector<> - Line 306: Add #include
for move - Line 43: Add #include
for string - Line 304: Add #include
Warnings
- Line 23: nested namespaces can be concatenated
- Line 17: nested namespaces can be concatenated
- Line 116: redundant access specifier has the same accessibility as the previous access specifier
- Line 13: nested namespaces can be concatenated
- Line 89: do not manage memory manually; consider a container or a smart pointer
- Line 92: do not use pointer arithmetic
- Line 100: do not manage memory manually; use RAII
- Line 43: use auto when initializing with a template cast to avoid duplicating the type name
- Line 97: throwing an exception whose type 'const char *' is not derived from 'std::exception'
- Line 173: use auto when initializing with a cast to avoid duplicating the type name
- Line 176: do not use pointer arithmetic