trgdataformats
Unit Tests
| Test | Status |
|---|---|
| Trgdataformats_test | ✅ Passed |
| TriggerCandidateData_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| include/trgdataformats/TriggerActivityData.hpp | ❌ Needs formatting |
| include/trgdataformats/TriggerCandidateData.hpp | ❌ Needs formatting |
| include/trgdataformats/TriggerObjectOverlay.hpp | ❌ Needs formatting |
| include/trgdataformats/TriggerPrimitive.hpp | ❌ Needs formatting |
| include/trgdataformats/Types.hpp | ✅ Already formatted |
| pybindsrc/module.cpp | ✅ Already formatted |
| pybindsrc/registrators.hpp | ❌ Needs formatting |
| pybindsrc/trigger_activity.cpp | ❌ Needs formatting |
| pybindsrc/trigger_candidate.cpp | ❌ Needs formatting |
| pybindsrc/trigger_primitive.cpp | ❌ Needs formatting |
| unittest/Trgdataformats_test.cxx | ✅ Already formatted |
| unittest/TriggerCandidateData_test.cxx | ✅ Already formatted |
include/trgdataformats/TriggerCandidateData.hpp
Errors
- Line 90: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 90: Missing email address in TODO comment; it should appear on the same line as the TODO
include/trgdataformats/TriggerObjectOverlay.hpp
Errors
- Line 24: An unsigned integer appears to be used here.
include/trgdataformats/TriggerPrimitive.hpp
Errors
- Line 28: An unsigned integer appears to be used here.
- Line 31: An unsigned integer appears to be used here.
- Line 32: An unsigned integer appears to be used here.
- Line 33: An unsigned integer appears to be used here.
- Line 36: An unsigned integer appears to be used here.
- Line 38: An unsigned integer appears to be used here.
- Line 39: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 42: An unsigned integer appears to be used here.
- Line 43: An unsigned integer appears to be used here.
include/trgdataformats/Types.hpp
Errors
- Line 26: An unsigned integer appears to be used here.
- Line 28: An unsigned integer appears to be used here.
- Line 33: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 33: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 36: An unsigned integer appears to be used here.
- Line 44: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 44: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 47: An unsigned integer appears to be used here.
- Line 52: An unsigned integer appears to be used here.
- Line 57: An unsigned integer appears to be used here.
- Line 62: An unsigned integer appears to be used here.
pybindsrc/module.cpp
Warnings
- Line 14: namespace alias decl 'py' is unused
pybindsrc/registrators.hpp
Errors
- Line 24: Namespace should be terminated with '// namespace dunedaq::trgdataformats::python '
pybindsrc/trigger_activity.cpp
Errors
- Line 21: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 29: An unsigned integer appears to be used here.
- Line 33: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 36: An unsigned integer appears to be used here.
- Line 57: An unsigned integer appears to be used here.
- Line 58: An unsigned integer appears to be used here.
- Line 59: An unsigned integer appears to be used here.
- Line 60: An unsigned integer appears to be used here.
- Line 61: An unsigned integer appears to be used here.
- Line 65: An unsigned integer appears to be used here.
- Line 66: An unsigned integer appears to be used here.
- Line 67: An unsigned integer appears to be used here.
- Line 122: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 138: Small and focused functions are preferred: register_trigger_activity() has 84 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 36: Add #include
for unique_ptr<>
Warnings
- Line 27: do not declare C-style arrays, use std::array<> instead
- Line 17: nested namespaces can be concatenated
- Line 33: do not use reinterpret_cast
- Line 36: do not declare C-style arrays, use std::array<> instead
- Line 62: narrowing conversion from 'channel_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined
- Line 63: narrowing conversion from 'channel_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined
- Line 64: narrowing conversion from 'channel_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined
- Line 122: do not use reinterpret_cast
pybindsrc/trigger_candidate.cpp
Errors
- Line 21: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 29: An unsigned integer appears to be used here.
- Line 33: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 36: An unsigned integer appears to be used here.
- Line 59: An unsigned integer appears to be used here.
- Line 60: An unsigned integer appears to be used here.
- Line 61: An unsigned integer appears to be used here.
- Line 62: An unsigned integer appears to be used here.
- Line 63: An unsigned integer appears to be used here.
- Line 153: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 168: Small and focused functions are preferred: register_trigger_candidate() has 116 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 36: Add #include
for unique_ptr<>
Warnings
- Line 27: do not declare C-style arrays, use std::array<> instead
- Line 17: nested namespaces can be concatenated
- Line 33: do not use reinterpret_cast
- Line 36: do not declare C-style arrays, use std::array<> instead
- Line 153: do not use reinterpret_cast
pybindsrc/trigger_primitive.cpp
Errors
- Line 31: An unsigned integer appears to be used here.
- Line 32: An unsigned integer appears to be used here.
- Line 33: An unsigned integer appears to be used here.
- Line 34: An unsigned integer appears to be used here.
- Line 35: An unsigned integer appears to be used here.
- Line 36: An unsigned integer appears to be used here.
- Line 37: An unsigned integer appears to be used here.
- Line 38: An unsigned integer appears to be used here.
- Line 39: An unsigned integer appears to be used here.
Warnings
- Line 35: C-style casts are discouraged; use static_cast
unittest/Trgdataformats_test.cxx
Warnings
- Line 27: do not declare C-style arrays, use std::array<> instead