tpglibs
Unit Tests
| Test | Status |
|---|---|
| binary_signal_reader_test | ✅ Passed |
| avx_processors_test | ✅ Passed |
| avx_generator_test | ✅ Passed |
| avx_pipeline_test | ✅ Passed |
| avx_factory_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| include/tpglibs/AVXAbsRunSumProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXFactory.hpp | ❌ Needs formatting |
| include/tpglibs/AVXFixedPedestalSubtractProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXFrugalPedestalSubtractProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXPipeline.hpp | ❌ Needs formatting |
| include/tpglibs/AVXProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXRunSumProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXThresholdProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/AVXUtils.hpp | ❌ Needs formatting |
| include/tpglibs/AbstractFactory.hpp | ❌ Needs formatting |
| include/tpglibs/AbstractFactory.hxx | ❌ Needs formatting |
| include/tpglibs/AbstractProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveAbsRunSumProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveFactory.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveFrugalPedestalSubtractProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveRunSumProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveThresholdProcessor.hpp | ❌ Needs formatting |
| include/tpglibs/NaiveUtils.hpp | ❌ Needs formatting |
| include/tpglibs/ProcessorInternalStateBufferManager.hpp | ❌ Needs formatting |
| include/tpglibs/ProcessorInternalStateNameRegistry.hpp | ❌ Needs formatting |
| include/tpglibs/ProcessorMetricArray.hpp | ❌ Needs formatting |
| include/tpglibs/TPGPipeline.hpp | ❌ Needs formatting |
| include/tpglibs/TPGenerator.hpp | ❌ Needs formatting |
| include/tpglibs/testapp/reader/BinarySignalReader.hpp | ❌ Needs formatting |
| include/tpglibs/testapp/reader/BinarySignalReader.hxx | ❌ Needs formatting |
| pybindsrc/module.cpp | ✅ Already formatted |
| pybindsrc/pythonbindingsrenameme.cpp | ❌ Needs formatting |
| pybindsrc/registrators.hpp | ❌ Needs formatting |
| src/AVXAbsRunSumProcessor.cpp | ❌ Needs formatting |
| src/AVXFixedPedestalSubtractProcessor.cpp | ❌ Needs formatting |
| src/AVXFrugalPedestalSubtractProcessor.cpp | ❌ Needs formatting |
| src/AVXPipeline.cpp | ❌ Needs formatting |
| src/AVXRunSumProcessor.cpp | ❌ Needs formatting |
| src/AVXThresholdProcessor.cpp | ❌ Needs formatting |
| src/NaiveAbsRunSumProcessor.cpp | ❌ Needs formatting |
| src/NaiveFrugalPedestalSubtractProcessor.cpp | ❌ Needs formatting |
| src/NaiveRunSumProcessor.cpp | ❌ Needs formatting |
| src/NaiveThresholdProcessor.cpp | ❌ Needs formatting |
| src/TPGenerator.cpp | ❌ Needs formatting |
| test/apps/test_tpg_processor_app.cxx | ❌ Needs formatting |
| unittest/ProcessorInternalStateBufferManager_test.cxx | ❌ Needs formatting |
| unittest/ProcessorInternalStateNameRegistry_test.cxx | ❌ Needs formatting |
| unittest/avx_factory_test.cxx | ❌ Needs formatting |
| unittest/avx_generator_test.cxx | ❌ Needs formatting |
| unittest/avx_pipeline_test.cxx | ❌ Needs formatting |
| unittest/avx_processors_internal_state_collect_test.cxx | ❌ Needs formatting |
| unittest/avx_processors_test.cxx | ❌ Needs formatting |
| unittest/binary_signal_reader_test.cxx | ❌ Needs formatting |
| unittest/processor_state_registrate_collect_test.cxx | ❌ Needs formatting |
include/tpglibs/AVXAbsRunSumProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXABSRUNSUMPROCESSOR_HPP_
- Line 32: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXABSRUNSUMPROCESSOR_HPP_"
include/tpglibs/AVXFactory.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXFACTORY_HPP_
- Line 30: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXFACTORY_HPP_"
- Line 16: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 17: static storage declaration outside of class or function not allowed (if this isn't a header, please contact John Freeman)
- Line 19: Add #include
for shared_ptr<>
include/tpglibs/AVXFixedPedestalSubtractProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 12: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXFIXEDPEDESTALSUBTRACTPROCESSOR_HPP_
- Line 43: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXFIXEDPEDESTALSUBTRACTPROCESSOR_HPP_"
- Line 24: An unsigned integer appears to be used here.
- Line 27: An unsigned integer appears to be used here.
- Line 29: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
include/tpglibs/AVXFrugalPedestalSubtractProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 12: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXFRUGALPEDESTALSUBTRACTPROCESSOR_HPP_
- Line 55: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXFRUGALPEDESTALSUBTRACTPROCESSOR_HPP_"
- Line 34: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
include/tpglibs/AVXPipeline.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXPIPELINE_HPP_
- Line 55: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXPIPELINE_HPP_"
- Line 49: Add #include
for vector<>
include/tpglibs/AVXProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXPROCESSOR_HPP_
- Line 34: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXPROCESSOR_HPP_"
- Line 26: "virtual" is redundant since function is already declared as "override"
include/tpglibs/AVXRunSumProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 12: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXRUNSUMPROCESSOR_HPP_
- Line 60: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXRUNSUMPROCESSOR_HPP_"
include/tpglibs/AVXThresholdProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXTHRESHOLDPROCESSOR_HPP_
- Line 39: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXTHRESHOLDPROCESSOR_HPP_"
include/tpglibs/AVXUtils.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 15: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_AVXUTILS_HPP_
- Line 55: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_AVXUTILS_HPP_"
- Line 48: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
include/tpglibs/AbstractFactory.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_ABSTRACTFACTORY_HPP_
- Line 68: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_ABSTRACTFACTORY_HPP_"
include/tpglibs/AbstractProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_ABSTRACTPROCESSOR_HPP_
- Line 132: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_ABSTRACTPROCESSOR_HPP_"
- Line 16: Found other header after system header. Should be: AbstractProcessor.hh, other non-system headers, system headers.
- Line 39: An unsigned integer appears to be used here.
- Line 41: An unsigned integer appears to be used here.
- Line 44: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
- Line 113: Add #include
for string - Line 113: Add #include
for vector<>
include/tpglibs/NaiveAbsRunSumProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVEABSRUNSUMPROCESSOR_HPP_
- Line 34: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVEABSRUNSUMPROCESSOR_HPP_"
include/tpglibs/NaiveFactory.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVEFACTORY_HPP_
- Line 30: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVEFACTORY_HPP_"
- Line 16: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 17: static storage declaration outside of class or function not allowed (if this isn't a header, please contact John Freeman)
- Line 19: Add #include
for shared_ptr<>
include/tpglibs/NaiveFrugalPedestalSubtractProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVEFRUGALPEDESTALSUBTRACTPROCESSOR_HPP_
- Line 50: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVEFRUGALPEDESTALSUBTRACTPROCESSOR_HPP_"
include/tpglibs/NaiveProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVEPROCESSOR_HPP_
- Line 32: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVEPROCESSOR_HPP_"
- Line 25: "virtual" is redundant since function is already declared as "override"
include/tpglibs/NaiveRunSumProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 14: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVERUNSUMPROCESSOR_HPP_
- Line 57: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVERUNSUMPROCESSOR_HPP_"
include/tpglibs/NaiveThresholdProcessor.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVETHRESHOLDPROCESSOR_HPP_
- Line 39: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVETHRESHOLDPROCESSOR_HPP_"
include/tpglibs/NaiveUtils.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_NAIVEUTILS_HPP_
- Line 36: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_NAIVEUTILS_HPP_"
include/tpglibs/ProcessorInternalStateBufferManager.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 21: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_PROCESSORINTERNALSTATEBUFFERMANAGER_HPP_
- Line 262: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_PROCESSORINTERNALSTATEBUFFERMANAGER_HPP_"
- Line 81: You don't need a ; after a }
- Line 106: An unsigned integer appears to be used here.
- Line 109: An unsigned integer appears to be used here.
- Line 177: An unsigned integer appears to be used here.
- Line 183: An unsigned integer appears to be used here.
- Line 225: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
include/tpglibs/ProcessorInternalStateNameRegistry.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 16: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_PROCESSORINTERNALSTATENAMEREGISTRY_HPP_
- Line 243: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_PROCESSORINTERNALSTATENAMEREGISTRY_HPP_"
- Line 109: Access specifier "public" has already appeared in class ProcessorInternalStateNameRegistry
include/tpglibs/ProcessorMetricArray.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_PROCESSORMETRICARRAY_HPP_
- Line 26: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_PROCESSORMETRICARRAY_HPP_"
include/tpglibs/TPGPipeline.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_TPGPIPELINE_HPP_
- Line 144: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_TPGPIPELINE_HPP_"
- Line 113: An unsigned integer appears to be used here.
- Line 116: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 135: An unsigned integer appears to be used here.
- Line 45: Add #include
for string - Line 45: Add #include
for pair<> - Line 139: Add #include
for shared_ptr<>
include/tpglibs/TPGenerator.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_TPGENERATOR_HPP_
- Line 134: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_TPGENERATOR_HPP_"
- Line 32: An unsigned integer appears to be used here.
- Line 34: An unsigned integer appears to be used here.
- Line 37: An unsigned integer appears to be used here.
- Line 61: An unsigned integer appears to be used here.
- Line 88: An unsigned integer appears to be used here.
- Line 95: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 105: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 111: Add #include
for vector<> - Line 47: Add #include
for string
include/tpglibs/testapp/reader/BinarySignalReader.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #ifndef header guard has wrong style, please use: TPGLIBS_INCLUDE_TPGLIBS_TESTAPP_READER_BINARYSIGNALREADER_HPP_
- Line 77: #endif line should be "#endif // TPGLIBS_INCLUDE_TPGLIBS_TESTAPP_READER_BINARYSIGNALREADER_HPP_"
pybindsrc/module.cpp
Warnings
- Line 14: namespace alias decl 'py' is unused
pybindsrc/pythonbindingsrenameme.cpp
Warnings
- Line 17: unused parameter 'm'
pybindsrc/registrators.hpp
Errors
- Line 21: Namespace should be terminated with '// namespace dunedaq::tpglibs::python '
src/AVXAbsRunSumProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 31: narrowing conversion from 'int' to signed type 'short' is implementation-defined
- Line 48: do not use reinterpret_cast
- Line 13: initialization of 'AVXAbsRunSumProcessor_registrar' with static storage duration may throw an exception that cannot be caught
src/AVXFixedPedestalSubtractProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 13: initialization of 'AVXFixedPedestalSubtractProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 25: qualified name 'AVXProcessor::process' refers to a member overridden in subclass; did you mean 'tpglibs::AVXFrugalPedestalSubtractProcessor'?
src/AVXFrugalPedestalSubtractProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 20: Add #include
for shared_ptr<>
Warnings
- Line 13: initialization of 'AVXFrugalPedestalSubtractProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 48: narrowing conversion from 'int' to signed type 'short' is implementation-defined
src/AVXPipeline.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 64: An unsigned integer appears to be used here.
- Line 65: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 66: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 67: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 68: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 69: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 75: An unsigned integer appears to be used here.
- Line 71: Add #include
for vector<>
Warnings
- Line 64: do not declare C-style arrays, use std::array<> instead
- Line 64: multiple declarations in a single statement reduces readability
- Line 65: do not use reinterpret_cast
- Line 66: do not use reinterpret_cast
- Line 67: do not use reinterpret_cast
- Line 68: do not use reinterpret_cast
- Line 69: do not use reinterpret_cast
- Line 73: do not use array subscript when the index is not an integer constant expression
- Line 73: do not use array subscript when the index is not an integer constant expression
- Line 73: do not use array subscript when the index is not an integer constant expression
- Line 75: C-style casts are discouraged; use static_cast
- Line 75: do not use array subscript when the index is not an integer constant expression
- Line 75: C-style casts are discouraged; use static_cast
- Line 75: do not use array subscript when the index is not an integer constant expression
- Line 76: do not use array subscript when the index is not an integer constant expression
- Line 77: do not use array subscript when the index is not an integer constant expression
- Line 78: do not use array subscript when the index is not an integer constant expression
- Line 79: do not use array subscript when the index is not an integer constant expression
src/AVXRunSumProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 50: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 51: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 52: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 53: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 22: Add #include
for shared_ptr<>
Warnings
- Line 31: narrowing conversion from 'int' to signed type 'short' is implementation-defined
- Line 48: do not use reinterpret_cast
- Line 13: initialization of 'AVXRunSumProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 26: do not declare C-style arrays, use std::array<> instead
- Line 27: do not declare C-style arrays, use std::array<> instead
- Line 30: do not declare C-style arrays, use std::array<> instead
- Line 31: do not declare C-style arrays, use std::array<> instead
- Line 34: do not declare C-style arrays, use std::array<> instead
- Line 35: do not declare C-style arrays, use std::array<> instead
- Line 38: do not declare C-style arrays, use std::array<> instead
- Line 39: do not declare C-style arrays, use std::array<> instead
- Line 44: do not use array subscript when the index is not an integer constant expression
- Line 44: do not use array subscript when the index is not an integer constant expression
- Line 44: do not use pointer arithmetic
- Line 45: do not use array subscript when the index is not an integer constant expression
- Line 45: narrowing conversion from 'int' to signed type 'int16_t' (aka 'short') is implementation-defined
- Line 45: do not use array subscript when the index is not an integer constant expression
- Line 45: do not use pointer arithmetic
- Line 46: do not use array subscript when the index is not an integer constant expression
- Line 46: do not use array subscript when the index is not an integer constant expression
- Line 46: do not use pointer arithmetic
- Line 47: do not use array subscript when the index is not an integer constant expression
- Line 47: narrowing conversion from 'int' to signed type 'int16_t' (aka 'short') is implementation-defined
- Line 47: do not use array subscript when the index is not an integer constant expression
- Line 47: do not use pointer arithmetic
- Line 50: do not use reinterpret_cast
- Line 51: do not use reinterpret_cast
- Line 52: do not use reinterpret_cast
- Line 53: do not use reinterpret_cast
src/AVXThresholdProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 24: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Warnings
- Line 13: initialization of 'AVXThresholdProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 16: do not declare C-style arrays, use std::array<> instead
- Line 17: do not declare C-style arrays, use std::array<> instead
- Line 21: do not use array subscript when the index is not an integer constant expression
- Line 21: do not use array subscript when the index is not an integer constant expression
- Line 21: do not use pointer arithmetic
- Line 24: do not use reinterpret_cast
src/NaiveAbsRunSumProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 27: narrowing conversion from 'int' to signed type 'int16_t' (aka 'short') is implementation-defined
- Line 31: C-style casts are discouraged; use static_cast
- Line 13: initialization of 'NaiveAbsRunSumProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 19: do not use array subscript when the index is not an integer constant expression
- Line 19: narrowing conversion from 'int' to signed type 'value_type' (aka 'short') is implementation-defined
- Line 19: do not use array subscript when the index is not an integer constant expression
src/NaiveFrugalPedestalSubtractProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 20: Add #include
for shared_ptr<>
Warnings
- Line 13: initialization of 'NaiveFrugalPedestalSubtractProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 15: unused parameter 'plane_numbers'
- Line 39: do not use array subscript when the index is not an integer constant expression
- Line 39: do not use array subscript when the index is not an integer constant expression
- Line 40: do not use array subscript when the index is not an integer constant expression
- Line 43: do not use array subscript when the index is not an integer constant expression
- Line 43: do not use array subscript when the index is not an integer constant expression
- Line 44: do not use array subscript when the index is not an integer constant expression
- Line 47: do not use array subscript when the index is not an integer constant expression
- Line 48: do not use array subscript when the index is not an integer constant expression
- Line 49: do not use array subscript when the index is not an integer constant expression
- Line 53: do not use array subscript when the index is not an integer constant expression
- Line 54: do not use array subscript when the index is not an integer constant expression
- Line 55: do not use array subscript when the index is not an integer constant expression
- Line 58: do not use array subscript when the index is not an integer constant expression
- Line 58: narrowing conversion from 'int' to signed type 'value_type' (aka 'short') is implementation-defined
- Line 58: do not use array subscript when the index is not an integer constant expression
- Line 58: do not use array subscript when the index is not an integer constant expression
src/NaiveRunSumProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 22: Add #include
for shared_ptr<> - Line 55: Add #include
for min
Warnings
- Line 27: narrowing conversion from 'int' to signed type 'int16_t' (aka 'short') is implementation-defined
- Line 31: C-style casts are discouraged; use static_cast
- Line 13: initialization of 'NaiveRunSumProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 26: do not declare C-style arrays, use std::array<> instead
- Line 29: do not declare C-style arrays, use std::array<> instead
- Line 34: do not use array subscript when the index is not an integer constant expression
- Line 34: do not use array subscript when the index is not an integer constant expression
- Line 34: do not use pointer arithmetic
- Line 35: do not use array subscript when the index is not an integer constant expression
- Line 35: do not use array subscript when the index is not an integer constant expression
- Line 35: do not use pointer arithmetic
- Line 48: do not use array subscript when the index is not an integer constant expression
- Line 49: do not use array subscript when the index is not an integer constant expression
- Line 51: do not use array subscript when the index is not an integer constant expression
- Line 52: do not use array subscript when the index is not an integer constant expression
- Line 55: do not use array subscript when the index is not an integer constant expression
- Line 55: narrowing conversion from 'int' to signed type 'value_type' (aka 'short') is implementation-defined
src/NaiveThresholdProcessor.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 13: initialization of 'NaiveThresholdProcessor_registrar' with static storage duration may throw an exception that cannot be caught
- Line 16: do not declare C-style arrays, use std::array<> instead
- Line 20: do not use array subscript when the index is not an integer constant expression
- Line 20: do not use array subscript when the index is not an integer constant expression
- Line 20: do not use pointer arithmetic
- Line 27: do not use array subscript when the index is not an integer constant expression
- Line 27: do not use array subscript when the index is not an integer constant expression
- Line 28: do not use array subscript when the index is not an integer constant expression
- Line 28: do not use array subscript when the index is not an integer constant expression
src/TPGenerator.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 57: An unsigned integer appears to be used here.
- Line 14: Add #include
for string - Line 41: Add #include
for make_pair - Line 57: Add #include
for vector<> - Line 37: Add #include
for shared_ptr<>
Warnings
- Line 95: do not use reinterpret_cast
- Line 105: do not use reinterpret_cast
- Line 41: use emplace_back instead of push_back
test/apps/test_tpg_processor_app.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 24: An unsigned integer appears to be used here.
- Line 25: An unsigned integer appears to be used here.
- Line 26: An unsigned integer appears to be used here.
- Line 31: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 34: "cerr" should not be used for output in DUNE DAQ software.
- Line 39: "cerr" should not be used for output in DUNE DAQ software.
- Line 73: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 78: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 83: "cerr" should not be used for output in DUNE DAQ software.
- Line 85: "cerr" should not be used for output in DUNE DAQ software.
- Line 102: "cerr" should not be used for output in DUNE DAQ software.
- Line 110: "cerr" should not be used for output in DUNE DAQ software.
- Line 117: "cerr" should not be used for output in DUNE DAQ software.
- Line 128: "cerr" should not be used for output in DUNE DAQ software.
- Line 138: "cerr" should not be used for output in DUNE DAQ software.
- Line 144: "cerr" should not be used for output in DUNE DAQ software.
- Line 150: "cerr" should not be used for output in DUNE DAQ software.
- Line 157: "cerr" should not be used for output in DUNE DAQ software.
- Line 165: "cerr" should not be used for output in DUNE DAQ software.
- Line 170: "cerr" should not be used for output in DUNE DAQ software.
- Line 176: "cerr" should not be used for output in DUNE DAQ software.
- Line 196: "cerr" should not be used for output in DUNE DAQ software.
- Line 232: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 235: "cout" should not be used for output in DUNE DAQ software.
- Line 249: "cout" should not be used for output in DUNE DAQ software.
- Line 250: "cout" should not be used for output in DUNE DAQ software.
- Line 251: "cout" should not be used for output in DUNE DAQ software.
- Line 253: "cout" should not be used for output in DUNE DAQ software.
- Line 255: "cout" should not be used for output in DUNE DAQ software.
- Line 257: "cout" should not be used for output in DUNE DAQ software.
- Line 259: "cout" should not be used for output in DUNE DAQ software.
- Line 261: "cout" should not be used for output in DUNE DAQ software.
- Line 296: "cout" should not be used for output in DUNE DAQ software.
- Line 297: "cout" should not be used for output in DUNE DAQ software.
- Line 299: "cout" should not be used for output in DUNE DAQ software.
- Line 301: "cout" should not be used for output in DUNE DAQ software.
- Line 302: "cout" should not be used for output in DUNE DAQ software.
- Line 304: "cout" should not be used for output in DUNE DAQ software.
- Line 306: "cout" should not be used for output in DUNE DAQ software.
- Line 307: "cout" should not be used for output in DUNE DAQ software.
- Line 312: "cout" should not be used for output in DUNE DAQ software.
- Line 324: "cout" should not be used for output in DUNE DAQ software.
- Line 329: "cout" should not be used for output in DUNE DAQ software.
- Line 330: "cout" should not be used for output in DUNE DAQ software.
- Line 332: "cout" should not be used for output in DUNE DAQ software.
- Line 335: "cout" should not be used for output in DUNE DAQ software.
- Line 338: Small and focused functions are preferred: main() has 194 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 186: Add #include
for shared_ptr<> - Line 187: Add #include
for string
Warnings
- Line 17: nested namespaces can be concatenated
- Line 15: nested namespaces can be concatenated
- Line 37: do not use reinterpret_cast
- Line 31: do not use reinterpret_cast
- Line 64: narrowing conversion from 'unsigned long' to signed type 'difference_type' (aka 'long') is implementation-defined
- Line 64: C-style casts are discouraged; use static_cast
- Line 73: do not use reinterpret_cast
- Line 78: do not use reinterpret_cast
- Line 91: do not use pointer arithmetic
- Line 95: do not use pointer arithmetic
- Line 96: do not use pointer arithmetic
- Line 97: do not use pointer arithmetic
- Line 201: do not declare C-style arrays, use std::array<> instead
- Line 222: use auto when initializing with a cast to avoid duplicating the type name
- Line 223: use auto when initializing with a cast to avoid duplicating the type name
- Line 232: do not use reinterpret_cast
- Line 254: loop variable is copied but only used as const reference; consider making it a const reference
- Line 304: do not use array subscript when the index is not an integer constant expression
- Line 308: do not use array subscript when the index is not an integer constant expression
unittest/ProcessorInternalStateBufferManager_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 11: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 118: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 155: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 180: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 191: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 217: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 262: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 503: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 558: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 559: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 598: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 622: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 607: Add #include
for make_shared<> - Line 578: Add #include
for string
unittest/ProcessorInternalStateNameRegistry_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 98: Add #include
for move - Line 788: Add #include
for vector<>
unittest/avx_factory_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 74: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 75: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 26: Add #include
for shared_ptr<>
Warnings
- Line 28: do not declare C-style arrays, use std::array<> instead
- Line 65: Value stored to 'avx_abs_output' during its initialization is never read
- Line 66: Value stored to 'avx_abs_output' is never read
- Line 69: Value stored to 'avx_rs_output' during its initialization is never read
- Line 70: Value stored to 'avx_rs_output' is never read
- Line 73: do not declare C-style arrays, use std::array<> instead
- Line 73: multiple declarations in a single statement reduces readability
- Line 74: do not use reinterpret_cast
- Line 75: do not use reinterpret_cast
- Line 80: do not declare C-style arrays, use std::array<> instead
- Line 82: do not declare C-style arrays, use std::array<> instead
- Line 85: do not use array subscript when the index is not an integer constant expression
- Line 85: do not use array subscript when the index is not an integer constant expression
- Line 86: do not use array subscript when the index is not an integer constant expression
- Line 86: do not use array subscript when the index is not an integer constant expression
unittest/avx_generator_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 23: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 34: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 9: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 97: Add #include
for pair<> - Line 105: Add #include
for vector<> - Line 83: Add #include
for string
Warnings
- Line 95: do not use reinterpret_cast
- Line 105: do not use reinterpret_cast
- Line 73: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'int16_t' (aka 'short') is implementation-defined
unittest/avx_pipeline_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 90: An unsigned integer appears to be used here.
- Line 99: Add #include
for vector<> - Line 62: Add #include
for pair<> - Line 62: Add #include
for string
unittest/avx_processors_internal_state_collect_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 39: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 996: Add #include
for make_shared<>
unittest/avx_processors_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 76: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 77: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 78: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 30: Add #include
for shared_ptr<>
Warnings
- Line 31: narrowing conversion from 'int' to signed type 'short' is implementation-defined
- Line 48: do not use reinterpret_cast
- Line 32: do not declare C-style arrays, use std::array<> instead
- Line 68: Value stored to 'avx_abs_output' during its initialization is never read
- Line 69: Value stored to 'avx_abs_output' is never read
- Line 71: Value stored to 'avx_rs_output' during its initialization is never read
- Line 72: Value stored to 'avx_rs_output' is never read
- Line 75: do not declare C-style arrays, use std::array<> instead
- Line 75: multiple declarations in a single statement reduces readability
- Line 76: do not use reinterpret_cast
- Line 77: do not use reinterpret_cast
- Line 78: do not use reinterpret_cast
- Line 84: do not declare C-style arrays, use std::array<> instead
- Line 86: do not declare C-style arrays, use std::array<> instead
- Line 87: do not declare C-style arrays, use std::array<> instead
- Line 90: do not use array subscript when the index is not an integer constant expression
- Line 90: do not use array subscript when the index is not an integer constant expression
- Line 91: do not use array subscript when the index is not an integer constant expression
- Line 91: do not use array subscript when the index is not an integer constant expression
- Line 92: do not use array subscript when the index is not an integer constant expression
- Line 92: do not use array subscript when the index is not an integer constant expression
unittest/binary_signal_reader_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 29: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 68: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 127: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 124: Add #include
for string
Warnings
- Line 17: nested namespaces can be concatenated
- Line 15: nested namespaces can be concatenated
- Line 37: do not use reinterpret_cast
- Line 29: do not use reinterpret_cast
- Line 68: do not use reinterpret_cast
- Line 127: do not use reinterpret_cast
unittest/processor_state_registrate_collect_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 14: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 57: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 61: Add #include
for string