timinglibs
Unit Tests
No unit tests written.
Clang Formatting
| File | Status |
|---|---|
| include/timinglibs/TimingController.hpp | ❌ Needs formatting |
| include/timinglibs/TimingEndpointControllerBase.hpp | ❌ Needs formatting |
| include/timinglibs/TimingHardwareInterface.hpp | ❌ Needs formatting |
| include/timinglibs/TimingIssues.hpp | ❌ Needs formatting |
| include/timinglibs/detail/TimingController.hxx | ❌ Needs formatting |
| include/timinglibs/detail/TimingHardwareInterface.hxx | ❌ Needs formatting |
| include/timinglibs/timingcmd/Nljs.hpp | ❌ Needs formatting |
| include/timinglibs/timingcmd/Structs.hpp | ❌ Needs formatting |
| include/timinglibs/timingcmd/msgp.hpp | ❌ Needs formatting |
| plugins/TimingEndpointController.cpp | ❌ Needs formatting |
| plugins/TimingEndpointController.hpp | ✅ Already formatted |
| plugins/TimingFanoutController.cpp | ❌ Needs formatting |
| plugins/TimingFanoutController.hpp | ❌ Needs formatting |
| plugins/TimingHardwareManagerPDII.cpp | ❌ Needs formatting |
| plugins/TimingHardwareManagerPDII.hpp | ❌ Needs formatting |
| plugins/TimingMasterControllerPDII.cpp | ❌ Needs formatting |
| plugins/TimingMasterControllerPDII.hpp | ❌ Needs formatting |
| src/InfoGatherer.hpp | ❌ Needs formatting |
| src/TimingController.cpp | ❌ Needs formatting |
| src/TimingEndpointControllerBase.cpp | ❌ Needs formatting |
| src/TimingHardwareInterface.cpp | ❌ Needs formatting |
| src/TimingHardwareManagerBase.cpp | ❌ Needs formatting |
| src/TimingHardwareManagerBase.hpp | ❌ Needs formatting |
| src/TimingMasterControllerBase.cpp | ❌ Needs formatting |
| src/TimingMasterControllerBase.hpp | ❌ Needs formatting |
| src/detail/TimingHardwareManagerBase.hxx | ❌ Needs formatting |
include/timinglibs/TimingEndpointControllerBase.hpp
Errors
- Line 12: #ifndef header guard has wrong style, please use: TIMINGLIBS_INCLUDE_TIMINGLIBS_TIMINGENDPOINTCONTROLLERBASE_HPP_
- Line 74: #endif line should be "#endif // TIMINGLIBS_INCLUDE_TIMINGLIBS_TIMINGENDPOINTCONTROLLERBASE_HPP_"
include/timinglibs/TimingHardwareInterface.hpp
Errors
- Line 19: Found other header after system header. Should be: TimingHardwareInterface.hh, other non-system headers, system headers.
- Line 39: Zero-parameter constructors should not be marked explicit.
include/timinglibs/TimingIssues.hpp
Errors
- Line 135: Using C-style cast. Use static_cast
(...) instead - Line 140: Using C-style cast. Use static_cast
(...) instead - Line 145: Using C-style cast. Use static_cast
(...) instead - Line 121: Add #include
for queue<>
include/timinglibs/timingcmd/msgp.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 7: #ifndef header guard has wrong style, please use: TIMINGLIBS_INCLUDE_TIMINGLIBS_TIMINGCMD_MSGP_HPP_
- Line 363: #endif line should be "#endif // TIMINGLIBS_INCLUDE_TIMINGLIBS_TIMINGCMD_MSGP_HPP_"
- Line 32: Add #include
for string
plugins/TimingEndpointController.cpp
Warnings
- Line 29: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 28: nested namespaces can be concatenated
- Line 31: nested namespaces can be concatenated
plugins/TimingFanoutController.cpp
Errors
- Line 57: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 57: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 57: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 91: An unsigned integer appears to be used here.
Warnings
- Line 29: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 31: nested namespaces can be concatenated
- Line 50: qualified name 'TimingController::do_configure' refers to a member overridden in subclass; did you mean 'dunedaq::timinglibs::TimingEndpointControllerBase'?
plugins/TimingHardwareManagerPDII.cpp
Warnings
- Line 26: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 21: nested namespaces can be concatenated
- Line 32: do not use pointer arithmetic
- Line 55: do not use pointer arithmetic
- Line 56: do not use pointer arithmetic
- Line 57: do not use pointer arithmetic
- Line 81: do not use pointer arithmetic
- Line 82: do not use pointer arithmetic
- Line 83: do not use pointer arithmetic
- Line 84: do not use pointer arithmetic
- Line 85: do not use pointer arithmetic
- Line 111: do not use pointer arithmetic
- Line 112: do not use pointer arithmetic
- Line 113: do not use pointer arithmetic
- Line 137: do not use pointer arithmetic
- Line 159: do not use pointer arithmetic
- Line 181: do not use pointer arithmetic
- Line 182: do not use pointer arithmetic
- Line 183: do not use pointer arithmetic
- Line 207: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 209: do not use pointer arithmetic
- Line 233: do not use pointer arithmetic
- Line 255: do not use pointer arithmetic
- Line 256: do not use pointer arithmetic
- Line 257: do not use pointer arithmetic
- Line 281: do not use pointer arithmetic
- Line 282: do not use pointer arithmetic
- Line 283: do not use pointer arithmetic
- Line 284: do not use pointer arithmetic
- Line 285: do not use pointer arithmetic
- Line 286: do not use pointer arithmetic
- Line 287: do not use pointer arithmetic
- Line 315: do not use pointer arithmetic
- Line 337: do not use pointer arithmetic
- Line 338: do not use pointer arithmetic
- Line 339: do not use pointer arithmetic
- Line 340: do not use pointer arithmetic
- Line 29: nested namespaces can be concatenated
- Line 58: loop variable is copied but only used as const reference; consider making it a const reference
- Line 43: nested namespaces can be concatenated
- Line 202: 'info' used after it was moved
- Line 45: nested namespaces can be concatenated
- Line 154: default arguments on virtual or override methods are prohibited
- Line 155: default arguments on virtual or override methods are prohibited
- Line 14: prefer a lambda to std::bind
plugins/TimingMasterControllerPDII.cpp
Errors
- Line 40: An unsigned integer appears to be used here.
Warnings
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 27: nested namespaces can be concatenated
- Line 29: nested namespaces can be concatenated
src/InfoGatherer.hpp
Errors
- Line 215: Access specifier "protected:" appears after "private:", not before
- Line 202: Add #include
for move
src/TimingController.cpp
Errors
- Line 59: Add #include
for shared_ptr<> - Line 173: Add #include
for move
Warnings
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 21: nested namespaces can be concatenated
- Line 32: do not use pointer arithmetic
- Line 55: do not use pointer arithmetic
- Line 56: do not use pointer arithmetic
- Line 57: do not use pointer arithmetic
- Line 81: do not use pointer arithmetic
- Line 82: do not use pointer arithmetic
- Line 83: do not use pointer arithmetic
- Line 84: do not use pointer arithmetic
- Line 85: do not use pointer arithmetic
- Line 111: do not use pointer arithmetic
- Line 112: do not use pointer arithmetic
- Line 113: do not use pointer arithmetic
- Line 137: do not use pointer arithmetic
- Line 159: do not use pointer arithmetic
- Line 181: do not use pointer arithmetic
- Line 182: do not use pointer arithmetic
- Line 183: do not use pointer arithmetic
- Line 207: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 209: do not use pointer arithmetic
- Line 233: do not use pointer arithmetic
- Line 255: do not use pointer arithmetic
- Line 256: do not use pointer arithmetic
- Line 257: do not use pointer arithmetic
- Line 281: do not use pointer arithmetic
- Line 282: do not use pointer arithmetic
- Line 283: do not use pointer arithmetic
- Line 284: do not use pointer arithmetic
- Line 285: do not use pointer arithmetic
- Line 286: do not use pointer arithmetic
- Line 287: do not use pointer arithmetic
- Line 315: do not use pointer arithmetic
- Line 337: do not use pointer arithmetic
- Line 338: do not use pointer arithmetic
- Line 339: do not use pointer arithmetic
- Line 340: do not use pointer arithmetic
- Line 134: narrowing conversion from 'rep' (aka 'long') to signed type 'int' is implementation-defined
src/TimingEndpointControllerBase.cpp
Errors
- Line 110: Add #include
for move
Warnings
- Line 29: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 31: nested namespaces can be concatenated
src/TimingHardwareInterface.cpp
Warnings
- Line 26: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: nested namespaces can be concatenated
src/TimingHardwareManagerBase.cpp
Errors
- Line 150: Use of Run Time Type Information not allowed unless this code is meant to test other code
- Line 167: Use of Run Time Type Information not allowed unless this code is meant to test other code
- Line 460: Use of Run Time Type Information not allowed unless this code is meant to test other code
Warnings
- Line 26: nested namespaces can be concatenated
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 21: nested namespaces can be concatenated
- Line 32: do not use pointer arithmetic
- Line 55: do not use pointer arithmetic
- Line 56: do not use pointer arithmetic
- Line 57: do not use pointer arithmetic
- Line 81: do not use pointer arithmetic
- Line 82: do not use pointer arithmetic
- Line 83: do not use pointer arithmetic
- Line 84: do not use pointer arithmetic
- Line 85: do not use pointer arithmetic
- Line 111: do not use pointer arithmetic
- Line 112: do not use pointer arithmetic
- Line 113: do not use pointer arithmetic
- Line 137: do not use pointer arithmetic
- Line 159: do not use pointer arithmetic
- Line 181: do not use pointer arithmetic
- Line 182: do not use pointer arithmetic
- Line 183: do not use pointer arithmetic
- Line 207: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 209: do not use pointer arithmetic
- Line 233: do not use pointer arithmetic
- Line 255: do not use pointer arithmetic
- Line 256: do not use pointer arithmetic
- Line 257: do not use pointer arithmetic
- Line 281: do not use pointer arithmetic
- Line 282: do not use pointer arithmetic
- Line 283: do not use pointer arithmetic
- Line 284: do not use pointer arithmetic
- Line 285: do not use pointer arithmetic
- Line 286: do not use pointer arithmetic
- Line 287: do not use pointer arithmetic
- Line 315: do not use pointer arithmetic
- Line 337: do not use pointer arithmetic
- Line 338: do not use pointer arithmetic
- Line 339: do not use pointer arithmetic
- Line 340: do not use pointer arithmetic
- Line 202: 'info' used after it was moved
- Line 222: unnecessary temporary object created while calling emplace
- Line 229: default arguments on virtual or override methods are prohibited
- Line 235: redundant get() call on smart pointer
- Line 241: redundant get() call on smart pointer
- Line 249: default arguments on virtual or override methods are prohibited
- Line 255: redundant get() call on smart pointer
- Line 261: redundant get() call on smart pointer
- Line 275: redundant get() call on smart pointer
- Line 45: nested namespaces can be concatenated
- Line 154: default arguments on virtual or override methods are prohibited
- Line 155: default arguments on virtual or override methods are prohibited
src/TimingHardwareManagerBase.hpp
Errors
- Line 12: #ifndef header guard has wrong style, please use: TIMINGLIBS_SRC_TIMINGHARDWAREMANAGERBASE_HPP_
- Line 174: #endif line should be "#endif // TIMINGLIBS_SRC_TIMINGHARDWAREMANAGERBASE_HPP_"
- Line 87: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 87: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
- Line 87: Missing email address in TODO comment; it should appear on the same line as the TODO
src/TimingMasterControllerBase.cpp
Errors
- Line 201: Add #include
for move
Warnings
- Line 22: macro 'TLVL_ENTER_EXIT_METHODS' used to declare a constant; consider using a 'constexpr' constant
- Line 26: nested namespaces can be concatenated
src/TimingMasterControllerBase.hpp
Errors
- Line 12: #ifndef header guard has wrong style, please use: TIMINGLIBS_SRC_TIMINGMASTERCONTROLLERBASE_HPP_
- Line 87: #endif line should be "#endif // TIMINGLIBS_SRC_TIMINGMASTERCONTROLLERBASE_HPP_"