tdemodules
Unit Tests
No unit tests written.
Errors in Documentation Links
docs/README.md
- [ERROR] file:///home/runner/work/tdemodules/tdemodules/docs/docs/first_time_setup_amc.md File not found. Check if file exists and path is correct
Clang Formatting
| File | Status |
|---|---|
| include/tdemodules/AMCController.hpp | ❌ Needs formatting |
| include/tdemodules/AMCProtocolClient.hpp | ❌ Needs formatting |
| plugins/TDEAMCModule.cpp | ❌ Needs formatting |
| plugins/TDEAMCModule.hpp | ❌ Needs formatting |
| pybindsrc/amc.cpp | ❌ Needs formatting |
| pybindsrc/module.cpp | ✅ Already formatted |
| pybindsrc/registrators.hpp | ❌ Needs formatting |
| src/AMCController.cpp | ❌ Needs formatting |
| src/AMCProtocolClient.cpp | ❌ Needs formatting |
| src/utilities.cpp | ❌ Needs formatting |
| src/utilities.hpp | ❌ Needs formatting |
| unittest/Placeholder_test.cxx | ✅ Already formatted |
include/tdemodules/AMCController.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: TDEMODULES_INCLUDE_TDEMODULES_AMCCONTROLLER_HPP_
- Line 57: #endif line should be "#endif // TDEMODULES_INCLUDE_TDEMODULES_AMCCONTROLLER_HPP_"
- Line 8: Found other header after system header. Should be: AMCController.hh, other non-system headers, system headers.
- Line 16: An unsigned integer appears to be used here.
- Line 25: An unsigned integer appears to be used here.
- Line 31: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 41: An unsigned integer appears to be used here.
- Line 44: An unsigned integer appears to be used here.
- Line 45: An unsigned integer appears to be used here.
- Line 46: An unsigned integer appears to be used here.
- Line 47: An unsigned integer appears to be used here.
- Line 49: An unsigned integer appears to be used here.
include/tdemodules/AMCProtocolClient.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: TDEMODULES_INCLUDE_TDEMODULES_AMCPROTOCOLCLIENT_HPP_
- Line 97: #endif line should be "#endif // TDEMODULES_INCLUDE_TDEMODULES_AMCPROTOCOLCLIENT_HPP_"
- Line 10: Found other header after system header. Should be: AMCProtocolClient.hh, other non-system headers, system headers.
- Line 26: An unsigned integer appears to be used here.
- Line 33: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 51: An unsigned integer appears to be used here.
- Line 52: An unsigned integer appears to be used here.
- Line 56: An unsigned integer appears to be used here.
- Line 57: An unsigned integer appears to be used here.
- Line 61: An unsigned integer appears to be used here.
- Line 62: An unsigned integer appears to be used here.
- Line 68: An unsigned integer appears to be used here.
- Line 70: An unsigned integer appears to be used here.
- Line 72: An unsigned integer appears to be used here.
- Line 76: An unsigned integer appears to be used here.
- Line 83: An unsigned integer appears to be used here.
- Line 84: An unsigned integer appears to be used here.
- Line 86: Add #include
for string
plugins/TDEAMCModule.cpp
Errors
- Line 53: An unsigned integer appears to be used here.
- Line 62: "cout" should not be used for output in DUNE DAQ software.
- Line 61: Add #include
for make_unique<> - Line 44: Add #include
for move
Warnings
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_INCLUDE_AMCCONTROLLER_HPP___', which is a reserved identifier
- Line 54: do not use pointer arithmetic
plugins/TDEAMCModule.hpp
Errors
- Line 64: Add #include
for unique_ptr<>
pybindsrc/amc.cpp
Errors
- Line 22: An unsigned integer appears to be used here.
- Line 22: Add #include
for string
Warnings
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_INCLUDE_AMCCONTROLLER_HPP___', which is a reserved identifier
pybindsrc/module.cpp
Warnings
- Line 14: namespace alias decl 'py' is unused
pybindsrc/registrators.hpp
Errors
- Line 21: Namespace should be terminated with '// namespace dunedaq::tdemodules::python '
src/AMCController.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 8: Found other header after system header. Should be: AMCController.hh, other non-system headers, system headers.
- Line 14: An unsigned integer appears to be used here.
- Line 20: An unsigned integer appears to be used here.
- Line 21: An unsigned integer appears to be used here.
- Line 24: An unsigned integer appears to be used here.
- Line 25: An unsigned integer appears to be used here.
- Line 26: An unsigned integer appears to be used here.
- Line 27: An unsigned integer appears to be used here.
- Line 31: An unsigned integer appears to be used here.
- Line 32: An unsigned integer appears to be used here.
- Line 33: An unsigned integer appears to be used here.
- Line 34: An unsigned integer appears to be used here.
- Line 38: An unsigned integer appears to be used here.
- Line 39: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 41: An unsigned integer appears to be used here.
- Line 45: An unsigned integer appears to be used here.
- Line 46: An unsigned integer appears to be used here.
- Line 77: An unsigned integer appears to be used here.
- Line 85: An unsigned integer appears to be used here.
- Line 86: An unsigned integer appears to be used here.
- Line 95: An unsigned integer appears to be used here.
- Line 96: An unsigned integer appears to be used here.
- Line 14: Add #include
for string - Line 77: Add #include
for vector<>
Warnings
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_INCLUDE_AMCCONTROLLER_HPP___', which is a reserved identifier
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_INCLUDE_AMCPROTOCOLCLIENT_HPP___', which is a reserved identifier
- Line 10: nested namespaces can be concatenated
- Line 86: variable 'word0' is not initialized
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_SRC_UTILITIES_HPP___', which is a reserved identifier
- Line 7: nested namespaces can be concatenated
src/AMCProtocolClient.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 5: Found other header after system header. Should be: AMCProtocolClient.hh, other non-system headers, system headers.
- Line 7: Found other header after system header. Should be: AMCProtocolClient.hh, other non-system headers, system headers.
- Line 13: An unsigned integer appears to be used here.
- Line 30: An unsigned integer appears to be used here.
- Line 31: An unsigned integer appears to be used here.
- Line 35: An unsigned integer appears to be used here.
- Line 39: An unsigned integer appears to be used here.
- Line 50: An unsigned integer appears to be used here.
- Line 73: An unsigned integer appears to be used here.
- Line 77: An unsigned integer appears to be used here.
- Line 88: An unsigned integer appears to be used here.
- Line 103: An unsigned integer appears to be used here.
- Line 111: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 114: An unsigned integer appears to be used here.
- Line 119: An unsigned integer appears to be used here.
- Line 111: Add #include
for string - Line 50: Add #include
for vector<>
Warnings
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_INCLUDE_AMCPROTOCOLCLIENT_HPP___', which is a reserved identifier
- Line 9: nested namespaces can be concatenated
- Line 111: do not use reinterpret_cast
- Line 111: do not use pointer arithmetic
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_SRC_UTILITIES_HPP___', which is a reserved identifier
- Line 7: nested namespaces can be concatenated
src/utilities.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: An unsigned integer appears to be used here.
- Line 10: An unsigned integer appears to be used here.
- Line 11: An unsigned integer appears to be used here.
- Line 17: An unsigned integer appears to be used here.
- Line 18: An unsigned integer appears to be used here.
- Line 19: An unsigned integer appears to be used here.
- Line 24: Namespace should be terminated with '// namespace tdemodules '
- Line 17: Add #include
for vector<>
Warnings
- Line 5: nested namespaces can be concatenated
- Line 11: do not declare C-style arrays, use std::array<> instead
- Line 13: do not use pointer arithmetic
- Line 19: do not declare C-style arrays, use std::array<> instead
- Line 21: do not use pointer arithmetic
- Line 2: declaration uses identifier '__DUNEDAQ_TDEMODULES_SRC_UTILITIES_HPP___', which is a reserved identifier
- Line 7: nested namespaces can be concatenated
src/utilities.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: TDEMODULES_SRC_UTILITIES_HPP_
- Line 16: #endif line should be "#endif // TDEMODULES_SRC_UTILITIES_HPP_"
- Line 10: An unsigned integer appears to be used here.
- Line 11: An unsigned integer appears to be used here.