sspmodules

Unit Tests

No unit tests written.

Clang Formatting

File	Status
plugins/SSPLEDCalibModule.cpp	❌ Needs formatting
plugins/SSPLEDCalibModule.hpp	❌ Needs formatting
src/SSPIssues.hpp	❌ Needs formatting
src/SSPLEDCalibWrapper.cpp	❌ Needs formatting
src/SSPLEDCalibWrapper.hpp	❌ Needs formatting
src/anlBoard/Device.hpp	❌ Needs formatting
src/anlBoard/DeviceInterface.cxx	❌ Needs formatting
src/anlBoard/DeviceInterface.hpp	❌ Needs formatting
src/anlBoard/DeviceManager.cxx	❌ Needs formatting
src/anlBoard/DeviceManager.hpp	❌ Needs formatting
src/anlBoard/EthernetDevice.cxx	❌ Needs formatting
src/anlBoard/EthernetDevice.hpp	❌ Needs formatting
src/anlBoard/EventPacket.cxx	❌ Needs formatting
src/anlBoard/EventPacket.hpp	❌ Needs formatting
src/anlBoard/RegMap.cxx	✅ Already formatted
src/anlBoard/RegMap.hpp	❌ Needs formatting
src/anlBoard/SSPTypes.hpp	❌ Needs formatting
src/anlBoard/anlExceptions.hpp	❌ Needs formatting
test/apps/ssp_tcp_test.cxx	❌ Needs formatting
test/apps/ssp_udp_test.cxx	❌ Needs formatting

plugins/SSPLEDCalibModule.cpp

Errors

• Line 38: Add #include for string
• Line 52: Add #include for shared_ptr<>

Warnings

• Line 35: nested namespaces can be concatenated
• Line 23: nested namespaces can be concatenated
• Line 22: nested namespaces can be concatenated
• Line 89: default arguments on virtual or override methods are prohibited
• Line 26: nested namespaces can be concatenated
• Line 30: consider replacing 'unsigned long' with 'uint64'
• Line 31: consider replacing 'unsigned long' with 'uint64'
• Line 32: consider replacing 'unsigned long' with 'uint64'
• Line 33: consider replacing 'unsigned short' with 'uint16'
• Line 127: consider replacing 'unsigned long' with 'uint64'
• Line 26: nested namespaces can be concatenated
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 25: nested namespaces can be concatenated
• Line 17: nested namespaces can be concatenated
• Line 98: do not declare C-style arrays, use std::array<> instead

src/SSPIssues.hpp

Errors

• Line 12: Found other header after system header. Should be: SSPIssues.hh, other non-system headers, system headers.

src/SSPLEDCalibWrapper.cpp

Errors

• Line 287: Add #include for vector<>
• Line 292: Add #include for string

Warnings

• Line 26: nested namespaces can be concatenated
• Line 30: use nullptr
• Line 172: C-style casts are discouraged; use static_cast
• Line 172: C-style casts are discouraged; use static_cast
• Line 184: C-style casts are discouraged; use static_cast
• Line 184: C-style casts are discouraged; use static_cast
• Line 23: nested namespaces can be concatenated
• Line 61: private field 'm_double_pulse' is not used
• Line 22: nested namespaces can be concatenated
• Line 89: default arguments on virtual or override methods are prohibited
• Line 26: nested namespaces can be concatenated
• Line 30: consider replacing 'unsigned long' with 'uint64'
• Line 31: consider replacing 'unsigned long' with 'uint64'
• Line 32: consider replacing 'unsigned long' with 'uint64'
• Line 33: consider replacing 'unsigned short' with 'uint16'
• Line 127: consider replacing 'unsigned long' with 'uint64'
• Line 26: nested namespaces can be concatenated
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 25: nested namespaces can be concatenated
• Line 17: nested namespaces can be concatenated
• Line 98: do not declare C-style arrays, use std::array<> instead

src/anlBoard/DeviceInterface.cxx

Errors

• Line 70: C-style comment syntax detected; please use either C++ style "//" or Doxygen style

Warnings

• Line 22: nested namespaces can be concatenated
• Line 89: default arguments on virtual or override methods are prohibited
• Line 56: use nullptr
• Line 271: use nullptr
• Line 412: variable 'val' is not initialized
• Line 26: nested namespaces can be concatenated
• Line 30: consider replacing 'unsigned long' with 'uint64'
• Line 31: consider replacing 'unsigned long' with 'uint64'
• Line 32: consider replacing 'unsigned long' with 'uint64'
• Line 33: consider replacing 'unsigned short' with 'uint16'
• Line 127: consider replacing 'unsigned long' with 'uint64'
• Line 26: nested namespaces can be concatenated
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 25: nested namespaces can be concatenated
• Line 17: nested namespaces can be concatenated
• Line 19: nested namespaces can be concatenated
• Line 122: do not declare C-style arrays, use std::array<> instead
• Line 138: do not declare C-style arrays, use std::array<> instead
• Line 145: do not declare C-style arrays, use std::array<> instead
• Line 146: do not declare C-style arrays, use std::array<> instead
• Line 147: do not declare C-style arrays, use std::array<> instead
• Line 166: do not declare C-style arrays, use std::array<> instead
• Line 167: do not declare C-style arrays, use std::array<> instead
• Line 178: do not declare C-style arrays, use std::array<> instead
• Line 179: do not declare C-style arrays, use std::array<> instead
• Line 190: do not declare C-style arrays, use std::array<> instead
• Line 191: do not declare C-style arrays, use std::array<> instead
• Line 203: do not declare C-style arrays, use std::array<> instead
• Line 204: do not declare C-style arrays, use std::array<> instead
• Line 205: do not declare C-style arrays, use std::array<> instead
• Line 206: do not declare C-style arrays, use std::array<> instead
• Line 207: do not declare C-style arrays, use std::array<> instead
• Line 209: do not declare C-style arrays, use std::array<> instead
• Line 210: do not declare C-style arrays, use std::array<> instead
• Line 211: do not declare C-style arrays, use std::array<> instead
• Line 212: do not declare C-style arrays, use std::array<> instead
• Line 213: do not declare C-style arrays, use std::array<> instead
• Line 214: do not declare C-style arrays, use std::array<> instead
• Line 215: do not declare C-style arrays, use std::array<> instead
• Line 216: do not declare C-style arrays, use std::array<> instead
• Line 217: do not declare C-style arrays, use std::array<> instead
• Line 235: do not declare C-style arrays, use std::array<> instead
• Line 245: do not declare C-style arrays, use std::array<> instead
• Line 257: do not declare C-style arrays, use std::array<> instead
• Line 258: do not declare C-style arrays, use std::array<> instead
• Line 259: do not declare C-style arrays, use std::array<> instead
• Line 260: do not declare C-style arrays, use std::array<> instead
• Line 261: do not declare C-style arrays, use std::array<> instead
• Line 262: do not declare C-style arrays, use std::array<> instead
• Line 263: do not declare C-style arrays, use std::array<> instead
• Line 98: do not declare C-style arrays, use std::array<> instead
• Line 14: nested namespaces can be concatenated

src/anlBoard/DeviceInterface.hpp

Errors

• Line 44: Zero-parameter constructors should not be marked explicit.

src/anlBoard/DeviceManager.cxx

Warnings

• Line 22: nested namespaces can be concatenated
• Line 89: default arguments on virtual or override methods are prohibited
• Line 167: use nullptr
• Line 169: moving a temporary object prevents copy elision
• Line 26: nested namespaces can be concatenated
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 25: nested namespaces can be concatenated
• Line 98: do not declare C-style arrays, use std::array<> instead
• Line 14: nested namespaces can be concatenated

src/anlBoard/EthernetDevice.cxx

Warnings

• Line 22: nested namespaces can be concatenated
• Line 89: default arguments on virtual or override methods are prohibited
• Line 19: initialization of 'fIo_service' with static storage duration may throw an exception that cannot be caught
• Line 106: variable 'txSize' is not initialized
• Line 107: variable 'rxSizeExpected' is not initialized
• Line 126: variable 'txSize' is not initialized
• Line 127: variable 'rxSizeExpected' is not initialized
• Line 147: variable 'txSize' is not initialized
• Line 148: variable 'rxSizeExpected' is not initialized
• Line 167: variable 'txSize' is not initialized
• Line 168: variable 'rxSizeExpected' is not initialized
• Line 201: variable 'txSize' is not initialized
• Line 202: variable 'rxSizeExpected' is not initialized
• Line 214: do not use pointer arithmetic
• Line 214: do not use array subscript when the index is not an integer constant expression
• Line 224: variable 'txSize' is not initialized
• Line 225: variable 'rxSizeExpected' is not initialized
• Line 236: do not use array subscript when the index is not an integer constant expression
• Line 236: do not use pointer arithmetic
• Line 311: C-style casts are discouraged; use static_cast
• Line 319: converting integer literal to bool, use bool literal instead
• Line 25: nested namespaces can be concatenated
• Line 98: do not declare C-style arrays, use std::array<> instead
• Line 14: nested namespaces can be concatenated

src/anlBoard/EventPacket.cxx

Warnings

• Line 39: C-style casts are discouraged; use static_cast
• Line 39: C-style casts are discouraged; use static_cast
• Line 40: C-style casts are discouraged; use static_cast
• Line 40: C-style casts are discouraged; use static_cast
• Line 41: C-style casts are discouraged; use static_cast
• Line 41: consider replacing 'unsigned long' with 'uint64'
• Line 41: C-style casts are discouraged; use static_cast
• Line 41: consider replacing 'unsigned long' with 'uint64'
• Line 42: C-style casts are discouraged; use static_cast
• Line 42: consider replacing 'unsigned long' with 'uint64'
• Line 42: C-style casts are discouraged; use static_cast
• Line 42: consider replacing 'unsigned long' with 'uint64'
• Line 46: C-style casts are discouraged; use static_cast
• Line 46: C-style casts are discouraged; use static_cast
• Line 50: redundant cast to the same type
• Line 50: C-style casts are discouraged; use static_cast
• Line 50: redundant cast to the same type
• Line 50: C-style casts are discouraged; use static_cast
• Line 50: redundant cast to the same type
• Line 50: C-style casts are discouraged; use static_cast
• Line 71: do not use pointer arithmetic
• Line 17: nested namespaces can be concatenated
• Line 98: do not declare C-style arrays, use std::array<> instead

src/anlBoard/RegMap.cxx

Warnings

• Line 19: nested namespaces can be concatenated
• Line 122: do not declare C-style arrays, use std::array<> instead
• Line 138: do not declare C-style arrays, use std::array<> instead
• Line 145: do not declare C-style arrays, use std::array<> instead
• Line 146: do not declare C-style arrays, use std::array<> instead
• Line 147: do not declare C-style arrays, use std::array<> instead
• Line 166: do not declare C-style arrays, use std::array<> instead
• Line 167: do not declare C-style arrays, use std::array<> instead
• Line 178: do not declare C-style arrays, use std::array<> instead
• Line 179: do not declare C-style arrays, use std::array<> instead
• Line 190: do not declare C-style arrays, use std::array<> instead
• Line 191: do not declare C-style arrays, use std::array<> instead
• Line 203: do not declare C-style arrays, use std::array<> instead
• Line 204: do not declare C-style arrays, use std::array<> instead
• Line 205: do not declare C-style arrays, use std::array<> instead
• Line 206: do not declare C-style arrays, use std::array<> instead
• Line 207: do not declare C-style arrays, use std::array<> instead
• Line 209: do not declare C-style arrays, use std::array<> instead
• Line 210: do not declare C-style arrays, use std::array<> instead
• Line 211: do not declare C-style arrays, use std::array<> instead
• Line 212: do not declare C-style arrays, use std::array<> instead
• Line 213: do not declare C-style arrays, use std::array<> instead
• Line 214: do not declare C-style arrays, use std::array<> instead
• Line 215: do not declare C-style arrays, use std::array<> instead
• Line 216: do not declare C-style arrays, use std::array<> instead
• Line 217: do not declare C-style arrays, use std::array<> instead
• Line 235: do not declare C-style arrays, use std::array<> instead
• Line 245: do not declare C-style arrays, use std::array<> instead
• Line 257: do not declare C-style arrays, use std::array<> instead
• Line 258: do not declare C-style arrays, use std::array<> instead
• Line 259: do not declare C-style arrays, use std::array<> instead
• Line 260: do not declare C-style arrays, use std::array<> instead
• Line 261: do not declare C-style arrays, use std::array<> instead
• Line 262: do not declare C-style arrays, use std::array<> instead
• Line 263: do not declare C-style arrays, use std::array<> instead
• Line 14: nested namespaces can be concatenated

src/anlBoard/SSPTypes.hpp

Errors

• Line 13: static storage declaration outside of class or function not allowed (if this isn't a header, please contact John Freeman)

test/apps/ssp_tcp_test.cxx

Errors

• Line 0: The standard copyright message wasn't found.
• Line 8: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 17: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 20: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 21: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 22: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 23: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 90: Using C-style cast. Use one of the C++ cast operators instead
• Line 127: Use of NULL #define found; prefer using the nullptr keyword
• Line 137: "printf" should not be used for output in DUNE DAQ software.

Warnings

• Line 1: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
• Line 2: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
• Line 3: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead
• Line 20: macro 'PORT' used to declare a constant; consider using a 'constexpr' constant
• Line 21: macro 'BUFFER_SIZE' used to declare a constant; consider using a 'constexpr' constant
• Line 22: macro 'TIMEOUT_SEC' used to declare a constant; consider using a 'constexpr' constant
• Line 23: macro 'RETRY_COUNT' used to declare a constant; consider using a 'constexpr' constant
• Line 35: do not declare C-style arrays, use std::array<> instead
• Line 39: variable 'sockfd' is not initialized
• Line 60: do not use C-style cast to convert between unrelated types
• Line 60: C-style casts are discouraged; use reinterpret_cast
• Line 61: do not use C-style cast to convert between unrelated types
• Line 61: C-style casts are discouraged; use reinterpret_cast
• Line 67: do not use C-style cast to convert between unrelated types
• Line 67: C-style casts are discouraged; use reinterpret_cast
• Line 85: do not use C-style cast to convert between unrelated types
• Line 85: C-style casts are discouraged; use reinterpret_cast
• Line 90: do not use C-style cast to convert between unrelated types
• Line 90: C-style casts are discouraged; use reinterpret_cast
• Line 101: multiple declarations in a single statement reduces readability
• Line 122: do not use pointer arithmetic
• Line 126: do not use pointer arithmetic
• Line 127: do not use pointer arithmetic
• Line 127: use nullptr
• Line 129: variable 'value' is not initialized

test/apps/ssp_udp_test.cxx

Errors

• Line 0: The standard copyright message wasn't found.
• Line 8: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 20: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 21: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 22: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 23: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
• Line 84: Using C-style cast. Use one of the C++ cast operators instead
• Line 121: Use of NULL #define found; prefer using the nullptr keyword
• Line 132: "printf" should not be used for output in DUNE DAQ software.

Warnings

• Line 1: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
• Line 2: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
• Line 3: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead
• Line 20: macro 'PORT' used to declare a constant; consider using a 'constexpr' constant
• Line 21: macro 'BUFFER_SIZE' used to declare a constant; consider using a 'constexpr' constant
• Line 22: macro 'TIMEOUT_SEC' used to declare a constant; consider using a 'constexpr' constant
• Line 23: macro 'RETRY_COUNT' used to declare a constant; consider using a 'constexpr' constant
• Line 35: do not declare C-style arrays, use std::array<> instead
• Line 39: variable 'sockfd' is not initialized
• Line 59: do not use C-style cast to convert between unrelated types
• Line 59: C-style casts are discouraged; use reinterpret_cast
• Line 60: do not use C-style cast to convert between unrelated types
• Line 60: C-style casts are discouraged; use reinterpret_cast
• Line 79: do not use C-style cast to convert between unrelated types
• Line 79: C-style casts are discouraged; use reinterpret_cast
• Line 79: do not use C-style cast to convert between unrelated types
• Line 79: C-style casts are discouraged; use reinterpret_cast
• Line 84: do not use C-style cast to convert between unrelated types
• Line 84: C-style casts are discouraged; use reinterpret_cast
• Line 84: do not use C-style cast to convert between unrelated types
• Line 84: C-style casts are discouraged; use reinterpret_cast
• Line 95: multiple declarations in a single statement reduces readability
• Line 116: do not use pointer arithmetic
• Line 120: do not use pointer arithmetic
• Line 121: do not use pointer arithmetic
• Line 121: use nullptr
• Line 123: variable 'value' is not initialized