opmonlib
Unit Tests
| Test | Status |
|---|---|
| opmon_facility_test | ✅ Passed |
| schema_conversion_test | ✅ Passed |
| monitorable_object_test | ✅ Passed |
Errors in Documentation Links
docs/Instructions-for-DAQ-module-users.md
- [404] https://github.com/DUNE-DAQ/opmonlib/blob/mroda/protobuf/include/opmonlib/MonitorableObject.hpp Rejected status code: 404 Not Found
docs/README.md
- [ERROR] file:///file/path/file_name.out File not found. Check if file exists and path is correct
Clang Formatting
| File | Status |
|---|---|
| include/opmonlib/BackendOpMonFacility.hpp | ❌ Needs formatting |
| include/opmonlib/Issues.hpp | ❌ Needs formatting |
| include/opmonlib/JSonOpMonFacility.hpp | ❌ Needs formatting |
| include/opmonlib/MonitorableObject.hpp | ❌ Needs formatting |
| include/opmonlib/OpMonFacility.hpp | ❌ Needs formatting |
| include/opmonlib/OpMonManager.hpp | ❌ Needs formatting |
| include/opmonlib/Utils.hpp | ❌ Needs formatting |
| include/opmonlib/details/Utils.hxx | ❌ Needs formatting |
| plugins/fileOpMonFacility.cpp | ❌ Needs formatting |
| plugins/fileOpMonFacility.hpp | ❌ Needs formatting |
| plugins/stdoutOpMonFacility.cpp | ❌ Needs formatting |
| src/BackendOpMonFacility.cpp | ❌ Needs formatting |
| src/MonitorableObject.cpp | ❌ Needs formatting |
| src/NullOpMonFacility.hpp | ❌ Needs formatting |
| src/OpMonFacility.cpp | ❌ Needs formatting |
| src/OpMonManager.cpp | ❌ Needs formatting |
| src/Utils.cpp | ❌ Needs formatting |
| unittest/monitorable_object_test.cxx | ❌ Needs formatting |
| unittest/opmon_facility_test.cxx | ❌ Needs formatting |
| unittest/schema_conversion_test.cxx | ❌ Needs formatting |
include/opmonlib/BackendOpMonFacility.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 30: Namespace should be terminated with '// namespace dunedaq::opmonlib '
include/opmonlib/Issues.hpp
Errors
- Line 13: Found other header after system header. Should be: Issues.hh, other non-system headers, system headers.
include/opmonlib/JSonOpMonFacility.hpp
Errors
- Line 21: Add #include
for string
include/opmonlib/MonitorableObject.hpp
Errors
- Line 16: Found other header after system header. Should be: MonitorableObject.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: MonitorableObject.hh, other non-system headers, system headers.
- Line 47: Namespace should be terminated with '// namespace dunedaq '
- Line 86: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
- Line 161: Constructors callable with one argument should be marked explicit.
include/opmonlib/OpMonFacility.hpp
Errors
- Line 16: Found other header after system header. Should be: OpMonFacility.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: OpMonFacility.hh, other non-system headers, system headers.
- Line 53: Namespace should be terminated with '// namespace dunedaq '
include/opmonlib/OpMonManager.hpp
Errors
- Line 56: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 15: Found other header after system header. Should be: OpMonManager.hh, other non-system headers, system headers.
- Line 16: Found other header after system header. Should be: OpMonManager.hh, other non-system headers, system headers.
- Line 18: Found other header after system header. Should be: OpMonManager.hh, other non-system headers, system headers.
- Line 19: Found other header after system header. Should be: OpMonManager.hh, other non-system headers, system headers.
- Line 43: Namespace should be terminated with '// namespace dunedaq '
- Line 93: Add #include
for string
include/opmonlib/TestOpMonManager.hpp
Errors
- Line 24: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 13: Found other header after system header. Should be: TestOpMonManager.hh, other non-system headers, system headers.
- Line 15: Found other header after system header. Should be: TestOpMonManager.hh, other non-system headers, system headers.
- Line 19: Namespace should be terminated with '// namespace dunedaq '
- Line 33: Add #include
for string - Line 34: Add #include
for make_shared<>
include/opmonlib/Utils.hpp
Errors
- Line 18: Found other header after system header. Should be: Utils.hh, other non-system headers, system headers.
- Line 19: Found other header after system header. Should be: Utils.hh, other non-system headers, system headers.
- Line 20: Found other header after system header. Should be: Utils.hh, other non-system headers, system headers.
- Line 49: Namespace should be terminated with '// namespace dunedaq '
plugins/fileOpMonFacility.cpp
Errors
- Line 14: Found other header after system header. Should be: fileOpMonFacility.hh, other non-system headers, system headers.
- Line 83: Add #include
for string - Line 78: Add #include
for move
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
- Line 84: ignoring return value of function declared with 'nodiscard' attribute
plugins/fileOpMonFacility.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: OPMONLIB_PLUGINS_FILEOPMONFACILITY_HPP_
- Line 72: #endif line should be "#endif // OPMONLIB_PLUGINS_FILEOPMONFACILITY_HPP_"
- Line 41: An unsigned integer appears to be used here.
- Line 64: An unsigned integer appears to be used here.
- Line 53: Add #include
for string
plugins/stdoutOpMonFacility.cpp
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
- Line 28: ignoring return value of function declared with 'nodiscard' attribute
src/BackendOpMonFacility.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
src/MonitorableObject.cpp
Errors
- Line 12: Found other header after system header. Should be: MonitorableObject.hh, other non-system headers, system headers.
- Line 44: If an else has a brace on one side, it should have it on both
- Line 124: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
- Line 30: Add #include
for shared_ptr<> - Line 86: Add #include
for move
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 135: redundant return statement at the end of a function with a void return type
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
- Line 30: initialization of 's_default_facility' with static storage duration may throw an exception that cannot be caught
src/NullOpMonFacility.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 13: Namespace should be terminated with '// namespace dunedaq '
src/OpMonFacility.cpp
Errors
- Line 28: Add #include
for string - Line 33: Add #include
for shared_ptr<>
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
src/OpMonManager.cpp
Errors
- Line 12: Found other header after system header. Should be: OpMonManager.hh, other non-system headers, system headers.
- Line 17: Add #include
for string
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 135: redundant return statement at the end of a function with a void return type
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
src/Utils.cpp
Errors
- Line 67: An unsigned integer appears to be used here.
- Line 70: An unsigned integer appears to be used here.
- Line 142: An unsigned integer appears to be used here.
- Line 145: An unsigned integer appears to be used here.
- Line 235: An unsigned integer appears to be used here.
- Line 237: An unsigned integer appears to be used here.
- Line 243: An unsigned integer appears to be used here.
- Line 245: An unsigned integer appears to be used here.
- Line 277: Add #include
for string
unittest/monitorable_object_test.cxx
Errors
- Line 57: Using deprecated casting style. Use static_cast
(...) instead - Line 156: Add #include
for make_shared<> - Line 66: Add #include
for move
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 135: redundant return statement at the end of a function with a void return type
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
unittest/opmon_facility_test.cxx
Errors
- Line 58: Add #include
for make_shared<> - Line 90: Add #include
for move - Line 95: Add #include
for vector<>
Warnings
- Line 60: a trailing return type is disallowed for this function declaration
- Line 37: function-like macro 'DEFINE_DUNE_OPMON_FACILITY' used; consider a 'constexpr' template function
unittest/schema_conversion_test.cxx
Errors
- Line 106: Add #include
for string
Warnings
- Line 104: unused variable 'float_value'
- Line 107: unused variable 'bool_value'