oksconflibs

Unit Tests

No unit tests written.

Clang Formatting

File	Status
include/oksconflibs/OksConfigObject.hpp	❌ Needs formatting
include/oksconflibs/OksConfiguration.hpp	❌ Needs formatting
src/OksConfigObject.cpp	❌ Needs formatting
src/OksConfiguration.cpp	❌ Needs formatting
test/apps/test_create_oksdb.cxx	❌ Needs formatting
test/apps/test_oksdb.cxx	❌ Needs formatting

include/oksconflibs/OksConfigObject.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 9: #ifndef header guard has wrong style, please use: OKSCONFLIBS_INCLUDE_OKSCONFLIBS_OKSCONFIGOBJECT_HPP_
• Line 166: #endif line should be "#endif // OKSCONFLIBS_INCLUDE_OKSCONFLIBS_OKSCONFIGOBJECT_HPP_"
• Line 15: Found other header after system header. Should be: OksConfigObject.hh, other non-system headers, system headers.
• Line 16: Found other header after system header. Should be: OksConfigObject.hh, other non-system headers, system headers.
• Line 18: Found other header after system header. Should be: OksConfigObject.hh, other non-system headers, system headers.
• Line 37: Access specifier "public" has already appeared in class OksConfigObject
• Line 42: An unsigned integer appears to be used here.
• Line 44: An unsigned integer appears to be used here.
• Line 46: An unsigned integer appears to be used here.
• Line 48: An unsigned integer appears to be used here.
• Line 56: An unsigned integer appears to be used here.
• Line 58: An unsigned integer appears to be used here.
• Line 60: An unsigned integer appears to be used here.
• Line 62: An unsigned integer appears to be used here.
• Line 70: Use int16/int64/etc, rather than the C type long
• Line 74: An unsigned integer appears to be used here.
• Line 76: An unsigned integer appears to be used here.
• Line 78: An unsigned integer appears to be used here.
• Line 80: An unsigned integer appears to be used here.
• Line 93: An unsigned integer appears to be used here.
• Line 95: An unsigned integer appears to be used here.
• Line 97: An unsigned integer appears to be used here.
• Line 99: An unsigned integer appears to be used here.
• Line 119: Access specifier "public" has already appeared in class OksConfigObject
• Line 149: Access specifier "public" has already appeared in class OksConfigObject
• Line 158: Access specifier "private" has already appeared in class OksConfigObject
• Line 114: Add #include for move

include/oksconflibs/OksConfiguration.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 9: #ifndef header guard has wrong style, please use: OKSCONFLIBS_INCLUDE_OKSCONFLIBS_OKSCONFIGURATION_HPP_
• Line 155: #endif line should be "#endif // OKSCONFLIBS_INCLUDE_OKSCONFLIBS_OKSCONFIGURATION_HPP_"
• Line 21: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 30: Namespace should be terminated with '// namespace oks '
• Line 52: Access specifier "public" has already appeared in class OksConfiguration
• Line 54: Use int16/int64/etc, rather than the C type long
• Line 55: Use int16/int64/etc, rather than the C type long
• Line 56: Use int16/int64/etc, rather than the C type long
• Line 57: Use int16/int64/etc, rather than the C type long
• Line 98: Access specifier "public" has already appeared in class OksConfiguration
• Line 103: Access specifier "protected" has already appeared in class OksConfiguration
• Line 126: Add #include
• Line 79: Add #include for vector<>

src/OksConfigObject.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 71: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 109: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 139: An unsigned integer appears to be used here.
• Line 151: An unsigned integer appears to be used here.
• Line 163: An unsigned integer appears to be used here.
• Line 175: An unsigned integer appears to be used here.
• Line 295: An unsigned integer appears to be used here.
• Line 307: An unsigned integer appears to be used here.
• Line 319: An unsigned integer appears to be used here.
• Line 331: An unsigned integer appears to be used here.
• Line 493: Use int16/int64/etc, rather than the C type long
• Line 524: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 606: An unsigned integer appears to be used here.
• Line 616: An unsigned integer appears to be used here.
• Line 626: An unsigned integer appears to be used here.
• Line 636: An unsigned integer appears to be used here.
• Line 767: An unsigned integer appears to be used here.
• Line 779: An unsigned integer appears to be used here.
• Line 791: An unsigned integer appears to be used here.
• Line 803: An unsigned integer appears to be used here.
• Line 957: Using C-style cast. Use one of the C++ cast operators instead
• Line 1013: Add #include for string
• Line 962: Add #include for vector<>
• Line 879: Add #include for list<>
• Line 980: Add #include for move

Warnings

• Line 20: nested namespaces can be concatenated
• Line 37: redundant access specifier has the same accessibility as the previous access specifier
• Line 70: consider replacing 'unsigned long' with 'uint64'
• Line 119: redundant access specifier has the same accessibility as the previous access specifier
• Line 47: use nullptr
• Line 47: use nullptr
• Line 47: use nullptr
• Line 47: use nullptr
• Line 52: redundant access specifier has the same accessibility as the previous access specifier
• Line 54: consider replacing 'unsigned long' with 'uint64'
• Line 55: consider replacing 'unsigned long' with 'uint64'
• Line 56: consider replacing 'unsigned long' with 'uint64'
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 67: use nullptr
• Line 71: do not use reinterpret_cast
• Line 85: use nullptr
• Line 109: do not use reinterpret_cast
• Line 201: use nullptr
• Line 241: use nullptr
• Line 280: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 357: use nullptr
• Line 407: use nullptr
• Line 442: use emplace_back instead of push_back
• Line 442: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 466: use emplace_back instead of push_back
• Line 466: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 475: use emplace_back instead of push_back
• Line 475: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 493: consider replacing 'unsigned long' with 'uint64'
• Line 510: use emplace_back instead of push_back
• Line 510: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 521: use emplace_back instead of push_back
• Line 521: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 845: use auto when initializing with new to avoid duplicating the type name
• Line 888: use auto when initializing with new to avoid duplicating the type name
• Line 889: use nullptr
• Line 915: use auto when initializing with new to avoid duplicating the type name
• Line 938: use auto when initializing with new to avoid duplicating the type name
• Line 942: use nullptr
• Line 957: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 957: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
• Line 968: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 1051: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead

src/OksConfiguration.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 16: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 18: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 19: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 20: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 21: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 22: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 23: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 25: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 26: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 27: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 28: Found other header after system header. Should be: OksConfiguration.hh, other non-system headers, system headers.
• Line 35: Namespace should be terminated with '// namespace dunedaq '
• Line 50: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 61: Single-parameter constructors should be marked explicit.
• Line 98: Using C-style cast. Use one of the C++ cast operators instead
• Line 100: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 224: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 238: Else clause should be indented at the same level as if. Ambiguous nested if/else chains require braces.
• Line 253: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 297: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 319: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 438: Single-parameter constructors should be marked explicit.
• Line 443: If an else has a brace on one side, it should have it on both
• Line 533: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 609: Namespace should be terminated with '// namespace oksconflibs '
• Line 609: Namespace should be terminated with '// namespace dunedaq '
• Line 618: Use int16/int64/etc, rather than the C type long
• Line 644: Use int16/int64/etc, rather than the C type long
• Line 677: Use int16/int64/etc, rather than the C type long
• Line 687: If an else has a brace on one side, it should have it on both
• Line 708: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 711: If an else has a brace on one side, it should have it on both
• Line 717: Use int16/int64/etc, rather than the C type long
• Line 731: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 760: If an else has a brace on one side, it should have it on both
• Line 837: Small and focused functions are preferred: OksConfiguration::get() has 84 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
• Line 884: If an else has a brace on one side, it should have it on both
• Line 917: If an else has a brace on one side, it should have it on both
• Line 933: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 939: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 945: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 951: Single-parameter constructors should be marked explicit.
• Line 1054: Single-parameter constructors should be marked explicit.
• Line 1070: Single-parameter constructors should be marked explicit.
• Line 1093: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 1169: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 1173: If an else has a brace on one side, it should have it on both
• Line 1187: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 1197: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 1201: If an else has a brace on one side, it should have it on both
• Line 1265: Increment/decrement operator should appear alone on its line unless in a while/for loop head
• Line 1289: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 1290: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 1291: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 1310: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 1343: Using C-style cast. Use one of the C++ cast operators instead
• Line 1377: Small and focused functions are preferred: OksConfiguration::check_db() has 110 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
• Line 1422: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
• Line 1433: "cout" should not be used for output in DUNE DAQ software.
• Line 1385: Add #include for string
• Line 1221: Add #include for list<>
• Line 1385: Add #include for set<>
• Line 1322: Add #include for vector<>

Warnings

• Line 20: nested namespaces can be concatenated
• Line 37: redundant access specifier has the same accessibility as the previous access specifier
• Line 70: consider replacing 'unsigned long' with 'uint64'
• Line 119: redundant access specifier has the same accessibility as the previous access specifier
• Line 47: use nullptr
• Line 47: use nullptr
• Line 47: use nullptr
• Line 47: use nullptr
• Line 52: redundant access specifier has the same accessibility as the previous access specifier
• Line 54: consider replacing 'unsigned long' with 'uint64'
• Line 55: consider replacing 'unsigned long' with 'uint64'
• Line 56: consider replacing 'unsigned long' with 'uint64'
• Line 57: consider replacing 'unsigned long' with 'uint64'
• Line 67: use nullptr
• Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
• Line 11: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead
• Line 168: multiple declarations in a single statement reduces readability
• Line 246: use nullptr
• Line 246: use nullptr
• Line 247: use nullptr
• Line 247: use nullptr
• Line 248: use nullptr
• Line 248: use nullptr
• Line 254: use nullptr
• Line 287: use auto when declaring iterators
• Line 432: nested namespaces can be concatenated
• Line 470: declaration uses identifier '__rg__', which is a reserved identifier
• Line 476: the const qualified variable 'file_name' is copy-constructed from a const reference; consider making it a const reference
• Line 507: multiple declarations in a single statement reduces readability
• Line 579: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
• Line 618: consider replacing 'unsigned long' with 'uint64'
• Line 632: use auto when declaring iterators
• Line 644: consider replacing 'unsigned long' with 'uint64'
• Line 677: consider replacing 'unsigned long' with 'uint64'
• Line 682: use nullptr
• Line 705: use auto when declaring iterators
• Line 706: use emplace_back instead of push_back
• Line 717: consider replacing 'unsigned long' with 'uint64'
• Line 723: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 728: use auto when declaring iterators
• Line 729: use emplace_back instead of push_back
• Line 747: use nullptr
• Line 751: use auto when initializing with new to avoid duplicating the type name
• Line 756: do not use const_cast to remove const qualifier
• Line 763: do not use const_cast to remove const qualifier
• Line 771: do not use const_cast to remove const qualifier
• Line 781: do not use const_cast to remove const qualifier
• Line 781: use emplace_back instead of push_back
• Line 823: do not use const_cast to remove const qualifier
• Line 823: use emplace_back instead of push_back
• Line 850: use auto when declaring iterators
• Line 858: use auto when declaring iterators
• Line 927: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 933: do not use reinterpret_cast
• Line 939: do not use reinterpret_cast
• Line 945: do not use reinterpret_cast
• Line 961: use auto when declaring iterators
• Line 998: use auto when declaring iterators
• Line 1003: use auto when declaring iterators
• Line 1023: use auto when declaring iterators
• Line 1025: use auto when declaring iterators
• Line 1057: use nullptr
• Line 1057: use nullptr
• Line 1086: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead
• Line 1093: do not use reinterpret_cast
• Line 1104: use auto when declaring iterators
• Line 1105: use auto when declaring iterators
• Line 1147: use nullptr
• Line 1187: do not use reinterpret_cast
• Line 1207: use auto when declaring iterators
• Line 1208: use auto when declaring iterators
• Line 1255: multiple declarations in a single statement reduces readability
• Line 1289: do not use reinterpret_cast
• Line 1290: do not use reinterpret_cast
• Line 1291: do not use reinterpret_cast
• Line 1305: use nullptr
• Line 1313: use nullptr
• Line 1318: use nullptr
• Line 1318: use nullptr
• Line 1319: use nullptr
• Line 1319: use nullptr
• Line 1320: use nullptr
• Line 1320: use nullptr
• Line 1329: use auto when declaring iterators
• Line 1403: use nullptr
• Line 1423: use nullptr
• Line 1424: use nullptr

test/apps/test_create_oksdb.cxx

Errors

• Line 0: The standard copyright message wasn't found.
• Line 11: Found other header after system header. Should be: test_create_oksdb.hh, other non-system headers, system headers.
• Line 12: Found other header after system header. Should be: test_create_oksdb.hh, other non-system headers, system headers.
• Line 22: "cerr" should not be used for output in DUNE DAQ software.
• Line 45: "cout" should not be used for output in DUNE DAQ software.
• Line 48: "cout" should not be used for output in DUNE DAQ software.
• Line 55: "cout" should not be used for output in DUNE DAQ software.
• Line 61: If an else has a brace on one side, it should have it on both
• Line 63: "cout" should not be used for output in DUNE DAQ software.
• Line 70: "cout" should not be used for output in DUNE DAQ software.
• Line 73: "cerr" should not be used for output in DUNE DAQ software.
• Line 53: Add #include for string
• Line 53: Add #include for list<>

Warnings

• Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
• Line 31: do not use pointer arithmetic
• Line 55: do not use pointer arithmetic
• Line 56: use emplace_back instead of push_back
• Line 56: do not use pointer arithmetic
• Line 63: do not use pointer arithmetic
• Line 64: do not use pointer arithmetic

test/apps/test_oksdb.cxx

Errors

• Line 0: The standard copyright message wasn't found.
• Line 11: Found other header after system header. Should be: test_oksdb.hh, other non-system headers, system headers.
• Line 12: Found other header after system header. Should be: test_oksdb.hh, other non-system headers, system headers.
• Line 13: Found other header after system header. Should be: test_oksdb.hh, other non-system headers, system headers.
• Line 29: "cout" should not be used for output in DUNE DAQ software.
• Line 33: "cout" should not be used for output in DUNE DAQ software.
• Line 35: "cout" should not be used for output in DUNE DAQ software.
• Line 40: "cout" should not be used for output in DUNE DAQ software.
• Line 42: "cout" should not be used for output in DUNE DAQ software.
• Line 47: "cout" should not be used for output in DUNE DAQ software.
• Line 51: "cout" should not be used for output in DUNE DAQ software.
• Line 57: "cout" should not be used for output in DUNE DAQ software.
• Line 61: "cout" should not be used for output in DUNE DAQ software.
• Line 65: "cout" should not be used for output in DUNE DAQ software.
• Line 84: "cout" should not be used for output in DUNE DAQ software.
• Line 87: "cerr" should not be used for output in DUNE DAQ software.
• Line 93: An unsigned integer appears to be used here.
• Line 95: An unsigned integer appears to be used here.
• Line 97: An unsigned integer appears to be used here.
• Line 99: An unsigned integer appears to be used here.
• Line 117: "cerr" should not be used for output in DUNE DAQ software.
• Line 124: Use int16/int64/etc, rather than the C type short
• Line 127: "cout" should not be used for output in DUNE DAQ software.
• Line 129: "cout" should not be used for output in DUNE DAQ software.
• Line 132: "cerr" should not be used for output in DUNE DAQ software.
• Line 139: "cout" should not be used for output in DUNE DAQ software.
• Line 141: "cout" should not be used for output in DUNE DAQ software.
• Line 144: "cerr" should not be used for output in DUNE DAQ software.
• Line 157: "cerr" should not be used for output in DUNE DAQ software.
• Line 170: "cerr" should not be used for output in DUNE DAQ software.
• Line 182: "cerr" should not be used for output in DUNE DAQ software.
• Line 195: "cerr" should not be used for output in DUNE DAQ software.
• Line 207: "cerr" should not be used for output in DUNE DAQ software.
• Line 214: "cout" should not be used for output in DUNE DAQ software.
• Line 217: "cerr" should not be used for output in DUNE DAQ software.
• Line 223: "cout" should not be used for output in DUNE DAQ software.
• Line 225: "cout" should not be used for output in DUNE DAQ software.
• Line 227: "cout" should not be used for output in DUNE DAQ software.
• Line 230: "cerr" should not be used for output in DUNE DAQ software.
• Line 258: "cout" should not be used for output in DUNE DAQ software.
• Line 262: "cerr" should not be used for output in DUNE DAQ software.
• Line 267: "cerr" should not be used for output in DUNE DAQ software.
• Line 239: Add #include for string
• Line 224: Add #include for vector<>

Warnings

• Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
• Line 124: consider replacing 'unsigned short' with 'uint16'
• Line 189: use auto when declaring iterators
• Line 224: use auto when declaring iterators
• Line 242: do not use pointer arithmetic