kafkaopmon
Unit Tests
| Test | Status |
|---|---|
| OpMonPublisher_test | ✅ Passed |
| stream_OpMonFacility_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| apps/kafka_opmon_consumer.cxx | ✅ Already formatted |
| include/kafkaopmon/OpMonPublisher.hpp | ❌ Needs formatting |
| plugins/streamOpMonFacility.cpp | ❌ Needs formatting |
| plugins/streamOpMonFacility.hpp | ❌ Needs formatting |
| src/OpMonPublisher.cpp | ❌ Needs formatting |
| test/apps/opmon_publish_to_kafka_test.cxx | ❌ Needs formatting |
| test/apps/opmon_publisher_test.cxx | ❌ Needs formatting |
| unittest/OpMonPublisher_test.cxx | ❌ Needs formatting |
| unittest/stream_OpMonFacility_test.cxx | ❌ Needs formatting |
apps/kafka_opmon_consumer.cxx
Errors
- Line 108: "cout" should not be used for output in DUNE DAQ software.
Warnings
- Line 25: modification of 'std' namespace can result in undefined behavior
- Line 36: modification of 'std' namespace can result in undefined behavior
- Line 38: modification of 'std' namespace can result in undefined behavior
- Line 39: modification of 'std' namespace can result in undefined behavior
- Line 40: modification of 'std' namespace can result in undefined behavior
- Line 41: modification of 'std' namespace can result in undefined behavior
- Line 44: modification of 'std' namespace can result in undefined behavior
- Line 48: C-style casts are discouraged; use static_cast (if needed, the cast may be redundant)
- Line 91: modification of 'std' namespace can result in undefined behavior
- Line 105: modification of 'std' namespace can result in undefined behavior
- Line 140: modification of 'std' namespace can result in undefined behavior
- Line 140: do not declare C-style arrays, use std::array<> instead
- Line 194: random number generator seeded with a disallowed source of seed value will generate a predictable sequence of values
- Line 194: C-style casts are discouraged; use static_cast
- Line 194: use nullptr
include/kafkaopmon/OpMonPublisher.hpp
Errors
- Line 22: Found other header after system header. Should be: OpMonPublisher.hh, other non-system headers, system headers.
- Line 23: Found other header after system header. Should be: OpMonPublisher.hh, other non-system headers, system headers.
- Line 54: Using C-style cast. Use static_cast
(...) instead - Line 58: Namespace should be terminated with '// namespace dunedaq '
- Line 68: Single-parameter constructors should be marked explicit.
plugins/streamOpMonFacility.cpp
Errors
- Line 30: Add #include
for string
plugins/streamOpMonFacility.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: KAFKAOPMON_PLUGINS_STREAMOPMONFACILITY_HPP_
- Line 36: #endif line should be "#endif // KAFKAOPMON_PLUGINS_STREAMOPMONFACILITY_HPP_"
- Line 29: Add #include
for move
src/OpMonPublisher.cpp
Errors
- Line 92: Add #include
for string
Warnings
- Line 84: do not use const_cast to remove const qualifier
test/apps/opmon_publish_to_kafka_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: Found other header after system header. Should be: opmon_publish_to_kafka_test.hh, other non-system headers, system headers.
- Line 13: Found other header after system header. Should be: opmon_publish_to_kafka_test.hh, other non-system headers, system headers.
- Line 46: "cout" should not be used for output in DUNE DAQ software.
- Line 53: Add #include
for string - Line 66: Add #include
for shared_ptr<> - Line 76: Add #include
for vector<> - Line 72: Add #include
for move
test/apps/opmon_publisher_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 10: Found other header after system header. Should be: opmon_publisher_test.hh, other non-system headers, system headers.
- Line 11: Found other header after system header. Should be: opmon_publisher_test.hh, other non-system headers, system headers.
- Line 41: "cout" should not be used for output in DUNE DAQ software.
- Line 49: Add #include
for string - Line 65: Add #include
for move - Line 70: Add #include
for vector<>