hsilibs

Unit Tests

Test	Status
HSITypeAdapters_test	✅ Passed

Clang Formatting

File	Status
include/hsilibs/HSIEventSender.hpp	❌ Needs formatting
include/hsilibs/Issues.hpp	❌ Needs formatting
include/hsilibs/Types.hpp	❌ Needs formatting
plugins/FakeHSIEventGeneratorModule.cpp	✅ Already formatted
plugins/FakeHSIEventGeneratorModule.hpp	✅ Already formatted
plugins/HSIController.cpp	❌ Needs formatting
plugins/HSIController.hpp	❌ Needs formatting
plugins/HSIDataHandlerModule.cpp	❌ Needs formatting
plugins/HSIDataHandlerModule.hpp	❌ Needs formatting
plugins/HSIReadout.cpp	❌ Needs formatting
plugins/HSIReadout.hpp	❌ Needs formatting
src/HSIEventSender.cpp	❌ Needs formatting
src/HSIFrameProcessor.cpp	❌ Needs formatting
src/HSIFrameProcessor.hpp	❌ Needs formatting
unittest/HSITypeAdapters_test.cxx	❌ Needs formatting

include/hsilibs/HSIEventSender.hpp

Errors

• Line 77: #endif line should be "#endif // HSILIBS_INCLUDE_HSILIBS_HSIEVENTSENDER_HPP_"
• Line 68: An unsigned integer appears to be used here.

include/hsilibs/Issues.hpp

Errors

• Line 111: Add #include for queue<>

include/hsilibs/Types.hpp

Errors

• Line 1: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
• Line 58: C-style comment syntax detected; please use either C++ style "//" or Doxygen style

plugins/FakeHSIEventGeneratorModule.cpp

Errors

• Line 137: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
• Line 234: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 275: An unsigned integer appears to be used here.
• Line 62: Add #include for shared_ptr<>

Warnings

• Line 26: nested namespaces can be concatenated
• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI
• Line 29: nested namespaces can be concatenated
• Line 41: random number generator seeded with a default argument will generate a predictable sequence of values
• Line 103: narrowing conversion from 'double' to 'float'
• Line 110: narrowing conversion from 'double' to '__int_type' (aka 'unsigned long')
• Line 122: narrowing conversion from 'uint64_t' (aka 'unsigned long') to 'double'
• Line 136: prefer a lambda to std::bind
• Line 137: do not use reinterpret_cast
• Line 188: narrowing conversion from 'double' to '__int_type' (aka 'unsigned long')
• Line 235: redundant get() call on smart pointer
• Line 260: redundant get() call on smart pointer
• Line 29: nested namespaces can be concatenated

plugins/FakeHSIEventGeneratorModule.hpp

Errors

• Line 7: #ifndef header guard has wrong style, please use: HSILIBS_PLUGINS_FAKEHSIEVENTGENERATORMODULE_HPP_
• Line 102: #endif line should be "#endif // HSILIBS_PLUGINS_FAKEHSIEVENTGENERATORMODULE_HPP_"

plugins/HSIController.cpp

Errors

• Line 23: Do not include .cc files from other packages
• Line 135: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 162: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 173: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 184: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 194: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 224: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 235: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 245: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 255: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 78: Add #include for make_unique<>
• Line 276: Add #include for move

Warnings

• Line 23: suspicious #include of file with '.cc' extension
• Line 34: nested namespaces can be concatenated
• Line 70: qualified name 'TimingController::do_configure' refers to a member overridden in subclass; did you mean 'dunedaq::timinglibs::TimingEndpointControllerBase'?
• Line 30: nested namespaces can be concatenated
• Line 86: 'generate_opmon_data' overrides a member function but is not marked 'override'

plugins/HSIDataHandlerModule.cpp

Warnings

• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI
• Line 31: nested namespaces can be concatenated
• Line 22: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated

plugins/HSIDataHandlerModule.hpp

Errors

• Line 9: #ifndef header guard has wrong style, please use: HSILIBS_PLUGINS_HSIDATAHANDLERMODULE_HPP_
• Line 63: #endif line should be "#endif // HSILIBS_PLUGINS_HSIDATAHANDLERMODULE_HPP_"

plugins/HSIReadout.cpp

Errors

• Line 15: Do not include .cc files from other packages
• Line 133: Use of Run Time Type Information not allowed unless this code is meant to test other code
• Line 149: An unsigned integer appears to be used here.
• Line 176: An unsigned integer appears to be used here.
• Line 216: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 216: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 231: An unsigned integer appears to be used here.
• Line 271: Small and focused functions are preferred: HSIReadout::do_hsi_work() has 111 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
• Line 316: Add #include for move

Warnings

• Line 26: nested namespaces can be concatenated
• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI
• Line 15: suspicious #include of file with '.cc' extension
• Line 152: variable 'n_words_in_buffer' is not initialized
• Line 287: variable 'total_counts' is not initialized
• Line 288: variable 'number_of_counts' is not initialized
• Line 314: narrowing conversion from 'double' to '::uint64_t' (aka 'unsigned long')
• Line 35: nested namespaces can be concatenated
• Line 87: 'generate_opmon_data' overrides a member function but is not marked 'override'

src/HSIEventSender.cpp

Errors

• Line 91: An unsigned integer appears to be used here.
• Line 104: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 104: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 104: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 38: Add #include for shared_ptr<>
• Line 108: Add #include for move

Warnings

• Line 26: nested namespaces can be concatenated
• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI
• Line 23: nested namespaces can be concatenated
• Line 75: std::move of the variable 'event_copy' of the trivially-copyable type 'dfmessages::HSIEvent' has no effect
• Line 108: std::move of the variable 'payload' of the trivially-copyable type 'HSI_FRAME_STRUCT' has no effect

src/HSIFrameProcessor.cpp

Warnings

• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI
• Line 19: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated

src/HSIFrameProcessor.hpp

Errors

• Line 8: #ifndef header guard has wrong style, please use: HSILIBS_SRC_HSIFRAMEPROCESSOR_HPP_
• Line 65: #endif line should be "#endif // HSILIBS_SRC_HSIFRAMEPROCESSOR_HPP_"

unittest/HSITypeAdapters_test.cxx

Warnings

• Line 79: struct 'HSI_FRAME_STRUCT' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI