hermesmodules
Unit Tests
No unit tests written.
Clang Formatting
| File | Status |
|---|---|
| include/hermesmodules/HermesCoreController.hpp | ❌ Needs formatting |
| plugins/HermesModule.cpp | ❌ Needs formatting |
| plugins/HermesModule.hpp | ❌ Needs formatting |
| pybindsrc/hermescorecontroller.cpp | ❌ Needs formatting |
| pybindsrc/module.cpp | ✅ Already formatted |
| soc/src/DevMem.hpp | ❌ Needs formatting |
| soc/src/UDPSocket.hpp | ❌ Needs formatting |
| soc/src/hermes_udp_srv.cxx | ❌ Needs formatting |
| src/HermesCoreController.cpp | ❌ Needs formatting |
| unittest/Placeholder_test.cxx | ✅ Already formatted |
include/hermesmodules/HermesCoreController.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 110: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 2: #ifndef header guard has wrong style, please use: HERMESMODULES_INCLUDE_HERMESMODULES_HERMESCORECONTROLLER_HPP_
- Line 110: #endif line should be "#endif // HERMESMODULES_INCLUDE_HERMESMODULES_HERMESCORECONTROLLER_HPP_"
- Line 15: Using C-style cast. Use static_cast
(...) instead - Line 21: Using C-style cast. Use static_cast
(...) instead - Line 28: Using C-style cast. Use static_cast
(...) instead - Line 34: An unsigned integer appears to be used here.
- Line 41: Using C-style cast. Use static_cast
(...) instead - Line 41: An unsigned integer appears to be used here.
- Line 51: An unsigned integer appears to be used here.
- Line 52: An unsigned integer appears to be used here.
- Line 53: An unsigned integer appears to be used here.
- Line 54: An unsigned integer appears to be used here.
- Line 55: An unsigned integer appears to be used here.
- Line 56: An unsigned integer appears to be used here.
- Line 57: An unsigned integer appears to be used here.
- Line 58: An unsigned integer appears to be used here.
- Line 62: An unsigned integer appears to be used here.
- Line 63: An unsigned integer appears to be used here.
- Line 64: An unsigned integer appears to be used here.
- Line 72: An unsigned integer appears to be used here.
- Line 74: An unsigned integer appears to be used here.
- Line 76: An unsigned integer appears to be used here.
- Line 80: An unsigned integer appears to be used here.
- Line 82: An unsigned integer appears to be used here.
- Line 84: An unsigned integer appears to be used here.
- Line 86: An unsigned integer appears to be used here.
- Line 88: An unsigned integer appears to be used here.
- Line 90: An unsigned integer appears to be used here.
- Line 92: An unsigned integer appears to be used here.
- Line 107: Namespace should be terminated with '// namespace hermesmodules '
- Line 108: Namespace should be terminated with '// namespace dunedaq '
- Line 67: Add #include
for string
plugins/HermesModule.cpp
Errors
- Line 27: Found other header after system header. Should be: HermesModule.hh, other non-system headers, system headers.
- Line 34: An unsigned integer appears to be used here.
- Line 36: An unsigned integer appears to be used here.
- Line 49: An unsigned integer appears to be used here.
- Line 87: An unsigned integer appears to be used here.
- Line 121: "cout" should not be used for output in DUNE DAQ software.
- Line 130: An unsigned integer appears to be used here.
- Line 158: An unsigned integer appears to be used here.
- Line 167: An unsigned integer appears to be used here.
- Line 114: Add #include
for make_unique<> - Line 81: Add #include
for move - Line 130: Add #include
for set<>
Warnings
- Line 87: loop variable has narrower type 'uint16_t' than iteration's upper bound 'const uint32_t'
- Line 158: loop variable has narrower type 'uint16_t' than iteration's upper bound 'const uint32_t'
- Line 63: no definition found for 'HermesCoreController', but a definition with the same name 'HermesCoreController' found in another namespace 'dunedaq::hermesmodules'
plugins/HermesModule.hpp
Errors
- Line 11: #ifndef header guard has wrong style, please use: HERMESMODULES_PLUGINS_HERMESMODULE_HPP_
- Line 108: #endif line should be "#endif // HERMESMODULES_PLUGINS_HERMESMODULE_HPP_"
- Line 28: An unsigned integer appears to be used here.
- Line 34: An unsigned integer appears to be used here.
- Line 40: An unsigned integer appears to be used here.
- Line 52: An unsigned integer appears to be used here.
- Line 59: An unsigned integer appears to be used here.
- Line 64: Namespace should be terminated with '// namespace appmodel '
- Line 67: Namespace should be terminated with '// namespace confmodel '
- Line 98: An unsigned integer appears to be used here.
- Line 95: Add #include
for unique_ptr<> - Line 98: Add #include
for vector<>
pybindsrc/hermescorecontroller.cpp
Errors
- Line 15: Found other header after system header. Should be: hermescorecontroller.hh, other non-system headers, system headers.
soc/src/DevMem.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: HERMESMODULES_SOC_SRC_DEVMEM_HPP_
- Line 105: #endif line should be "#endif // HERMESMODULES_SOC_SRC_DEVMEM_HPP_"
- Line 41: An unsigned integer appears to be used here.
- Line 42: An unsigned integer appears to be used here.
- Line 46: An unsigned integer appears to be used here.
- Line 50: An unsigned integer appears to be used here.
- Line 55: An unsigned integer appears to be used here.
- Line 63: An unsigned integer appears to be used here.
- Line 82: Use of NULL #define found; prefer using the nullptr keyword
- Line 87: Using C-style cast. Use one of the C++ cast operators instead
- Line 87: An unsigned integer appears to be used here.
- Line 100: An unsigned integer appears to be used here.
- Line 104: Namespace should be terminated with '// namespace devmem '
- Line 63: Add #include
for vector<>
soc/src/UDPSocket.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 7: #ifndef header guard has wrong style, please use: HERMESMODULES_SOC_SRC_UDPSOCKET_HPP_
- Line 9: #endif line should be "#endif // HERMESMODULES_SOC_SRC_UDPSOCKET_HPP_"
- Line 8: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
- Line 28: Namespace should be terminated with '// namespace udp '
- Line 36: An unsigned integer appears to be used here.
- Line 56: An unsigned integer appears to be used here.
- Line 66: Access specifier "public" has already appeared in class UDPSocket
- Line 78: Using C-style cast. Use static_cast
(...) instead - Line 83: Using C-style cast. Use static_cast
(...) instead - Line 101: Using C-style cast. Use static_cast
(...) instead - Line 116: Using C-style cast. Use one of the C++ cast operators instead
- Line 121: Using C-style cast. Use one of the C++ cast operators instead
- Line 126: Using C-style cast. Use static_cast
(...) instead - Line 129: An unsigned integer appears to be used here.
- Line 137: An unsigned integer appears to be used here.
- Line 144: Using C-style cast. Use static_cast
(...) instead - Line 151: Using C-style cast. Use one of the C++ cast operators instead
- Line 156: Using C-style cast. Use static_cast
(...) instead - Line 159: An unsigned integer appears to be used here.
- Line 169: An unsigned integer appears to be used here.
- Line 176: Using C-style cast. Use one of the C++ cast operators instead
- Line 184: An unsigned integer appears to be used here.
- Line 189: Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size.
- Line 190: Using C-style cast. Use one of the C++ cast operators instead
- Line 207: Using C-style cast. Use static_cast
(...) instead - Line 212: An unsigned integer appears to be used here.
- Line 219: An unsigned integer appears to be used here.
- Line 220: An unsigned integer appears to be used here.
- Line 224: An unsigned integer appears to be used here.
- Line 226: Using C-style cast. Use one of the C++ cast operators instead
- Line 226: An unsigned integer appears to be used here.
- Line 234: An unsigned integer appears to be used here.
- Line 243: Single-parameter constructors should be marked explicit.
- Line 245: Using C-style cast. Use one of the C++ cast operators instead
- Line 245: An unsigned integer appears to be used here.
- Line 254: Using C-style cast. Use one of the C++ cast operators instead
- Line 254: An unsigned integer appears to be used here.
- Line 261: An unsigned integer appears to be used here.
- Line 262: An unsigned integer appears to be used here.
- Line 263: An unsigned integer appears to be used here.
- Line 265: An unsigned integer appears to be used here.
- Line 266: An unsigned integer appears to be used here.
- Line 281: An unsigned integer appears to be used here.
- Line 283: Using C-style cast. Use one of the C++ cast operators instead
- Line 283: An unsigned integer appears to be used here.
- Line 298: Using C-style cast. Use one of the C++ cast operators instead
- Line 298: An unsigned integer appears to be used here.
- Line 299: An unsigned integer appears to be used here.
- Line 303: Namespace should be terminated with '// namespace std '
soc/src/hermes_udp_srv.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 4: Include the directory when naming .hh files
- Line 13: An unsigned integer appears to be used here.
- Line 15: An unsigned integer appears to be used here.
- Line 16: An unsigned integer appears to be used here.
- Line 21: An unsigned integer appears to be used here.
- Line 22: "cout" should not be used for output in DUNE DAQ software.
- Line 24: "cout" should not be used for output in DUNE DAQ software.
- Line 25: "cout" should not be used for output in DUNE DAQ software.
- Line 26: "cout" should not be used for output in DUNE DAQ software.
- Line 27: "cout" should not be used for output in DUNE DAQ software.
- Line 29: "cout" should not be used for output in DUNE DAQ software.
- Line 34: An unsigned integer appears to be used here.
- Line 35: "cout" should not be used for output in DUNE DAQ software.
- Line 37: An unsigned integer appears to be used here.
- Line 38: "cout" should not be used for output in DUNE DAQ software.
- Line 41: "cout" should not be used for output in DUNE DAQ software.
- Line 57: "cout" should not be used for output in DUNE DAQ software.
- Line 73: "cout" should not be used for output in DUNE DAQ software.
- Line 74: "cout" should not be used for output in DUNE DAQ software.
- Line 75: "cout" should not be used for output in DUNE DAQ software.
- Line 78: An unsigned integer appears to be used here.
- Line 85: "cout" should not be used for output in DUNE DAQ software.
- Line 89: "cerr" should not be used for output in DUNE DAQ software.
- Line 93: An unsigned integer appears to be used here.
- Line 95: Using C-style cast. Use one of the C++ cast operators instead
- Line 95: "cout" should not be used for output in DUNE DAQ software.
- Line 97: "cout" should not be used for output in DUNE DAQ software.
- Line 99: "cout" should not be used for output in DUNE DAQ software.
- Line 103: "cout" should not be used for output in DUNE DAQ software.
- Line 107: "cout" should not be used for output in DUNE DAQ software.
- Line 122: "cerr" should not be used for output in DUNE DAQ software.
- Line 126: An unsigned integer appears to be used here.
- Line 127: An unsigned integer appears to be used here.
- Line 130: "cout" should not be used for output in DUNE DAQ software.
- Line 131: An unsigned integer appears to be used here.
- Line 141: An unsigned integer appears to be used here.
- Line 142: An unsigned integer appears to be used here.
- Line 143: An unsigned integer appears to be used here.
- Line 144: An unsigned integer appears to be used here.
- Line 148: An unsigned integer appears to be used here.
- Line 151: An unsigned integer appears to be used here.
- Line 152: An unsigned integer appears to be used here.
- Line 153: An unsigned integer appears to be used here.
- Line 156: An unsigned integer appears to be used here.
- Line 159: An unsigned integer appears to be used here.
- Line 172: An unsigned integer appears to be used here.
- Line 173: Use operator || instead of or
- Line 182: "cerr" should not be used for output in DUNE DAQ software.
- Line 189: An unsigned integer appears to be used here.
- Line 192: An unsigned integer appears to be used here.
- Line 194: An unsigned integer appears to be used here.
- Line 200: An unsigned integer appears to be used here.
- Line 231: Small and focused functions are preferred: main() has 112 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 126: Add #include
for vector<> - Line 200: Add #include
for string
Warnings
- Line 2: declaration uses identifier '__DEVMEM_HPP__', which is a reserved identifier
- Line 42: do not use pointer arithmetic
- Line 47: do not use pointer arithmetic
- Line 57: do not use pointer arithmetic
- Line 57: do not use pointer arithmetic
- Line 69: do not use pointer arithmetic
- Line 69: do not use pointer arithmetic
- Line 82: use auto when initializing with a cast to avoid duplicating the type name
- Line 82: do not use C-style cast to convert between unrelated types
- Line 83: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int'
- Line 87: do not use C-style cast to convert between unrelated types
- Line 78: redundant cast to the same type
- Line 83: C-style casts are discouraged; use static_cast
- Line 101: C-style casts are discouraged; use static_cast
- Line 111: do not use C-style cast to convert between unrelated types
- Line 116: do not use C-style cast to convert between unrelated types
- Line 121: do not use C-style cast to convert between unrelated types
- Line 126: C-style casts are discouraged; use static_cast
- Line 144: C-style casts are discouraged; use static_cast
- Line 151: do not use C-style cast to convert between unrelated types
- Line 156: C-style casts are discouraged; use static_cast
- Line 176: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 176: do not use C-style cast to convert between unrelated types
- Line 189: do not declare C-style arrays, use std::array<> instead
- Line 190: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 190: do not use C-style cast to convert between unrelated types
- Line 196: do not use pointer arithmetic
- Line 202: do not use C-style cast to convert between unrelated types
- Line 207: C-style casts are discouraged; use static_cast
- Line 226: do not use C-style cast to convert between unrelated types
- Line 245: do not use C-style cast to convert between unrelated types
- Line 254: do not use C-style cast to convert between unrelated types
- Line 266: do not use array subscript when the index is not an integer constant expression
- Line 283: do not use C-style cast to convert between unrelated types
- Line 298: do not use C-style cast to convert between unrelated types
- Line 90: variable 'i' is not initialized
- Line 302: do not declare C-style arrays, use std::array<> instead
- Line 325: variable 'arg_len' is not initialized
- Line 327: do not use pointer arithmetic
- Line 551: function 'operator<<' defined in a header file; function definitions in header files can lead to ODR violations
- Line 48: do not use pointer arithmetic
- Line 66: use auto when initializing with a template cast to avoid duplicating the type name
- Line 95: do not use C-style cast to convert between unrelated types
- Line 95: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 110: variable 'req_count' set but not used
- Line 111: variable 'rpl_count' set but not used
- Line 112: variable 'to_count' set but not used
- Line 141: Value stored to 'num_buf' during its initialization is never read
- Line 141: unused variable 'num_buf'
- Line 159: variable 'wait_counts' set but not used
src/HermesCoreController.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 31: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
- Line 31: Missing email address in TODO comment; it should appear on the same line as the TODO
- Line 71: An unsigned integer appears to be used here.
- Line 83: An unsigned integer appears to be used here.
- Line 95: An unsigned integer appears to be used here.
- Line 146: An unsigned integer appears to be used here.
- Line 168: An unsigned integer appears to be used here.
- Line 217: An unsigned integer appears to be used here.
- Line 233: An unsigned integer appears to be used here.
- Line 273: An unsigned integer appears to be used here.
- Line 306: An unsigned integer appears to be used here.
- Line 321: An unsigned integer appears to be used here.
- Line 367: Namespace should be terminated with '// namespace hermesmodules '
- Line 368: Namespace should be terminated with '// namespace dunedaq '
- Line 11: Add #include
for string
Warnings
- Line 7: nested namespaces can be concatenated