fdreadoutmodules

Unit Tests

No unit tests written.

Clang Formatting

File	Status
plugins/DataRecorderModule.cpp	❌ Needs formatting
plugins/DataRecorderModule.hpp	❌ Needs formatting
plugins/DummyConsumer.cpp	❌ Needs formatting
plugins/DummyConsumer.hpp	❌ Needs formatting
plugins/DummyModule.cpp	❌ Needs formatting
plugins/DummyModule.hpp	❌ Needs formatting
plugins/ErroredFrameConsumer.cpp	❌ Needs formatting
plugins/FDDataHandlerModule.cpp	❌ Needs formatting
plugins/FDDataHandlerModule.hpp	❌ Needs formatting
plugins/FDFakeReaderModule.cpp	❌ Needs formatting
plugins/FDFakeReaderModule.hpp	❌ Needs formatting
plugins/FragmentConsumer.cpp	❌ Needs formatting
plugins/TimeSyncConsumer.cpp	❌ Needs formatting
unittest/Placeholder_test.cxx	✅ Already formatted

plugins/DataRecorderModule.cpp

Warnings

• Line 26: modification of 'std' namespace can result in undefined behavior
• Line 28: nested namespaces can be concatenated
• Line 28: modification of 'std' namespace can result in undefined behavior
• Line 25: nested namespaces can be concatenated
• Line 25: modification of 'std' namespace can result in undefined behavior

plugins/DataRecorderModule.hpp

Errors

• Line 9: #ifndef header guard has wrong style, please use: FDREADOUTMODULES_PLUGINS_DATARECORDERMODULE_HPP_
• Line 53: #endif line should be "#endif // FDREADOUTMODULES_PLUGINS_DATARECORDERMODULE_HPP_"
• Line 50: Namespace should be terminated with '// namespace fdreadoutmodules '

plugins/DummyConsumer.cpp

Errors

• Line 53: Add #include for move

Warnings

• Line 20: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated

plugins/DummyModule.cpp

Errors

• Line 36: Add #include for move

Warnings

• Line 32: expression result unused

plugins/ErroredFrameConsumer.cpp

Warnings

• Line 20: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated
• Line 9: suspicious #include of file with '.cpp' extension
• Line 20: nested namespaces can be concatenated

plugins/FDDataHandlerModule.cpp

Errors

• Line 219: Small and focused functions are preferred: FDDataHandlerModule::create_readout() has 108 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)

Warnings

• Line 17: nested namespaces can be concatenated

plugins/FDDataHandlerModule.hpp

Errors

• Line 8: #ifndef header guard has wrong style, please use: FDREADOUTMODULES_PLUGINS_FDDATAHANDLERMODULE_HPP_
• Line 48: #endif line should be "#endif // FDREADOUTMODULES_PLUGINS_FDDATAHANDLERMODULE_HPP_"
• Line 39: Add #include for shared_ptr<>

plugins/FDFakeReaderModule.cpp

Errors

• Line 253: Small and focused functions are preferred: FDFakeReaderModule::create_source_emulator() has 150 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)

Warnings

• Line 120: the variable 'datatype' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
• Line 22: nested namespaces can be concatenated

plugins/FDFakeReaderModule.hpp

Errors

• Line 8: #ifndef header guard has wrong style, please use: FDREADOUTMODULES_PLUGINS_FDFAKEREADERMODULE_HPP_
• Line 52: #endif line should be "#endif // FDREADOUTMODULES_PLUGINS_FDFAKEREADERMODULE_HPP_"
• Line 44: Add #include for shared_ptr<>

plugins/FragmentConsumer.cpp

Warnings

• Line 20: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated
• Line 15: suspicious #include of file with '.cpp' extension
• Line 26: nested namespaces can be concatenated
• Line 53: variable 'num_frames' is not initialized
• Line 78: narrowing conversion from 'unsigned long' to signed type 'int' is implementation-defined
• Line 82: do not use pointer arithmetic

plugins/TimeSyncConsumer.cpp

Warnings

• Line 20: nested namespaces can be concatenated
• Line 24: nested namespaces can be concatenated
• Line 10: suspicious #include of file with '.cpp' extension