erskafka
Unit Tests
No unit tests written.
Errors in Documentation Links
docs/README.md
- [404] https://github.com/DUNE-DAQ/daqconf/blob/develop/python/daqconf/core/conf_utils.py#L581-L586 Rejected status code: 404 Not Found
Clang Formatting
| File | Status |
|---|---|
| include/erskafka/ERSPublisher.hpp | ❌ Needs formatting |
| src/ERSPublisher.cpp | ❌ Needs formatting |
| src/KafkaStream.cpp | ❌ Needs formatting |
| src/KafkaStream.hpp | ❌ Needs formatting |
| src/ProtoBufStream.cpp | ❌ Needs formatting |
| src/ProtoBufStream.hpp | ❌ Needs formatting |
| test/apps/ers_publisher_test.cxx | ❌ Needs formatting |
| test/apps/protobuf_stream_test.cxx | ❌ Needs formatting |
include/erskafka/ERSPublisher.hpp
Errors
- Line 21: Found other header after system header. Should be: ERSPublisher.hh, other non-system headers, system headers.
- Line 32: Single-parameter constructors should be marked explicit.
- Line 61: Namespace should be terminated with '// namespace erskafka '
- Line 62: Namespace should be terminated with '// namespace dunedaq '
src/ERSPublisher.cpp
Errors
- Line 25: "cerr" should not be used for output in DUNE DAQ software.
- Line 62: Add #include
for string
Warnings
- Line 23: nested namespaces can be concatenated
- Line 74: do not use const_cast to remove const qualifier
src/KafkaStream.cpp
Errors
- Line 37: "cout" should not be used for output in DUNE DAQ software.
- Line 44: "cout" should not be used for output in DUNE DAQ software.
- Line 50: "cout" should not be used for output in DUNE DAQ software.
- Line 94: "cout" should not be used for output in DUNE DAQ software.
- Line 104: "cout" should not be used for output in DUNE DAQ software.
- Line 108: "cout" should not be used for output in DUNE DAQ software.
- Line 131: Consider using rand_r(...) instead of rand(...) for improved thread safety.
- Line 146: "cout" should not be used for output in DUNE DAQ software.
Warnings
- Line 31: local copy 'brokers' of the variable 'param' is never modified; consider avoiding the copy
- Line 69: loop variable is copied but only used as const reference; consider making it a const reference
- Line 103: do not use const_cast to remove const qualifier
- Line 131: rand() has limited randomness; use C++11 random library instead
src/KafkaStream.hpp
Errors
- Line 10: #ifndef header guard has wrong style, please use: ERSKAFKA_SRC_KAFKASTREAM_HPP_
- Line 43: #endif line should be "#endif // ERSKAFKA_SRC_KAFKASTREAM_HPP_"
src/ProtoBufStream.cpp
Errors
- Line 56: "cerr" should not be used for output in DUNE DAQ software.
- Line 31: Add #include
for make_unique<> - Line 51: Add #include
for move
Warnings
- Line 23: nested namespaces can be concatenated
src/ProtoBufStream.hpp
Errors
- Line 10: #ifndef header guard has wrong style, please use: ERSKAFKA_SRC_PROTOBUFSTREAM_HPP_
- Line 43: #endif line should be "#endif // ERSKAFKA_SRC_PROTOBUFSTREAM_HPP_"
- Line 14: Found other header after system header. Should be: ProtoBufStream.hh, other non-system headers, system headers.
test/apps/ers_publisher_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 2: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 19: Using C-style cast. Use static_cast
(...) instead
Warnings
- Line 23: nested namespaces can be concatenated
- Line 22: unused parameter 'argc'
- Line 22: unused parameter 'argv'
test/apps/protobuf_stream_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 2: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 19: Using C-style cast. Use static_cast
(...) instead - Line 25: Add #include
for string - Line 43: Add #include
for move
Warnings
- Line 23: unused parameter 'argc'
- Line 23: unused parameter 'argv'
- Line 43: passing result of std::move() as a const reference argument; no move will actually happen