dfmodules
Unit Tests
| Test | Status |
|---|---|
| DFOModule_test | ✅ Passed |
| DataStoreFactory_test | ✅ Passed |
| HDF5Write_test | ✅ Passed |
| HDF5FileUtils_test | ✅ Passed |
| TriggerRecordBuilderData_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| include/dfmodules/DataStore.hpp | ❌ Needs formatting |
| plugins/DFOModule.cpp | ❌ Needs formatting |
| plugins/DFOModule.hpp | ❌ Needs formatting |
| plugins/DataWriterModule.cpp | ✅ Already formatted |
| plugins/DataWriterModule.hpp | ✅ Already formatted |
| plugins/FakeDataProdModule.cpp | ✅ Already formatted |
| plugins/FakeDataProdModule.hpp | ✅ Already formatted |
| plugins/FragmentAggregatorModule.cpp | ❌ Needs formatting |
| plugins/FragmentAggregatorModule.hpp | ❌ Needs formatting |
| plugins/HDF5DataStore.cpp | ✅ Already formatted |
| plugins/HDF5DataStore.hpp | ❌ Needs formatting |
| plugins/HDF5FileUtils.hpp | ❌ Needs formatting |
| plugins/TPStreamWriterModule.cpp | ✅ Already formatted |
| plugins/TPStreamWriterModule.hpp | ✅ Already formatted |
| plugins/TRBModule.cpp | ❌ Needs formatting |
| plugins/TRBModule.hpp | ❌ Needs formatting |
| plugins/TRMonRequestorModule.cpp | ✅ Already formatted |
| plugins/TRMonRequestorModule.hpp | ❌ Needs formatting |
| src/TPBundleHandler.cpp | ❌ Needs formatting |
| src/TriggerInhibitAgent.cpp | ❌ Needs formatting |
| src/TriggerRecordBuilderData.cpp | ❌ Needs formatting |
| src/dfmodules/CommonIssues.hpp | ✅ Already formatted |
| src/dfmodules/TPBundleHandler.hpp | ❌ Needs formatting |
| src/dfmodules/TriggerInhibitAgent.hpp | ❌ Needs formatting |
| src/dfmodules/TriggerRecordBuilderData.hpp | ❌ Needs formatting |
| unittest/DFOModule_test.cxx | ✅ Already formatted |
| unittest/DataStoreFactory_test.cxx | ❌ Needs formatting |
| unittest/HDF5FileUtils_test.cxx | ✅ Already formatted |
| unittest/HDF5Write_test.cxx | ❌ Needs formatting |
| unittest/TriggerRecordBuilderData_test.cxx | ❌ Needs formatting |
plugins/DFOModule.cpp
Errors
- Line 231: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Warnings
- Line 148: loop variable is copied but only used as const reference; consider making it a const reference
- Line 477: std::move of the variable 'message' of the trivially-copyable type 'dfmessages::TriggerInhibit' has no effect
- Line 511: 'decision_copy' used after it was moved
- Line 153: C-style casts are discouraged; use static_cast
plugins/DFOModule.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_DFOMODULE_HPP_
- Line 181: #endif line should be "#endif // DFMODULES_PLUGINS_DFOMODULE_HPP_"
- Line 51: An unsigned integer appears to be used here.
- Line 143: An unsigned integer appears to be used here.
- Line 144: An unsigned integer appears to be used here.
- Line 148: Add #include
for set<>
plugins/DataWriterModule.cpp
Warnings
- Line 47: function-like macro 'DEFINE_DUNE_DATA_STORE' used; consider a 'constexpr' template function
- Line 47: nested namespaces can be concatenated
- Line 175: redundant get() call on smart pointer
- Line 200: 'token' used after it was moved
- Line 218: redundant get() call on smart pointer
- Line 391: 'token' used after it was moved
- Line 107: narrowing conversion from 'rep' (aka 'long') to 'double'
plugins/DataWriterModule.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_DATAWRITERMODULE_HPP_
- Line 139: #endif line should be "#endif // DFMODULES_PLUGINS_DATAWRITERMODULE_HPP_"
plugins/FakeDataProdModule.cpp
Warnings
- Line 40: nested namespaces can be concatenated
- Line 158: std::move of the variable 'timesyncmsg' of the trivially-copyable type 'dfmessages::TimeSync' has no effect
plugins/FakeDataProdModule.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_FAKEDATAPRODMODULE_HPP_
- Line 102: #endif line should be "#endif // DFMODULES_PLUGINS_FAKEDATAPRODMODULE_HPP_"
plugins/FragmentAggregatorModule.cpp
Errors
- Line 78: An unsigned integer appears to be used here.
- Line 86: An unsigned integer appears to be used here.
- Line 122: An unsigned integer appears to be used here.
- Line 125: An unsigned integer appears to be used here.
- Line 268: An unsigned integer appears to be used here.
- Line 244: Add #include
for unique_ptr<> - Line 125: Add #include
for numeric_limits<> - Line 245: Add #include
for move - Line 167: Add #include
for tuple<>
Warnings
- Line 26: nested namespaces can be concatenated
- Line 59: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'key_type' (aka 'int') is implementation-defined
- Line 135: loop variable is copied but only used as const reference; consider making it a const reference
- Line 175: narrowing conversion from 'ID_t' (aka 'unsigned int') to signed type 'key_type' (aka 'int') is implementation-defined
plugins/FragmentAggregatorModule.hpp
Errors
- Line 10: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_FRAGMENTAGGREGATORMODULE_HPP_
- Line 113: #endif line should be "#endif // DFMODULES_PLUGINS_FRAGMENTAGGREGATORMODULE_HPP_"
- Line 37: An unsigned integer appears to be used here.
- Line 38: An unsigned integer appears to be used here.
- Line 84: An unsigned integer appears to be used here.
- Line 85: An unsigned integer appears to be used here.
- Line 86: An unsigned integer appears to be used here.
- Line 87: An unsigned integer appears to be used here.
- Line 73: Add #include
for unique_ptr<> - Line 79: Add #include
for vector<>
plugins/HDF5DataStore.cpp
Warnings
- Line 47: function-like macro 'DEFINE_DUNE_DATA_STORE' used; consider a 'constexpr' template function
- Line 137: narrowing conversion from 'int32_t' (aka 'int') to 'float'
- Line 171: 'write' overrides a member function but is not marked 'override'
- Line 184: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 196: C-style casts are discouraged; use static_cast
- Line 197: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 239: 'write' overrides a member function but is not marked 'override'
- Line 252: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 263: C-style casts are discouraged; use static_cast
- Line 264: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 313: 'prepare_for_run' overrides a member function but is not marked 'override'
- Line 350: 'finish_with_run' overrides a member function but is not marked 'override'
- Line 352: redundant get() call on smart pointer
- Line 477: redundant get() call on smart pointer
- Line 481: redundant get() call on smart pointer
- Line 502: use nullptr
- Line 543: C-style casts are discouraged; use constructor call syntax
- Line 544: C-style casts are discouraged; use constructor call syntax
- Line 545: C-style casts are discouraged; use constructor call syntax
- Line 30: nested namespaces can be concatenated
- Line 37: function 'get_top_group' defined in a header file; function definitions in header files can lead to ODR violations
- Line 39: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 53: function 'get_subgroup' defined in a header file; function definitions in header files can lead to ODR violations
- Line 55: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 66: the variable 'child_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 88: function 'add_datasets_to_path' defined in a header file; function definitions in header files can lead to ODR violations
- Line 92: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead
- Line 107: function 'get_all_dataset_paths' defined in a header file; function definitions in header files can lead to ODR violations
- Line 132: function 'get_files_matching_pattern' defined in a header file; function definitions in header files can lead to ODR violations
plugins/HDF5DataStore.hpp
Errors
- Line 196: Using C-style cast. Use static_cast
(...) instead - Line 263: Using C-style cast. Use static_cast
(...) instead - Line 419: An unsigned integer appears to be used here.
- Line 420: An unsigned integer appears to be used here.
- Line 340: Add #include
for numeric_limits<>
plugins/TPStreamWriterModule.cpp
Errors
- Line 99: Using C-style cast. Use static_cast
(...) instead - Line 283: Add #include
for max
Warnings
- Line 47: function-like macro 'DEFINE_DUNE_DATA_STORE' used; consider a 'constexpr' template function
- Line 39: nested namespaces can be concatenated
- Line 84: narrowing conversion from 'double' to '::uint64_t' (aka 'unsigned long')
- Line 99: C-style casts are discouraged; use static_cast
- Line 113: redundant get() call on smart pointer
- Line 314: 'tpset' used after it was moved
- Line 321: narrowing conversion from 'double' to 'float'
- Line 321: narrowing conversion from 'rep' (aka 'long') to 'double'
- Line 322: narrowing conversion from 'double' to 'float'
- Line 322: narrowing conversion from 'daqdataformats::timestamp_t' (aka 'unsigned long') to 'double'
- Line 322: narrowing conversion from 'rep' (aka 'long') to 'double'
plugins/TPStreamWriterModule.hpp
Errors
- Line 11: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_TPSTREAMWRITERMODULE_HPP_
- Line 123: #endif line should be "#endif // DFMODULES_PLUGINS_TPSTREAMWRITERMODULE_HPP_"
- Line 119: Using C-style cast. Use static_cast
(...) instead
plugins/TRBModule.cpp
Errors
- Line 667: Add #include
for set<>
Warnings
- Line 195: Attempt to free released memory
- Line 55: nested namespaces can be concatenated
- Line 309: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 482: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'int' is implementation-defined
- Line 505: narrowing conversion from 'daqdataformats::timestamp_t' (aka 'unsigned long') to signed type 'daqdataformats::timestamp_diff_t' (aka 'long') is implementation-defined
- Line 638: 'dr' used after it was moved
- Line 685: use auto when initializing with a template cast to avoid duplicating the type name
- Line 716: 'temp_record' used after it was moved
- Line 95: multiple declarations in a single statement reduces readability
- Line 95: variable 't1' is not initialized
- Line 95: variable 't2' is not initialized
plugins/TRBModule.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DFMODULES_PLUGINS_TRBMODULE_HPP_
- Line 312: #endif line should be "#endif // DFMODULES_PLUGINS_TRBMODULE_HPP_"
- Line 159: Using C-style cast. Use static_cast
(...) instead - Line 277: An unsigned integer appears to be used here.
plugins/TRMonRequestorModule.cpp
Errors
- Line 211: Increment/decrement operator should appear alone on its line unless in a while/for loop head
plugins/TRMonRequestorModule.hpp
Errors
- Line 90: Namespace should be terminated with '// namespace dunedaq::dfmodules '
src/TPBundleHandler.cpp
Errors
- Line 101: An unsigned integer appears to be used here.
- Line 147: If an else has a brace on one side, it should have it on both
Warnings
- Line 22: nested namespaces can be concatenated
- Line 143: narrowing conversion from 'int64_t' (aka 'long') to signed type 'int' is implementation-defined
- Line 212: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
src/TriggerInhibitAgent.cpp
Warnings
- Line 28: nested namespaces can be concatenated
- Line 141: std::move of the variable 'inhibit_message' of the trivially-copyable type 'dfmessages::TriggerInhibit' has no effect
- Line 30: nested namespaces can be concatenated
src/TriggerRecordBuilderData.cpp
Errors
- Line 129: Add #include
- for list<>
Warnings
- Line 27: nested namespaces can be concatenated
- Line 196: narrowing conversion from '__int_type' (aka 'long') to 'double'
- Line 201: narrowing conversion from '__int_type' (aka 'unsigned long') to 'double'
src/dfmodules/TriggerRecordBuilderData.hpp
Errors
- Line 124: An unsigned integer appears to be used here.
unittest/DFOModule_test.cxx
Errors
- Line 120: Add #include
for move
Warnings
- Line 153: C-style casts are discouraged; use static_cast
unittest/DataStoreFactory_test.cxx
Warnings
- Line 47: function-like macro 'DEFINE_DUNE_DATA_STORE' used; consider a 'constexpr' template function
unittest/HDF5FileUtils_test.cxx
Warnings
- Line 30: nested namespaces can be concatenated
- Line 37: function 'get_top_group' defined in a header file; function definitions in header files can lead to ODR violations
- Line 39: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 53: function 'get_subgroup' defined in a header file; function definitions in header files can lead to ODR violations
- Line 55: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 66: the variable 'child_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 88: function 'add_datasets_to_path' defined in a header file; function definitions in header files can lead to ODR violations
- Line 92: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead
- Line 107: function 'get_all_dataset_paths' defined in a header file; function definitions in header files can lead to ODR violations
- Line 132: function 'get_files_matching_pattern' defined in a header file; function definitions in header files can lead to ODR violations
unittest/HDF5Write_test.cxx
Errors
- Line 112: An unsigned integer appears to be used here.
- Line 128: Single-parameter constructors should be marked explicit.
Warnings
- Line 47: function-like macro 'DEFINE_DUNE_DATA_STORE' used; consider a 'constexpr' template function
- Line 137: narrowing conversion from 'int32_t' (aka 'int') to 'float'
- Line 171: 'write' overrides a member function but is not marked 'override'
- Line 184: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 196: C-style casts are discouraged; use static_cast
- Line 197: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 239: 'write' overrides a member function but is not marked 'override'
- Line 252: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 263: C-style casts are discouraged; use static_cast
- Line 264: narrowing conversion from 'float' to 'size_t' (aka 'unsigned long')
- Line 313: 'prepare_for_run' overrides a member function but is not marked 'override'
- Line 350: 'finish_with_run' overrides a member function but is not marked 'override'
- Line 352: redundant get() call on smart pointer
- Line 477: redundant get() call on smart pointer
- Line 481: redundant get() call on smart pointer
- Line 502: use nullptr
- Line 543: C-style casts are discouraged; use constructor call syntax
- Line 544: C-style casts are discouraged; use constructor call syntax
- Line 545: C-style casts are discouraged; use constructor call syntax
- Line 30: nested namespaces can be concatenated
- Line 37: function 'get_top_group' defined in a header file; function definitions in header files can lead to ODR violations
- Line 39: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 53: function 'get_subgroup' defined in a header file; function definitions in header files can lead to ODR violations
- Line 55: the variable 'top_level_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 66: the variable 'child_group_name' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 88: function 'add_datasets_to_path' defined in a header file; function definitions in header files can lead to ODR violations
- Line 92: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead
- Line 107: function 'get_all_dataset_paths' defined in a header file; function definitions in header files can lead to ODR violations
- Line 132: function 'get_files_matching_pattern' defined in a header file; function definitions in header files can lead to ODR violations
unittest/TriggerRecordBuilderData_test.cxx
Errors
- Line 83: Add #include
for make_shared<>