detchannelmaps

Unit Tests

Test	Status
TPCChannelMap_test	✅ Passed

Errors in Documentation Links

docs/README.md

• [ERROR] error: Cannot resolve root-relative link '/test/apps/dummy_map_test.cxx': To resolve root-relative links in local files, provide a root dir

Clang Formatting

File	Status
include/detchannelmaps/PDSChannelMap.hpp	❌ Needs formatting
include/detchannelmaps/TPCChannelMap.hpp	❌ Needs formatting
plugins/FiftyLTPCChannelMap.cpp	❌ Needs formatting
plugins/HDColdboxTPCChannelMap.cpp	❌ Needs formatting
plugins/ICEBERGChannelMap.cpp	❌ Needs formatting
plugins/PD2HDTPCChannelMap.cpp	❌ Needs formatting
plugins/PD2VDBottomTPCChannelMap.cpp	❌ Needs formatting
plugins/PD2VDTPCChannelMap.cpp	❌ Needs formatting
plugins/SimplePDSChannelMap.cpp	❌ Needs formatting
plugins/VDColdboxTPCChannelMap.cpp	❌ Needs formatting
pybindsrc/channelmap.cpp	❌ Needs formatting
pybindsrc/module.cpp	❌ Needs formatting
src/PD2HDChannelMapSP.cpp	❌ Needs formatting
src/PD2HDChannelMapSPPluginBase.hpp	❌ Needs formatting
src/PdspChannelMapService.cpp	✅ Already formatted
src/PdspChannelMapService.hpp	✅ Already formatted
src/TPCChannelMapSP.cpp	❌ Needs formatting
src/VDColdboxChannelMapService.cpp	❌ Needs formatting
src/VDColdboxChannelMapService.hpp	❌ Needs formatting
test/apps/tpcmap_test.cxx	❌ Needs formatting
test/plugins/DummyTPCChannelMap.cpp	❌ Needs formatting
unittest/TPCChannelMap_test.cxx	✅ Already formatted

include/detchannelmaps/PDSChannelMap.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 88: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
• Line 56: An unsigned integer appears to be used here.
• Line 58: An unsigned integer appears to be used here.
• Line 59: An unsigned integer appears to be used here.
• Line 60: An unsigned integer appears to be used here.
• Line 61: An unsigned integer appears to be used here.
• Line 62: An unsigned integer appears to be used here.
• Line 63: An unsigned integer appears to be used here.
• Line 92: Zero-parameter constructors should not be marked explicit.
• Line 110: Add #include for shared_ptr<>
• Line 104: Add #include for string

include/detchannelmaps/TPCChannelMap.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 64: An unsigned integer appears to be used here.
• Line 66: An unsigned integer appears to be used here.
• Line 67: An unsigned integer appears to be used here.
• Line 68: An unsigned integer appears to be used here.
• Line 69: An unsigned integer appears to be used here.
• Line 70: An unsigned integer appears to be used here.
• Line 71: An unsigned integer appears to be used here.
• Line 101: Zero-parameter constructors should not be marked explicit.
• Line 119: Add #include for shared_ptr<>
• Line 113: Add #include for string

plugins/FiftyLTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 12: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 12: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 12: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 13: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 20: Zero-parameter constructors should not be marked explicit.
• Line 23: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 7: nested namespaces can be concatenated

plugins/HDColdboxTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 12: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 12: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 12: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 13: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 15: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
• Line 20: Zero-parameter constructors should not be marked explicit.
• Line 23: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 7: nested namespaces can be concatenated

plugins/ICEBERGChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 13: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 13: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 13: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 14: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 16: Access specifier "public" has already appeared in class ICEBERGChannelMap
• Line 21: Zero-parameter constructors should not be marked explicit.
• Line 24: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 16: redundant access specifier has the same accessibility as the previous access specifier
• Line 7: nested namespaces can be concatenated

plugins/PD2HDTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 13: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 13: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 13: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 14: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 20: Zero-parameter constructors should not be marked explicit.
• Line 23: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 7: nested namespaces can be concatenated

plugins/PD2VDBottomTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 12: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 12: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 12: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 13: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 14: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
• Line 20: Zero-parameter constructors should not be marked explicit.
• Line 23: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 7: nested namespaces can be concatenated

plugins/PD2VDTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 14: Zero-parameter constructors should not be marked explicit.
• Line 93: Add #include for string
• Line 118: Add #include for unique_ptr<>

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 83: unused parameter 'offlineChannel'

plugins/SimplePDSChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 14: Zero-parameter constructors should not be marked explicit.
• Line 46: Add #include for string

Warnings

• Line 60: a trailing return type is disallowed for this function declaration
• Line 22: function-like macro 'DEFINE_DUNE_DET_PDSCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated

plugins/VDColdboxTPCChannelMap.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 13: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
• Line 13: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
• Line 13: Missing email address in TODO comment; it should appear on the same line as the TODO
• Line 14: Storage-class specifier (static, extern, typedef, etc) should be at the beginning of the declaration.
• Line 20: Zero-parameter constructors should not be marked explicit.
• Line 23: Add #include for string

Warnings

• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 7: nested namespaces can be concatenated
• Line 23: unused parameter 'apa_name'
• Line 7: nested namespaces can be concatenated

pybindsrc/channelmap.cpp

Errors

• Line 58: Add #include for shared_ptr<>

Warnings

• Line 60: a trailing return type is disallowed for this function declaration
• Line 22: function-like macro 'DEFINE_DUNE_DET_PDSCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 19: nested namespaces can be concatenated

pybindsrc/module.cpp

Warnings

• Line 14: nested namespaces can be concatenated

src/PD2HDChannelMapSP.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 25: Add #include for string

src/PD2HDChannelMapSPPluginBase.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 0: No #ifndef header guard found, suggested CPP variable is: DETCHANNELMAPS_SRC_PD2HDCHANNELMAPSPPLUGINBASE_HPP_
• Line 14: Access specifier "protected:" appears after "private:", not before
• Line 16: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
• Line 148: An unsigned integer appears to be used here.
• Line 149: An unsigned integer appears to be used here.
• Line 150: An unsigned integer appears to be used here.
• Line 13: Add #include for unique_ptr<>
• Line 128: Add #include for string

src/PdspChannelMapService.cpp

Warnings

• Line 27: nested namespaces can be concatenated
• Line 55: multiple declarations in a single statement reduces readability
• Line 55: variable 'crateNo' is not initialized
• Line 55: variable 'slotNo' is not initialized
• Line 55: variable 'fiberNo' is not initialized
• Line 55: variable 'FEMBChannel' is not initialized
• Line 55: variable 'StreamChannel' is not initialized
• Line 55: variable 'slotID' is not initialized
• Line 55: variable 'fiberID' is not initialized
• Line 55: variable 'chipNo' is not initialized
• Line 55: variable 'chipChannel' is not initialized
• Line 55: variable 'asicNo' is not initialized
• Line 56: variable 'asicChannel' is not initialized
• Line 56: variable 'planeType' is not initialized
• Line 56: variable 'offlineChannel' is not initialized
• Line 80: do not use array subscript when the index is not an integer constant expression
• Line 81: do not use array subscript when the index is not an integer constant expression
• Line 82: do not use array subscript when the index is not an integer constant expression
• Line 83: do not use array subscript when the index is not an integer constant expression
• Line 84: do not use array subscript when the index is not an integer constant expression
• Line 85: do not use array subscript when the index is not an integer constant expression
• Line 86: do not use array subscript when the index is not an integer constant expression
• Line 87: do not use array subscript when the index is not an integer constant expression
• Line 88: do not use array subscript when the index is not an integer constant expression
• Line 89: do not use array subscript when the index is not an integer constant expression
• Line 90: do not use array subscript when the index is not an integer constant expression
• Line 91: do not use array subscript when the index is not an integer constant expression
• Line 92: do not use array subscript when the index is not an integer constant expression
• Line 102: multiple declarations in a single statement reduces readability
• Line 102: variable 'crateNo' is not initialized
• Line 102: variable 'slotNo' is not initialized
• Line 102: variable 'fiberNo' is not initialized
• Line 102: variable 'FEMBChannel' is not initialized
• Line 102: variable 'StreamChannel' is not initialized
• Line 102: variable 'slotID' is not initialized
• Line 102: variable 'fiberID' is not initialized
• Line 102: variable 'chipNo' is not initialized
• Line 102: variable 'chipChannel' is not initialized
• Line 102: variable 'asicNo' is not initialized
• Line 103: variable 'asicChannel' is not initialized
• Line 103: variable 'planeType' is not initialized
• Line 103: variable 'offlineChannel' is not initialized
• Line 127: do not use array subscript when the index is not an integer constant expression
• Line 128: do not use array subscript when the index is not an integer constant expression
• Line 129: do not use array subscript when the index is not an integer constant expression
• Line 130: do not use array subscript when the index is not an integer constant expression
• Line 131: do not use array subscript when the index is not an integer constant expression
• Line 132: do not use array subscript when the index is not an integer constant expression
• Line 133: do not use array subscript when the index is not an integer constant expression
• Line 134: do not use array subscript when the index is not an integer constant expression
• Line 135: do not use array subscript when the index is not an integer constant expression
• Line 136: do not use array subscript when the index is not an integer constant expression
• Line 137: do not use array subscript when the index is not an integer constant expression
• Line 138: do not use array subscript when the index is not an integer constant expression
• Line 139: do not use array subscript when the index is not an integer constant expression
• Line 164: do not use array subscript when the index is not an integer constant expression
• Line 164: do not use array subscript when the index is not an integer constant expression
• Line 220: do not use array subscript when the index is not an integer constant expression
• Line 220: do not use array subscript when the index is not an integer constant expression
• Line 222: do not use array subscript when the index is not an integer constant expression
• Line 222: do not use array subscript when the index is not an integer constant expression
• Line 235: do not use array subscript when the index is not an integer constant expression
• Line 243: do not use array subscript when the index is not an integer constant expression
• Line 247: do not use array subscript when the index is not an integer constant expression
• Line 247: do not use array subscript when the index is not an integer constant expression
• Line 256: do not use array subscript when the index is not an integer constant expression
• Line 266: do not use array subscript when the index is not an integer constant expression
• Line 276: do not use array subscript when the index is not an integer constant expression
• Line 287: do not use array subscript when the index is not an integer constant expression
• Line 289: do not use array subscript when the index is not an integer constant expression
• Line 299: do not use array subscript when the index is not an integer constant expression
• Line 311: do not use array subscript when the index is not an integer constant expression
• Line 320: do not use array subscript when the index is not an integer constant expression
• Line 327: do not use array subscript when the index is not an integer constant expression
• Line 334: do not use array subscript when the index is not an integer constant expression
• Line 343: do not use array subscript when the index is not an integer constant expression
• Line 357: do not use array subscript when the index is not an integer constant expression
• Line 364: do not use array subscript when the index is not an integer constant expression
• Line 376: do not use array subscript when the index is not an integer constant expression
• Line 383: do not use array subscript when the index is not an integer constant expression
• Line 411: do not use array subscript when the index is not an integer constant expression
• Line 418: do not use array subscript when the index is not an integer constant expression
• Line 425: do not use array subscript when the index is not an integer constant expression
• Line 432: do not use array subscript when the index is not an integer constant expression
• Line 439: do not use array subscript when the index is not an integer constant expression
• Line 446: do not use array subscript when the index is not an integer constant expression
• Line 453: do not use array subscript when the index is not an integer constant expression
• Line 29: nested namespaces can be concatenated
• Line 38: declaration uses identifier '_FelixOrRCE', which is a reserved identifier
• Line 137: private field 'fNChansPerSSP' is not used
• Line 138: private field 'fNAPAs' is not used
• Line 151: do not declare C-style arrays, use std::array<> instead
• Line 155: do not declare C-style arrays, use std::array<> instead
• Line 156: do not declare C-style arrays, use std::array<> instead
• Line 157: do not declare C-style arrays, use std::array<> instead
• Line 158: do not declare C-style arrays, use std::array<> instead
• Line 159: do not declare C-style arrays, use std::array<> instead
• Line 160: do not declare C-style arrays, use std::array<> instead
• Line 161: do not declare C-style arrays, use std::array<> instead
• Line 162: do not declare C-style arrays, use std::array<> instead
• Line 163: do not declare C-style arrays, use std::array<> instead
• Line 164: do not declare C-style arrays, use std::array<> instead
• Line 165: do not declare C-style arrays, use std::array<> instead
• Line 166: do not declare C-style arrays, use std::array<> instead
• Line 168: do not declare C-style arrays, use std::array<> instead
• Line 169: do not declare C-style arrays, use std::array<> instead
• Line 170: do not declare C-style arrays, use std::array<> instead
• Line 171: do not declare C-style arrays, use std::array<> instead
• Line 172: do not declare C-style arrays, use std::array<> instead
• Line 173: do not declare C-style arrays, use std::array<> instead
• Line 174: do not declare C-style arrays, use std::array<> instead
• Line 175: do not declare C-style arrays, use std::array<> instead
• Line 176: do not declare C-style arrays, use std::array<> instead
• Line 177: do not declare C-style arrays, use std::array<> instead
• Line 178: do not declare C-style arrays, use std::array<> instead
• Line 179: do not declare C-style arrays, use std::array<> instead
• Line 180: do not declare C-style arrays, use std::array<> instead
• Line 182: do not declare C-style arrays, use std::array<> instead
• Line 184: do not declare C-style arrays, use std::array<> instead
• Line 188: do not declare C-style arrays, use std::array<> instead
• Line 189: do not declare C-style arrays, use std::array<> instead
• Line 190: do not declare C-style arrays, use std::array<> instead
• Line 191: do not declare C-style arrays, use std::array<> instead
• Line 192: do not declare C-style arrays, use std::array<> instead
• Line 193: do not declare C-style arrays, use std::array<> instead
• Line 194: do not declare C-style arrays, use std::array<> instead

src/PdspChannelMapService.hpp

Errors

• Line 19: #ifndef header guard has wrong style, please use: DETCHANNELMAPS_SRC_PDSPCHANNELMAPSERVICE_HPP_
• Line 218: #endif line should be "#endif // DETCHANNELMAPS_SRC_PDSPCHANNELMAPSERVICE_HPP_"

src/TPCChannelMapSP.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 56: "cout" should not be used for output in DUNE DAQ software.
• Line 67: "cout" should not be used for output in DUNE DAQ software.
• Line 27: Add #include for string

Warnings

• Line 118: C-style casts are discouraged; use static_cast
• Line 83: unused parameter 'offlineChannel'

src/VDColdboxChannelMapService.cpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 94: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
• Line 115: Namespace should be terminated with '// namespace detchannelmaps '
• Line 25: Add #include for string

Warnings

• Line 15: nested namespaces can be concatenated
• Line 16: nested namespaces can be concatenated

src/VDColdboxChannelMapService.hpp

Errors

• Line 0: The standard copyright message wasn't found.
• Line 71: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
• Line 10: #ifndef header guard has wrong style, please use: DETCHANNELMAPS_SRC_VDCOLDBOXCHANNELMAPSERVICE_HPP_
• Line 71: #endif line should be "#endif // DETCHANNELMAPS_SRC_VDCOLDBOXCHANNELMAPSERVICE_HPP_"
• Line 23: Single-parameter constructors should be marked explicit.

test/apps/tpcmap_test.cxx

Errors

• Line 17: Found other header after system header. Should be: tpcmap_test.hh, other non-system headers, system headers.

Warnings

• Line 60: a trailing return type is disallowed for this function declaration
• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 28: multiple declarations in a single statement reduces readability
• Line 28: variable 'oc' is not initialized
• Line 28: variable 'plane' is not initialized
• Line 28: variable 'elem_id' is not initialized
• Line 51: multiple declarations in a single statement reduces readability
• Line 51: unused variable 'oc'
• Line 51: variable 'oc' is not initialized
• Line 51: unused variable 'plane'
• Line 51: variable 'plane' is not initialized
• Line 51: unused variable 'elem_id'

test/plugins/DummyTPCChannelMap.cpp

Errors

• Line 38: Zero-parameter constructors should not be marked explicit.

Warnings

• Line 60: a trailing return type is disallowed for this function declaration
• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function
• Line 22: nested namespaces can be concatenated

unittest/TPCChannelMap_test.cxx

Warnings

• Line 60: a trailing return type is disallowed for this function declaration
• Line 22: function-like macro 'DEFINE_DUNE_DET_TPCCHANNEL_MAP' used; consider a 'constexpr' template function