datahandlinglibs
Unit Tests
| Test | Status |
|---|---|
| datahandlinglibs_DataMoveCallbackRegistry_testSUCCESS | ✅ Passed |
| datahandlinglibs_SkiplistLatencyBufferModel_testSUCCESS | ✅ Passed |
| datahandlinglibs_DataHandlingModel_testSUCCESS | ✅ Passed |
| datahandlinglibs_IterableQueueModel_testSUCCESS | ✅ Passed |
Errors in Documentation Links
docs/README.md
- [ERROR] https://cernbox.cern.ch/index.php/s/YmXmHC7LpsCjGjT/download Connection failed. Check network connectivity and firewall settings
Clang Formatting
| File | Status |
|---|---|
| include/datahandlinglibs/DataHandlingIssues.hpp | ❌ Needs formatting |
| include/datahandlinglibs/DataMoveCallbackRegistry.hpp | ❌ Needs formatting |
| include/datahandlinglibs/FakeCardReaderBase.hpp | ❌ Needs formatting |
| include/datahandlinglibs/FrameErrorRegistry.hpp | ❌ Needs formatting |
| include/datahandlinglibs/RawDataHandlerBase.hpp | ❌ Needs formatting |
| include/datahandlinglibs/ReadoutLogging.hpp | ✅ Already formatted |
| include/datahandlinglibs/ReadoutTypes.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/DataHandlingConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/LatencyBufferConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/RawDataProcessorConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/RecorderConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/RequestHandlerConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/SourceConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/concepts/SourceEmulatorConcept.hpp | ❌ Needs formatting |
| include/datahandlinglibs/detail/DataMoveCallbackRegistry.hxx | ❌ Needs formatting |
| include/datahandlinglibs/detail/FakeCardReaderBase.hxx | ❌ Needs formatting |
| include/datahandlinglibs/detail/RawDataHandlerBase.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/BinarySearchQueueModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/DataHandlingModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/DataSubscriberModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/DefaultRequestHandlerModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/DefaultSkipListRequestHandler.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/EmptyFragmentRequestHandlerModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/FixedRateQueueModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/IterableQueueModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/RecorderModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/SkipListLatencyBufferModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/SourceEmulatorModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/TaskRawDataProcessorModel.hpp | ❌ Needs formatting |
| include/datahandlinglibs/models/ZeroCopyRecordingRequestHandlerModel.hpp | ✅ Already formatted |
| include/datahandlinglibs/models/detail/BinarySearchQueueModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/DataHandlingModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/DefaultRequestHandlerModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/DefaultSkipListRequestHandler.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/EmptyFragmentRequestHandlerModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/FixedRateQueueModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/IterableQueueModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/RecorderModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/SkipListLatencyBufferModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/SourceEmulatorModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/TaskRawDataProcessorModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/models/detail/ZeroCopyRecordingRequestHandlerModel.hxx | ❌ Needs formatting |
| include/datahandlinglibs/utils/BufferCopy.hpp | ❌ Needs formatting |
| include/datahandlinglibs/utils/BufferedFileReader.hpp | ✅ Already formatted |
| include/datahandlinglibs/utils/BufferedFileWriter.hpp | ❌ Needs formatting |
| include/datahandlinglibs/utils/ErrorBitGenerator.hpp | ❌ Needs formatting |
| include/datahandlinglibs/utils/FileSourceBuffer.hpp | ❌ Needs formatting |
| include/datahandlinglibs/utils/RateLimiter.hpp | ❌ Needs formatting |
| src/DataMoveCallbackRegistry.cpp | ❌ Needs formatting |
| src/Readoutlibs.cpp | ❌ Needs formatting |
| test/apps/test_bufferedfilereader_app.cxx | ❌ Needs formatting |
| test/apps/test_bufferedfilewriter_app.cxx | ❌ Needs formatting |
| test/apps/test_co_timeout_app.cxx | ❌ Needs formatting |
| test/apps/test_composite_key_app.cxx | ❌ Needs formatting |
| test/apps/test_lb_allocation_app.cxx | ❌ Needs formatting |
| test/apps/test_ratelimiter_app.cxx | ✅ Already formatted |
| test/apps/test_skiplist_app.cxx | ✅ Already formatted |
| unittest/datahandlinglibs_BufferedReadWrite_test.cxx | ❌ Needs formatting |
| unittest/datahandlinglibs_DataHandlingModel_test.cxx | ❌ Needs formatting |
| unittest/datahandlinglibs_DataMoveCallbackRegistry_test.cxx | ❌ Needs formatting |
| unittest/datahandlinglibs_IterableQueueModel_test.cxx | ❌ Needs formatting |
| unittest/datahandlinglibs_SkiplistLatencyBufferModel_test.cxx | ❌ Needs formatting |
| unittest/datahandlinglibs_VariableSizeElementQueue_test.cxx | ✅ Already formatted |
include/datahandlinglibs/DataHandlingIssues.hpp
Errors
- Line 8: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_DATAHANDLINGISSUES_HPP_
- Line 208: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_DATAHANDLINGISSUES_HPP_"
- Line 15: Found other header after system header. Should be: DataHandlingIssues.hh, other non-system headers, system headers.
- Line 189: Using C-style cast. Use static_cast
(...) instead
include/datahandlinglibs/RawDataHandlerBase.hpp
Errors
- Line 11: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_RAWDATAHANDLERBASE_HPP_
- Line 86: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_RAWDATAHANDLERBASE_HPP_"
include/datahandlinglibs/ReadoutTypes.hpp
Errors
- Line 54: An unsigned integer appears to be used here.
include/datahandlinglibs/concepts/DataHandlingConcept.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_CONCEPTS_DATAHANDLINGCONCEPT_HPP_
- Line 45: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_CONCEPTS_DATAHANDLINGCONCEPT_HPP_"
include/datahandlinglibs/concepts/RawDataProcessorConcept.hpp
Errors
- Line 51: An unsigned integer appears to be used here.
include/datahandlinglibs/concepts/SourceConcept.hpp
Errors
- Line 11: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_CONCEPTS_SOURCECONCEPT_HPP_
- Line 47: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_CONCEPTS_SOURCECONCEPT_HPP_"
- Line 44: Namespace should be terminated with '// namespace datahandlinglibs '
include/datahandlinglibs/models/BinarySearchQueueModel.hpp
Errors
- Line 33: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
include/datahandlinglibs/models/DataHandlingModel.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_MODELS_DATAHANDLINGMODEL_HPP_
- Line 407: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_MODELS_DATAHANDLINGMODEL_HPP_"
- Line 37: "appmodel/DataHandlerModule.hpp" already included at sourcecode/datahandlinglibs/include/datahandlinglibs/models/DataHandlingModel.hpp:14
- Line 308: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 318: "virtual" is redundant since function is already declared as "override"
include/datahandlinglibs/models/DataSubscriberModel.hpp
Errors
- Line 8: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_MODELS_DATASUBSCRIBERMODEL_HPP_
- Line 101: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_MODELS_DATASUBSCRIBERMODEL_HPP_"
- Line 78: "virtual" is redundant since function is already declared as "override"
- Line 94: An unsigned integer appears to be used here.
- Line 95: An unsigned integer appears to be used here.
- Line 96: An unsigned integer appears to be used here.
- Line 84: Add #include
for move - Line 92: Add #include
for shared_ptr<>
include/datahandlinglibs/models/DefaultRequestHandlerModel.hpp
Errors
- Line 74: An unsigned integer appears to be used here.
- Line 149: "virtual" is redundant since function is already declared as "override"
- Line 219: An unsigned integer appears to be used here.
- Line 220: An unsigned integer appears to be used here.
- Line 228: "virtual" is redundant since function is already declared as "override"
- Line 273: An unsigned integer appears to be used here.
- Line 279: An unsigned integer appears to be used here.
include/datahandlinglibs/models/IterableQueueModel.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 284: "virtual" is redundant since function is already declared as "override"
- Line 301: Add #include
for string
include/datahandlinglibs/models/RecorderModel.hpp
Errors
- Line 51: "virtual" is redundant since function is already declared as "override"
include/datahandlinglibs/models/SkipListLatencyBufferModel.hpp
Errors
- Line 122: "virtual" is redundant since function is already declared as "override"
include/datahandlinglibs/models/SourceEmulatorModel.hpp
Errors
- Line 29: Include the directory when naming .hh files
- Line 51: You don't need a ; after a }
- Line 52: You don't need a ; after a }
- Line 58: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 77: An unsigned integer appears to be used here.
- Line 107: "virtual" is redundant since function is already declared as "override"
- Line 143: An unsigned integer appears to be used here.
- Line 159: An unsigned integer appears to be used here.
- Line 161: An unsigned integer appears to be used here.
include/datahandlinglibs/models/TaskRawDataProcessorModel.hpp
Errors
- Line 84: An unsigned integer appears to be used here.
- Line 102: "virtual" is redundant since function is already declared as "override"
include/datahandlinglibs/testutils/TestUtilities.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 115: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 139: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 281: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 296: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 5: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_TESTUTILS_TESTUTILITIES_HPP_
- Line 320: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_TESTUTILS_TESTUTILITIES_HPP_"
- Line 28: An unsigned integer appears to be used here.
- Line 37: An unsigned integer appears to be used here.
- Line 47: An unsigned integer appears to be used here.
- Line 75: An unsigned integer appears to be used here.
- Line 78: An unsigned integer appears to be used here.
- Line 79: An unsigned integer appears to be used here.
- Line 196: An unsigned integer appears to be used here.
- Line 197: An unsigned integer appears to be used here.
- Line 198: An unsigned integer appears to be used here.
- Line 203: An unsigned integer appears to be used here.
- Line 229: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 229: An unsigned integer appears to be used here.
- Line 234: An unsigned integer appears to be used here.
- Line 236: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 238: Using C-style cast. Use one of the C++ cast operators instead
- Line 238: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 256: Using C-style cast. Use static_cast
(...) instead - Line 256: An unsigned integer appears to be used here.
- Line 258: Using C-style cast. Use static_cast
(...) instead - Line 258: An unsigned integer appears to be used here.
- Line 51: Add #include
for move - Line 59: Add #include
for string
include/datahandlinglibs/testutils/UnitTestUtilities.hpp
Errors
- Line 9: #ifndef header guard has wrong style, please use: DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_TESTUTILS_UNITTESTUTILITIES_HPP_
- Line 61: #endif line should be "#endif // DATAHANDLINGLIBS_INCLUDE_DATAHANDLINGLIBS_TESTUTILS_UNITTESTUTILITIES_HPP_"
- Line 37: An unsigned integer appears to be used here.
- Line 37: Add #include
for unique_ptr<> - Line 41: Add #include
for move
include/datahandlinglibs/utils/BufferCopy.hpp
Errors
- Line 20: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
src/DataMoveCallbackRegistry.cpp
Warnings
- Line 20: nested namespaces can be concatenated
- Line 5: nested namespaces can be concatenated
- Line 40: expression with side effects will be evaluated despite being used as an operand to 'typeid'
src/Readoutlibs.cpp
Errors
- Line 0: The standard copyright message wasn't found.
Warnings
- Line 20: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 11: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 15: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 26: nested namespaces can be concatenated
- Line 23: nested namespaces can be concatenated
- Line 23: nested namespaces can be concatenated
- Line 22: nested namespaces can be concatenated
- Line 5: nested namespaces can be concatenated
- Line 40: expression with side effects will be evaluated despite being used as an operand to 'typeid'
- Line 18: nested namespaces can be concatenated
- Line 60: using declarations in the global namespace in headers are prohibited
- Line 61: using declarations in the global namespace in headers are prohibited
- Line 62: using declarations in the global namespace in headers are prohibited
- Line 63: using declarations in the global namespace in headers are prohibited
- Line 65: nested namespaces can be concatenated
- Line 308: do not use reinterpret_cast
- Line 314: redundant return statement at the end of a function with a void return type
- Line 55: using declarations in the global namespace in headers are prohibited
- Line 56: using declarations in the global namespace in headers are prohibited
- Line 57: using declarations in the global namespace in headers are prohibited
- Line 59: nested namespaces can be concatenated
- Line 152: default arguments on virtual or override methods are prohibited
- Line 197: do not use pointer arithmetic
- Line 18: using declarations in the global namespace in headers are prohibited
- Line 19: using declarations in the global namespace in headers are prohibited
- Line 20: using declarations in the global namespace in headers are prohibited
- Line 22: nested namespaces can be concatenated
- Line 47: default arguments on virtual or override methods are prohibited
- Line 18: nested namespaces can be concatenated
- Line 58: nested namespaces can be concatenated
- Line 91: do not manage memory manually; consider a container or a smart pointer
- Line 194: do not use pointer arithmetic
- Line 197: do not use pointer arithmetic
- Line 225: do not use pointer arithmetic
- Line 226: do not use pointer arithmetic
- Line 313: do not declare C-style arrays, use std::array<> instead
- Line 320: do not declare C-style arrays, use std::array<> instead
- Line 31: nested namespaces can be concatenated
- Line 22: using declarations in the global namespace in headers are prohibited
- Line 24: nested namespaces can be concatenated
- Line 120: default arguments on virtual or override methods are prohibited
- Line 38: using declarations in the global namespace in headers are prohibited
- Line 39: using declarations in the global namespace in headers are prohibited
- Line 41: nested namespaces can be concatenated
- Line 57: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long')
- Line 40: using declarations in the global namespace in headers are prohibited
- Line 42: nested namespaces can be concatenated
- Line 84: unused parameter 'accumilated_timeout_ticks'
- Line 16: nested namespaces can be concatenated
- Line 3: nested namespaces can be concatenated
- Line 11: nested namespaces can be concatenated
- Line 413: std::move of the variable 'timesyncmsg_copy' of the trivially-copyable type 'dfmessages::TimeSync' has no effect
- Line 3: nested namespaces can be concatenated
- Line 20: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 24: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 226: default arguments on virtual or override methods are prohibited
- Line 270: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 272: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 274: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 387: narrowing conversion from 'unsigned int' to signed type '__int_type' (aka 'int') is implementation-defined
- Line 480: C-style casts are discouraged; use static_cast
- Line 491: variable 'elements_handled' set but not used
- Line 3: nested namespaces can be concatenated
- Line 10: default arguments on virtual or override methods are prohibited
- Line 11: unused parameter 'is_retry'
- Line 3: nested namespaces can be concatenated
- Line 27: narrowing conversion from 'uint64_t' (aka 'unsigned long') to signed type 'int64_t' (aka 'long') is implementation-defined
- Line 3: nested namespaces can be concatenated
- Line 18: do not use pointer arithmetic
- Line 32: do not manage memory manually; use RAII
- Line 50: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined
- Line 68: do not manage memory manually; consider a container or a smart pointer
- Line 113: do not declare C-style arrays, use std::array<> instead
- Line 164: do not use pointer arithmetic
- Line 189: do not use pointer arithmetic
- Line 190: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 273: do not use pointer arithmetic
- Line 291: do not use pointer arithmetic
- Line 333: do not manage memory manually; consider a container or a smart pointer
- Line 359: do not use pointer arithmetic
- Line 3: nested namespaces can be concatenated
- Line 5: nested namespaces can be concatenated
- Line 122: default arguments on virtual or override methods are prohibited
- Line 3: using declarations in the global namespace in headers are prohibited
- Line 4: using declarations in the global namespace in headers are prohibited
- Line 6: nested namespaces can be concatenated
- Line 16: rand() has limited randomness; use C++11 random library instead
- Line 43: rand() has limited randomness; use C++11 random library instead
- Line 49: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 50: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 51: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 81: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 178: do not use pointer arithmetic
- Line 3: nested namespaces can be concatenated
- Line 112: variable 'element' is not initialized
- Line 3: nested namespaces can be concatenated
- Line 100: variable 'current_end_pointer' is not initialized
- Line 154: do not use pointer arithmetic
- Line 160: do not use pointer arithmetic
- Line 162: do not use pointer arithmetic
- Line 168: do not use pointer arithmetic
- Line 35: using declarations in the global namespace in headers are prohibited
- Line 37: nested namespaces can be concatenated
- Line 14: nested namespaces can be concatenated
- Line 44: do not use array subscript when the index is not an integer constant expression
- Line 49: do not use array subscript when the index is not an integer constant expression
- Line 54: do not use array subscript when the index is not an integer constant expression
- Line 65: do not use array subscript when the index is not an integer constant expression
- Line 68: do not use array subscript when the index is not an integer constant expression
- Line 68: narrowing conversion from 'double' to 'int'
- Line 69: do not use array subscript when the index is not an integer constant expression
- Line 69: narrowing conversion from 'double' to 'int'
- Line 76: do not declare C-style arrays, use std::array<> instead
- Line 78: do not declare C-style arrays, use std::array<> instead
- Line 80: do not declare C-style arrays, use std::array<> instead
- Line 21: using declarations in the global namespace in headers are prohibited
- Line 23: nested namespaces can be concatenated
- Line 66: narrowing conversion from 'std::streamsize' (aka 'long') to signed type 'int' is implementation-defined
- Line 71: narrowing conversion from 'std::streamsize' (aka 'long') to signed type 'int' is implementation-defined
- Line 16: nested namespaces can be concatenated
- Line 83: narrowing conversion from 'timestamp_t' (aka 'unsigned long') to signed type '__syscall_slong_t' (aka 'long') is implementation-defined
- Line 102: C-style casts are discouraged; use static_cast
- Line 102: C-style casts are discouraged; use static_cast
test/apps/test_bufferedfilereader_app.cxx
Warnings
- Line 11: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 33: using declarations in the global namespace in headers are prohibited
- Line 35: nested namespaces can be concatenated
- Line 28: do not use pointer arithmetic
- Line 39: Value stored to 'statistics_thread' during its initialization is never read
test/apps/test_bufferedfilewriter_app.cxx
Errors
- Line 68: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Warnings
- Line 11: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 35: using declarations in the global namespace in headers are prohibited
- Line 37: nested namespaces can be concatenated
- Line 16: nested namespaces can be concatenated
- Line 83: narrowing conversion from 'timestamp_t' (aka 'unsigned long') to signed type '__syscall_slong_t' (aka 'long') is implementation-defined
- Line 102: C-style casts are discouraged; use static_cast
- Line 102: C-style casts are discouraged; use static_cast
- Line 25: do not use pointer arithmetic
- Line 31: do not use pointer arithmetic
- Line 42: Value stored to 'statistics_thread' during its initialization is never read
- Line 58: do not use pointer arithmetic
- Line 68: do not use reinterpret_cast
test/apps/test_co_timeout_app.cxx
Errors
- Line 28: An unsigned integer appears to be used here.
- Line 44: An unsigned integer appears to be used here.
- Line 45: An unsigned integer appears to be used here.
- Line 56: "cout" should not be used for output in DUNE DAQ software.
- Line 56: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 97: "cout" should not be used for output in DUNE DAQ software.
- Line 100: "cout" should not be used for output in DUNE DAQ software.
- Line 102: "cout" should not be used for output in DUNE DAQ software.
Warnings
- Line 27: converting integer literal to bool, use bool literal instead
test/apps/test_composite_key_app.cxx
Warnings
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 16: nested namespaces can be concatenated
- Line 83: narrowing conversion from 'timestamp_t' (aka 'unsigned long') to signed type '__syscall_slong_t' (aka 'long') is implementation-defined
- Line 102: C-style casts are discouraged; use static_cast
- Line 102: C-style casts are discouraged; use static_cast
- Line 70: std::move of the variable 'payload4' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 72: std::move of the variable 'payload2' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 74: std::move of the variable 'payload3' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 76: std::move of the variable 'payload1' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 78: std::move of the variable 'payload5' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 80: std::move of the variable 'payload6' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 103: 'payload1' used after it was moved
test/apps/test_lb_allocation_app.cxx
Errors
- Line 37: You don't need a ; after a }
- Line 49: Anonymous namespace should be terminated with '// namespace "" '
- Line 92: Using C-style cast. Use one of the C++ cast operators instead
- Line 92: Use of NULL #define found; prefer using the nullptr keyword
- Line 94: Using C-style cast. Use one of the C++ cast operators instead
- Line 95: Using C-style cast. Use one of the C++ cast operators instead
- Line 95: Use of NULL #define found; prefer using the nullptr keyword
- Line 97: Using C-style cast. Use one of the C++ cast operators instead
- Line 179: Small and focused functions are preferred: main() has 94 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Warnings
- Line 11: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 58: nested namespaces can be concatenated
- Line 91: do not manage memory manually; consider a container or a smart pointer
- Line 165: 'pop' overrides a member function but is not marked 'override'
- Line 194: do not use pointer arithmetic
- Line 197: do not use pointer arithmetic
- Line 225: do not use pointer arithmetic
- Line 226: do not use pointer arithmetic
- Line 313: do not declare C-style arrays, use std::array<> instead
- Line 320: do not declare C-style arrays, use std::array<> instead
- Line 22: using declarations in the global namespace in headers are prohibited
- Line 24: nested namespaces can be concatenated
- Line 120: default arguments on virtual or override methods are prohibited
- Line 3: nested namespaces can be concatenated
- Line 18: do not use pointer arithmetic
- Line 32: do not manage memory manually; use RAII
- Line 50: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined
- Line 68: do not manage memory manually; consider a container or a smart pointer
- Line 113: do not declare C-style arrays, use std::array<> instead
- Line 164: do not use pointer arithmetic
- Line 189: do not use pointer arithmetic
- Line 190: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 273: do not use pointer arithmetic
- Line 291: do not use pointer arithmetic
- Line 333: do not manage memory manually; consider a container or a smart pointer
- Line 359: do not use pointer arithmetic
- Line 5: nested namespaces can be concatenated
- Line 122: default arguments on virtual or override methods are prohibited
- Line 38: do not declare C-style arrays, use std::array<> instead
- Line 92: use nullptr
- Line 92: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 95: use nullptr
- Line 95: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
test/apps/test_ratelimiter_app.cxx
Warnings
- Line 16: nested namespaces can be concatenated
- Line 83: narrowing conversion from 'timestamp_t' (aka 'unsigned long') to signed type '__syscall_slong_t' (aka 'long') is implementation-defined
- Line 102: C-style casts are discouraged; use static_cast
- Line 102: C-style casts are discouraged; use static_cast
- Line 53: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 77: variable 'sumops' set but not used
test/apps/test_skiplist_app.cxx
Warnings
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 16: nested namespaces can be concatenated
- Line 83: narrowing conversion from 'timestamp_t' (aka 'unsigned long') to signed type '__syscall_slong_t' (aka 'long') is implementation-defined
- Line 102: C-style casts are discouraged; use static_cast
- Line 102: C-style casts are discouraged; use static_cast
- Line 61: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 61: narrowing conversion from 'result_type' (aka 'double') to 'value_type' (aka 'float')
- Line 87: std::move of the variable 'pl' of the trivially-copyable type 'types::DUMMY_FRAME_STRUCT' has no effect; remove std::move()
- Line 153: do not use const_cast to remove const qualifier
unittest/datahandlinglibs_BufferedReadWrite_test.cxx
Errors
- Line 36: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 130: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 145: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
- Line 156: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Warnings
- Line 11: nested namespaces can be concatenated
- Line 33: using declarations in the global namespace in headers are prohibited
- Line 35: nested namespaces can be concatenated
- Line 35: using declarations in the global namespace in headers are prohibited
- Line 37: nested namespaces can be concatenated
- Line 35: narrowing conversion from 'uint' (aka 'unsigned int') to signed type 'value_type' (aka 'int') is implementation-defined
- Line 36: do not use reinterpret_cast
- Line 42: variable 'read_value' is not initialized
- Line 130: do not use reinterpret_cast
- Line 134: variable 'value' is not initialized
- Line 145: do not use reinterpret_cast
- Line 156: do not use reinterpret_cast
- Line 160: variable 'value' is not initialized
unittest/datahandlinglibs_DataHandlingModel_test.cxx
Warnings
- Line 20: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 11: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 15: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 18: nested namespaces can be concatenated
- Line 23: nested namespaces can be concatenated
- Line 5: nested namespaces can be concatenated
- Line 14: the variable 'id' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 40: expression with side effects will be evaluated despite being used as an operand to 'typeid'
- Line 60: using declarations in the global namespace in headers are prohibited
- Line 61: using declarations in the global namespace in headers are prohibited
- Line 62: using declarations in the global namespace in headers are prohibited
- Line 63: using declarations in the global namespace in headers are prohibited
- Line 65: nested namespaces can be concatenated
- Line 104: 'init' overrides a member function but is not marked 'override'
- Line 107: 'conf' overrides a member function but is not marked 'override'
- Line 110: 'scrap' overrides a member function but is not marked 'override'
- Line 118: 'start' overrides a member function but is not marked 'override'
- Line 121: 'stop' overrides a member function but is not marked 'override'
- Line 151: field 'm_last_post_proc_time' will be initialized after field 'm_consecutive_timeouts'
- Line 217: comparison of integers of different signs: 'rep' (aka 'long') and 'const uint64_t' (aka 'const unsigned long')
- Line 291: 'run_consume' overrides a member function but is not marked 'override'
- Line 294: 'run_timesync' overrides a member function but is not marked 'override'
- Line 308: do not use reinterpret_cast
- Line 314: redundant return statement at the end of a function with a void return type
- Line 55: using declarations in the global namespace in headers are prohibited
- Line 56: using declarations in the global namespace in headers are prohibited
- Line 57: using declarations in the global namespace in headers are prohibited
- Line 59: nested namespaces can be concatenated
- Line 131: 'conf' overrides a member function but is not marked 'override'
- Line 137: 'start' overrides a member function but is not marked 'override'
- Line 140: 'stop' overrides a member function but is not marked 'override'
- Line 152: default arguments on virtual or override methods are prohibited
- Line 197: do not use pointer arithmetic
- Line 213: 'cleanup' overrides a member function but is not marked 'override'
- Line 22: using declarations in the global namespace in headers are prohibited
- Line 24: nested namespaces can be concatenated
- Line 120: default arguments on virtual or override methods are prohibited
- Line 40: using declarations in the global namespace in headers are prohibited
- Line 42: nested namespaces can be concatenated
- Line 84: unused parameter 'accumilated_timeout_ticks'
- Line 11: nested namespaces can be concatenated
- Line 413: std::move of the variable 'timesyncmsg_copy' of the trivially-copyable type 'dfmessages::TimeSync' has no effect
- Line 3: nested namespaces can be concatenated
- Line 20: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 24: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int' is implementation-defined
- Line 101: loop variable is copied but only used as const reference; consider making it a const reference
- Line 226: default arguments on virtual or override methods are prohibited
- Line 270: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 272: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 274: narrowing conversion from 'rep' (aka 'long') to signed type '__int_type' (aka 'int') is implementation-defined
- Line 387: narrowing conversion from 'unsigned int' to signed type '__int_type' (aka 'int') is implementation-defined
- Line 480: C-style casts are discouraged; use static_cast
- Line 491: variable 'elements_handled' set but not used
- Line 5: nested namespaces can be concatenated
- Line 122: default arguments on virtual or override methods are prohibited
- Line 3: nested namespaces can be concatenated
- Line 112: variable 'element' is not initialized
- Line 16: nested namespaces can be concatenated
- Line 35: using declarations in the global namespace in headers are prohibited
- Line 37: nested namespaces can be concatenated
- Line 75: passing 1-byte aligned argument to 8-byte aligned parameter 'this' of 'DataHandlingModel' may result in an unaligned pointer access
- Line 85: std::move of the variable 'frame' of the trivially-copyable type 'ReadoutType' (aka 'dunedaq::datahandlinglibs::types::DUMMY_FRAME_STRUCT') has no effect
- Line 136: passing 1-byte aligned argument to 8-byte aligned parameter 'this' of 'DataHandlingModel' may result in an unaligned pointer access
- Line 146: std::move of the variable 'frame' of the trivially-copyable type 'ReadoutType' (aka 'dunedaq::datahandlinglibs::types::DUMMY_FRAME_STRUCT') has no effect
- Line 152: std::move of the variable 'frame' of the trivially-copyable type 'ReadoutType' (aka 'dunedaq::datahandlinglibs::types::DUMMY_FRAME_STRUCT') has no effect
- Line 179: std::move of the variable 'frame' of the trivially-copyable type 'ReadoutType' (aka 'dunedaq::datahandlinglibs::types::DUMMY_FRAME_STRUCT') has no effect
unittest/datahandlinglibs_DataMoveCallbackRegistry_test.cxx
Errors
- Line 31: Add #include
for make_shared<>
Warnings
- Line 20: nested namespaces can be concatenated
- Line 5: nested namespaces can be concatenated
- Line 14: the variable 'id' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 28: the variable 'id' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference
- Line 40: expression with side effects will be evaluated despite being used as an operand to 'typeid'
unittest/datahandlinglibs_IterableQueueModel_test.cxx
Warnings
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 18: nested namespaces can be concatenated
- Line 58: nested namespaces can be concatenated
- Line 91: do not manage memory manually; consider a container or a smart pointer
- Line 165: 'pop' overrides a member function but is not marked 'override'
- Line 194: do not use pointer arithmetic
- Line 197: do not use pointer arithmetic
- Line 225: do not use pointer arithmetic
- Line 226: do not use pointer arithmetic
- Line 313: do not declare C-style arrays, use std::array<> instead
- Line 320: do not declare C-style arrays, use std::array<> instead
- Line 3: nested namespaces can be concatenated
- Line 18: do not use pointer arithmetic
- Line 32: do not manage memory manually; use RAII
- Line 50: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined
- Line 68: do not manage memory manually; consider a container or a smart pointer
- Line 113: do not declare C-style arrays, use std::array<> instead
- Line 164: do not use pointer arithmetic
- Line 189: do not use pointer arithmetic
- Line 190: do not use pointer arithmetic
- Line 208: do not use pointer arithmetic
- Line 273: do not use pointer arithmetic
- Line 291: do not use pointer arithmetic
- Line 333: do not manage memory manually; consider a container or a smart pointer
- Line 359: do not use pointer arithmetic
unittest/datahandlinglibs_SkiplistLatencyBufferModel_test.cxx
Warnings
- Line 11: nested namespaces can be concatenated
- Line 19: nested namespaces can be concatenated
- Line 33: do not declare C-style arrays, use std::array<> instead
- Line 18: nested namespaces can be concatenated
- Line 22: using declarations in the global namespace in headers are prohibited
- Line 24: nested namespaces can be concatenated
- Line 120: default arguments on virtual or override methods are prohibited
- Line 5: nested namespaces can be concatenated
- Line 122: default arguments on virtual or override methods are prohibited
unittest/datahandlinglibs_VariableSizeElementQueue_test.cxx
Warnings
- Line 31: variable 'timestamp' is not initialized
- Line 43: do not manage memory manually; consider a container or a smart pointer
- Line 46: variable 'queue_write' is not initialized
- Line 51: variable 'timestamp' is not initialized
- Line 66: do not manage memory manually; consider a container or a smart pointer
- Line 69: variable 'queue_write' is not initialized
- Line 74: variable 'timestamp' is not initialized
- Line 88: do not manage memory manually; consider a container or a smart pointer
- Line 92: variable 'queue_write' is not initialized
- Line 105: do not manage memory manually; consider a container or a smart pointer
- Line 108: variable 'queue_write' is not initialized
- Line 114: variable 'read_successful' is not initialized
- Line 119: do not manage memory manually; consider a container or a smart pointer
- Line 122: variable 'queue_write' is not initialized
- Line 127: variable 'timestamp' is not initialized
- Line 141: do not manage memory manually; consider a container or a smart pointer
- Line 144: variable 'queue_write' is not initialized
- Line 150: variable 'read_successful' is not initialized
- Line 156: do not manage memory manually; consider a container or a smart pointer
- Line 159: variable 'queue_write' is not initialized
- Line 165: variable 'timestamp' is not initialized