daphnemodules
Unit Tests
| Test | Status |
|---|---|
| DaphneInterface_test | ✅ Passed |
| DaphneV3Interface_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| include/daphnemodules/CommonIssues.hpp | ❌ Needs formatting |
| plugins/DaphneV2ControllerModule.cpp | ❌ Needs formatting |
| plugins/DaphneV2ControllerModule.hpp | ❌ Needs formatting |
| plugins/DaphneV3ControllerModule.cpp | ❌ Needs formatting |
| plugins/DaphneV3ControllerModule.hpp | ❌ Needs formatting |
| src/DaphneV2Interface.cpp | ❌ Needs formatting |
| src/DaphneV2Interface.hpp | ❌ Needs formatting |
| src/DaphneV3Interface.cpp | ❌ Needs formatting |
| src/DaphneV3Interface.hpp | ❌ Needs formatting |
| src/DaphneV3Interface.hxx | ❌ Needs formatting |
| src/MezzCommandBuilder.cpp | ❌ Needs formatting |
| src/MezzCommandBuilder.hpp | ❌ Needs formatting |
| src/MezzCommon.hpp | ✅ Already formatted |
| src/zmqclient/ControlClient.cpp | ❌ Needs formatting |
| src/zmqclient/ControlClient.hpp | ❌ Needs formatting |
| test/apps/DaphneMezzModule_test.cxx | ❌ Needs formatting |
| unittest/DaphneInterface_test.cxx | ❌ Needs formatting |
| unittest/DaphneV3Interface_test.cxx | ❌ Needs formatting |
include/daphnemodules/CommonIssues.hpp
Errors
- Line 36: An unsigned integer appears to be used here.
plugins/DaphneV2ControllerModule.hpp
Errors
- Line 26: Found other header after system header. Should be: DaphneV2ControllerModule.hh, other non-system headers, system headers.
- Line 43: An unsigned integer appears to be used here.
- Line 55: An unsigned integer appears to be used here.
- Line 61: An unsigned integer appears to be used here.
- Line 67: An unsigned integer appears to be used here.
- Line 73: An unsigned integer appears to be used here.
- Line 79: An unsigned integer appears to be used here.
- Line 85: An unsigned integer appears to be used here.
- Line 91: An unsigned integer appears to be used here.
- Line 98: An unsigned integer appears to be used here.
- Line 104: An unsigned integer appears to be used here.
- Line 116: An unsigned integer appears to be used here.
- Line 169: An unsigned integer appears to be used here.
src/DaphneV2Interface.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 48: An unsigned integer appears to be used here.
- Line 101: An unsigned integer appears to be used here.
- Line 103: An unsigned integer appears to be used here.
- Line 111: An unsigned integer appears to be used here.
- Line 145: If an else has a brace on one side, it should have it on both
- Line 172: An unsigned integer appears to be used here.
- Line 173: An unsigned integer appears to be used here.
- Line 177: An unsigned integer appears to be used here.
- Line 180: An unsigned integer appears to be used here.
- Line 198: Use of NULL #define found; prefer using the nullptr keyword
- Line 202: An unsigned integer appears to be used here.
- Line 205: Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size.
- Line 205: An unsigned integer appears to be used here.
- Line 211: Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size.
- Line 211: An unsigned integer appears to be used here.
- Line 221: An unsigned integer appears to be used here.
- Line 222: An unsigned integer appears to be used here.
- Line 227: If an else has a brace on one side, it should have it on both
- Line 239: An unsigned integer appears to be used here.
- Line 243: Do not use variable-length arrays. Use an appropriately named ('k' followed by CamelCase) compile-time constant for the size.
- Line 243: An unsigned integer appears to be used here.
- Line 246: An unsigned integer appears to be used here.
- Line 248: An unsigned integer appears to be used here.
- Line 120: Add #include
for string - Line 239: Add #include
for vector<> - Line 112: Add #include
for min - Line 113: Add #include
for move
Warnings
- Line 94: non-void function does not return a value in all control paths
- Line 112: narrowing conversion from 'unsigned long' to signed type 'difference_type' (aka 'long') is implementation-defined
- Line 177: do not declare C-style arrays, use std::array<> instead
- Line 180: do not use pointer arithmetic
- Line 181: do not use C-style cast to convert between unrelated types
- Line 181: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 189: multiple declarations in a single statement reduces readability
- Line 198: use nullptr
- Line 198: use nullptr
- Line 205: do not declare C VLA arrays, use std::vector<> instead
- Line 205: variable length arrays in C++ are a Clang extension
- Line 207: do not use C-style cast to convert between unrelated types
- Line 207: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
- Line 211: do not declare C VLA arrays, use std::vector<> instead
- Line 211: variable length arrays in C++ are a Clang extension
- Line 221: variable 'value' is not initialized
- Line 222: do not use pointer arithmetic
- Line 222: do not use pointer arithmetic
- Line 243: do not declare C VLA arrays, use std::vector<> instead
- Line 243: variable length arrays in C++ are a Clang extension
- Line 246: do not use pointer arithmetic
- Line 248: do not use pointer arithmetic
- Line 248: do not use pointer arithmetic
- Line 251: do not use C-style cast to convert between unrelated types
src/DaphneV2Interface.hpp
Errors
- Line 27: Found other header after system header. Should be: DaphneV2Interface.hh, other non-system headers, system headers.
- Line 29: Found other header after system header. Should be: DaphneV2Interface.hh, other non-system headers, system headers.
- Line 42: Using C-style cast. Use static_cast
(...) instead - Line 63: Namespace should be terminated with '// namespace dunedaq '
- Line 87: An unsigned integer appears to be used here.
- Line 88: An unsigned integer appears to be used here.
- Line 90: An unsigned integer appears to be used here.
- Line 91: An unsigned integer appears to be used here.
- Line 108: An unsigned integer appears to be used here.
- Line 109: An unsigned integer appears to be used here.
- Line 122: Namespace should be terminated with '// namespace dunedaq::daphnemodules '
- Line 113: Add #include
for string - Line 91: Add #include
for move - Line 98: Add #include
for numeric_limits<>
src/DaphneV3Interface.cpp
Errors
- Line 98: Increment/decrement operator should appear alone on its line unless in a while/for loop head
src/DaphneV3Interface.hpp
Errors
- Line 17: Found other header after system header. Should be: DaphneV3Interface.hh, other non-system headers, system headers.
- Line 20: Found other header after system header. Should be: DaphneV3Interface.hh, other non-system headers, system headers.
- Line 21: Found other header after system header. Should be: DaphneV3Interface.hh, other non-system headers, system headers.
- Line 41: Using C-style cast. Use static_cast
(...) instead - Line 78: An unsigned integer appears to be used here.
- Line 131: An unsigned integer appears to be used here.
- Line 137: Namespace should be terminated with '// namespace dunedaq::daphnemodules '
src/MezzCommandBuilder.cpp
Errors
- Line 0: The standard copyright message wasn't found.
src/MezzCommandBuilder.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 0: No #ifndef header guard found, suggested CPP variable is: DAPHNEMODULES_SRC_MEZZCOMMANDBUILDER_HPP_
- Line 22: Namespace should be terminated with '// namespace dunedaq::daphnemodules::mezz '
src/MezzCommon.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 0: No #ifndef header guard found, suggested CPP variable is: DAPHNEMODULES_SRC_MEZZCOMMON_HPP_
src/zmqclient/ControlClient.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 39: Anonymous namespace should be terminated with '// namespace "" '
- Line 44: An unsigned integer appears to be used here.
- Line 18: Add #include
for string
Warnings
- Line 18: variable 'bytes' is not initialized
src/zmqclient/ControlClient.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 45: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
- Line 1: #ifndef header guard has wrong style, please use: DAPHNEMODULES_SRC_ZMQCLIENT_CONTROLCLIENT_HPP_
- Line 45: #endif line should be "#endif // DAPHNEMODULES_SRC_ZMQCLIENT_CONTROLCLIENT_HPP_"
- Line 9: Found other header after system header. Should be: ControlClient.hh, other non-system headers, system headers.
- Line 10: Found other header after system header. Should be: ControlClient.hh, other non-system headers, system headers.
- Line 29: An unsigned integer appears to be used here.
test/apps/DaphneMezzModule_test.cxx
Errors
- Line 15: Found other header after system header. Should be: DaphneMezzModule_test.hh, other non-system headers, system headers.
- Line 44: An unsigned integer appears to be used here.
- Line 49: An unsigned integer appears to be used here.
- Line 51: An unsigned integer appears to be used here.
- Line 52: An unsigned integer appears to be used here.
- Line 53: An unsigned integer appears to be used here.
- Line 54: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 54: An unsigned integer appears to be used here.
- Line 61: "cerr" should not be used for output in DUNE DAQ software.
- Line 74: If/else bodies with multiple statements require braces
- Line 82: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 82: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 83: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 83: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 84: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 84: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 92: "cerr" should not be used for output in DUNE DAQ software.
- Line 112: An unsigned integer appears to be used here.
- Line 119: An unsigned integer appears to be used here.
- Line 209: "cout" should not be used for output in DUNE DAQ software.
- Line 210: "cout" should not be used for output in DUNE DAQ software.
- Line 216: "cerr" should not be used for output in DUNE DAQ software.
- Line 49: Add #include
for pair<>
Warnings
- Line 32: unused function 'recv_multipart'
- Line 79: do not use pointer arithmetic
- Line 79: do not use pointer arithmetic
- Line 80: do not use pointer arithmetic
- Line 82: do not use pointer arithmetic
- Line 82: do not use pointer arithmetic
- Line 83: do not use pointer arithmetic
- Line 83: do not use pointer arithmetic
- Line 84: do not use pointer arithmetic
- Line 84: do not use pointer arithmetic
- Line 87: do not use pointer arithmetic
- Line 87: do not use pointer arithmetic
- Line 88: do not use pointer arithmetic
- Line 88: do not use pointer arithmetic
- Line 129: converting integer literal to bool, use bool literal instead