confmodel
Unit Tests
| Test | Status |
|---|---|
| DisabledResource_test | ✅ Passed |
Clang Formatting
| File | Status |
|---|---|
| apps/list_apps.cxx | ❌ Needs formatting |
| include/confmodel/DisabledResources.hpp | ❌ Needs formatting |
| include/confmodel/confmodelIssues.hpp | ❌ Needs formatting |
| include/confmodel/test_circular_dependency.hpp | ❌ Needs formatting |
| include/confmodel/util.hpp | ❌ Needs formatting |
| pybindsrc/dal_methods.cpp | ❌ Needs formatting |
| pybindsrc/module.cpp | ✅ Already formatted |
| src/DisabledResources.cpp | ❌ Needs formatting |
| src/dalMethods.cpp | ❌ Needs formatting |
| src/test_circular_dependency.cpp | ❌ Needs formatting |
| test/apps/disable_test.cxx | ❌ Needs formatting |
| test/apps/jsonable_test.cxx | ❌ Needs formatting |
| unittest/DisabledResource_test.cxx | ❌ Needs formatting |
apps/list_apps.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 23: "cout" should not be used for output in DUNE DAQ software.
- Line 27: "cout" should not be used for output in DUNE DAQ software.
- Line 30: "cout" should not be used for output in DUNE DAQ software.
- Line 37: "cout" should not be used for output in DUNE DAQ software.
- Line 46: If an else has a brace on one side, it should have it on both
- Line 50: "cout" should not be used for output in DUNE DAQ software.
- Line 53: "cout" should not be used for output in DUNE DAQ software.
- Line 55: "cout" should not be used for output in DUNE DAQ software.
- Line 57: "cout" should not be used for output in DUNE DAQ software.
- Line 59: "cout" should not be used for output in DUNE DAQ software.
- Line 63: "cout" should not be used for output in DUNE DAQ software.
- Line 67: "cout" should not be used for output in DUNE DAQ software.
- Line 71: "cout" should not be used for output in DUNE DAQ software.
- Line 73: "cout" should not be used for output in DUNE DAQ software.
- Line 77: "cout" should not be used for output in DUNE DAQ software.
- Line 84: "cout" should not be used for output in DUNE DAQ software.
- Line 99: If an else has a brace on one side, it should have it on both
- Line 103: "cerr" should not be used for output in DUNE DAQ software.
- Line 118: "cerr" should not be used for output in DUNE DAQ software.
- Line 122: "cout" should not be used for output in DUNE DAQ software.
- Line 136: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
- Line 124: Add #include
for set<> - Line 100: Add #include
for vector<>
Warnings
- Line 63: Null pointer passed to 1st parameter expecting 'nonnull'
- Line 84: do not use pointer arithmetic
- Line 92: do not use pointer arithmetic
- Line 97: unnecessary temporary object created while calling emplace_back
- Line 97: do not use pointer arithmetic
- Line 106: loop variable is copied but only used as const reference; consider making it a const reference
- Line 115: variable 'session' is not initialized
- Line 19: nested namespaces can be concatenated
- Line 56: consider replacing 'unsigned long' with 'uint64'
- Line 74: return type 'const std::vector
- Line 96: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
include/confmodel/DisabledResources.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: CONFMODEL_INCLUDE_CONFMODEL_DISABLEDRESOURCES_HPP_
- Line 66: #endif line should be "#endif // CONFMODEL_INCLUDE_CONFMODEL_DISABLEDRESOURCES_HPP_"
- Line 46: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
- Line 55: Add #include
for vector<>
include/confmodel/confmodelIssues.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: CONFMODEL_INCLUDE_CONFMODEL_CONFMODELISSUES_HPP_
- Line 184: #endif line should be "#endif // CONFMODEL_INCLUDE_CONFMODEL_CONFMODELISSUES_HPP_"
- Line 124: Using C-style cast. Use one of the C++ cast operators instead
- Line 133: Using C-style cast. Use one of the C++ cast operators instead
- Line 170: Add #include
for string
include/confmodel/test_circular_dependency.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: CONFMODEL_INCLUDE_CONFMODEL_TEST_CIRCULAR_DEPENDENCY_HPP_
- Line 65: #endif line should be "#endif // CONFMODEL_INCLUDE_CONFMODEL_TEST_CIRCULAR_DEPENDENCY_HPP_"
- Line 10: Namespace should be terminated with '// namespace conffwk '
- Line 11: Namespace should be terminated with '// namespace dunedaq '
- Line 24: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 62: Namespace should be terminated with '// namespace dunedaq::confmodel '
include/confmodel/util.hpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 1: #ifndef header guard has wrong style, please use: CONFMODEL_INCLUDE_CONFMODEL_UTIL_HPP_
- Line 114: #endif line should be "#endif // CONFMODEL_INCLUDE_CONFMODEL_UTIL_HPP_"
- Line 6: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 8: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 9: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 11: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 12: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 13: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 14: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 15: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 16: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 17: Found other header after system header. Should be: util.hh, other non-system headers, system headers.
- Line 56: Use int16/int64/etc, rather than the C type long
- Line 96: Add #include
for string - Line 74: Add #include
for vector<>
pybindsrc/dal_methods.cpp
Errors
- Line 203: Add #include
for string - Line 188: Add #include
for vector<> - Line 109: Add #include
- for list<>
Warnings
- Line 19: nested namespaces can be concatenated
- Line 56: consider replacing 'unsigned long' with 'uint64'
- Line 74: return type 'const std::vector
- Line 96: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
- Line 46: use emplace_back instead of push_back
- Line 57: use emplace_back instead of push_back
- Line 66: do not use const_cast to remove const qualifier
- Line 79: do not use const_cast to remove const qualifier
- Line 94: use auto when initializing with a template cast to avoid duplicating the type name
- Line 95: use auto when initializing with a template cast to avoid duplicating the type name
- Line 106: use auto when initializing with a template cast to avoid duplicating the type name
- Line 107: use auto when initializing with a template cast to avoid duplicating the type name
- Line 117: 'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop
- Line 118: unnecessary temporary object created while calling emplace_back
pybindsrc/module.cpp
Warnings
- Line 19: nested namespaces can be concatenated
- Line 56: consider replacing 'unsigned long' with 'uint64'
- Line 74: return type 'const std::vector
- Line 96: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
src/DisabledResources.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 49: Use int16/int64/etc, rather than the C type long
- Line 50: Use int16/int64/etc, rather than the C type long
- Line 85: Add #include
for vector<> - Line 86: Add #include
for set<>
Warnings
- Line 7: nested namespaces can be concatenated
- Line 24: do not use array subscript when the index is not an integer constant expression
- Line 46: do not declare C-style arrays, use std::array<> instead
- Line 49: consider replacing 'unsigned long' with 'uint64'
- Line 50: consider replacing 'unsigned long' with 'uint64'
src/dalMethods.cpp
Errors
- Line 70: If an else has a brace on one side, it should have it on both
- Line 132: Anonymous namespace should be terminated with '// namespace "" '
- Line 178: If an else has a brace on one side, it should have it on both
- Line 235: An unsigned integer appears to be used here.
- Line 237: If an else has a brace on one side, it should have it on both
- Line 238: An unsigned integer appears to be used here.
- Line 240: If an else has a brace on one side, it should have it on both
- Line 241: An unsigned integer appears to be used here.
- Line 243: If an else has a brace on one side, it should have it on both
- Line 244: An unsigned integer appears to be used here.
- Line 246: If an else has a brace on one side, it should have it on both
- Line 249: If an else has a brace on one side, it should have it on both
- Line 252: If an else has a brace on one side, it should have it on both
- Line 256: If an else has a brace on one side, it should have it on both
- Line 259: If an else has a brace on one side, it should have it on both
- Line 262: If an else has a brace on one side, it should have it on both
- Line 265: If an else has a brace on one side, it should have it on both
- Line 268: If an else has a brace on one side, it should have it on both
- Line 290: If an else has a brace on one side, it should have it on both
- Line 294: If an else has a brace on one side, it should have it on both
- Line 317: Small and focused functions are preferred: get_json_config() has 94 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
- Line 318: Anonymous namespace should be terminated with '// namespace "" '
- Line 472: Add #include
for vector<> - Line 488: Add #include
for string
Warnings
- Line 7: nested namespaces can be concatenated
- Line 24: do not use array subscript when the index is not an integer constant expression
- Line 46: do not declare C-style arrays, use std::array<> instead
- Line 19: nested namespaces can be concatenated
- Line 56: consider replacing 'unsigned long' with 'uint64'
- Line 74: return type 'const std::vector
- Line 96: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
- Line 70: use auto when initializing with a template cast to avoid duplicating the type name
- Line 277: loop variable is copied but only used as const reference; consider making it a const reference
- Line 300: loop variable is copied but only used as const reference; consider making it a const reference
- Line 326: return type 'const std::vector
- Line 333: return type 'const std::vector
- Line 337: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
- Line 340: the const qualified variable 'controller_log_level' is copy-constructed from a const reference; consider making it a const reference
src/test_circular_dependency.cpp
Errors
- Line 0: The standard copyright message wasn't found.
- Line 9: Increment/decrement operator should appear alone on its line unless in a while/for loop head
- Line 11: If an else has a brace on one side, it should have it on both
Warnings
- Line 7: nested namespaces can be concatenated
- Line 24: do not use array subscript when the index is not an integer constant expression
- Line 46: do not declare C-style arrays, use std::array<> instead
- Line 9: do not use array subscript when the index is not an integer constant expression
- Line 15: do not use array subscript when the index is not an integer constant expression
test/apps/disable_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 19: "cout" should not be used for output in DUNE DAQ software.
- Line 23: "cout" should not be used for output in DUNE DAQ software.
- Line 25: If an else has a brace on one side, it should have it on both
- Line 27: "cout" should not be used for output in DUNE DAQ software.
- Line 29: "cout" should not be used for output in DUNE DAQ software.
- Line 36: "cout" should not be used for output in DUNE DAQ software.
- Line 38: "cout" should not be used for output in DUNE DAQ software.
- Line 41: "cout" should not be used for output in DUNE DAQ software.
- Line 47: "cout" should not be used for output in DUNE DAQ software.
- Line 61: "cerr" should not be used for output in DUNE DAQ software.
- Line 66: "cout" should not be used for output in DUNE DAQ software.
- Line 69: "cout" should not be used for output in DUNE DAQ software.
- Line 72: "cout" should not be used for output in DUNE DAQ software.
- Line 79: "cout" should not be used for output in DUNE DAQ software.
- Line 81: "cout" should not be used for output in DUNE DAQ software.
- Line 83: "cout" should not be used for output in DUNE DAQ software.
- Line 86: "cout" should not be used for output in DUNE DAQ software.
- Line 94: "cout" should not be used for output in DUNE DAQ software.
- Line 99: "cout" should not be used for output in DUNE DAQ software.
- Line 87: Add #include
for set<>
Warnings
- Line 19: nested namespaces can be concatenated
- Line 56: consider replacing 'unsigned long' with 'uint64'
- Line 74: return type 'const int' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
- Line 96: the const qualified variable 'configuration_uri' is copy-constructed from a const reference; consider making it a const reference
- Line 47: do not use pointer arithmetic
- Line 51: do not use pointer arithmetic
- Line 54: do not use pointer arithmetic
test/apps/jsonable_test.cxx
Errors
- Line 0: The standard copyright message wasn't found.
- Line 38: "cout" should not be used for output in DUNE DAQ software.
- Line 41: "cout" should not be used for output in DUNE DAQ software.
unittest/DisabledResource_test.cxx
Errors
- Line 293: Add #include
for vector<>