conffwk

Unit Tests

No unit tests written.

Clang Formatting

File	Status
apps/config_dump.cxx	❌ Needs formatting
apps/config_export_data.cxx	❌ Needs formatting
apps/config_export_schema.cxx	❌ Needs formatting
include/conffwk/Change.hpp	❌ Needs formatting
include/conffwk/ConfigAction.hpp	❌ Needs formatting
include/conffwk/ConfigObject.hpp	❌ Needs formatting
include/conffwk/ConfigObjectImpl.hpp	❌ Needs formatting
include/conffwk/ConfigPackages.doxygen.hpp	❌ Needs formatting
include/conffwk/ConfigVersion.hpp	❌ Needs formatting
include/conffwk/Configuration.hpp	❌ Needs formatting
include/conffwk/ConfigurationImpl.hpp	❌ Needs formatting
include/conffwk/ConfigurationPointer.hpp	❌ Needs formatting
include/conffwk/DalFactory.hpp	❌ Needs formatting
include/conffwk/DalFactoryFunctions.hpp	❌ Needs formatting
include/conffwk/DalObject.hpp	❌ Needs formatting
include/conffwk/DalObjectPrint.hpp	❌ Needs formatting
include/conffwk/DalRegistry.hpp	❌ Needs formatting
include/conffwk/Errors.hpp	❌ Needs formatting
include/conffwk/Schema.hpp	❌ Needs formatting
include/conffwk/SubscriptionCriteria.hpp	❌ Needs formatting
include/conffwk/details/Configuration.hxx	❌ Needs formatting
include/conffwk/details/DalFactory.hxx	❌ Needs formatting
include/conffwk/details/DalRegistry.hxx	❌ Needs formatting
include/conffwk/map.hpp	❌ Needs formatting
include/conffwk/set.hpp	❌ Needs formatting
include/conffwk/string_ptr.hpp	❌ Needs formatting
pybindsrc/config.cpp	❌ Needs formatting
pybindsrc/module.cpp	✅ Already formatted
src/ConfigObject.cpp	❌ Needs formatting
src/ConfigObjectImpl.cpp	❌ Needs formatting
src/Configuration.cpp	❌ Needs formatting
src/ConfigurationImpl.cpp	❌ Needs formatting
src/DalFactory.cpp	❌ Needs formatting
src/DalObject.cpp	❌ Needs formatting
src/DalRegistry.cpp	❌ Needs formatting
src/SubscriptionCriteria.cpp	❌ Needs formatting
test/apps/conffwk_check_inheritance.cxx	❌ Needs formatting
test/apps/config_subscriber.cxx	❌ Needs formatting
test/apps/config_test_object.cxx	❌ Needs formatting
test/apps/config_test_rw.cxx	❌ Needs formatting
test/apps/config_time_test.cxx	❌ Needs formatting
test/apps/dal_resolve_libs.cxx	❌ Needs formatting

apps/config_dump.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 15: Found other header after system header. Should be: config_dump.hh, other non-system headers, system headers.
Line 16: Found other header after system header. Should be: config_dump.hh, other non-system headers, system headers.
Line 17: Found other header after system header. Should be: config_dump.hh, other non-system headers, system headers.
Line 50: "cout" should not be used for output in DUNE DAQ software.
Line 54: "cout" should not be used for output in DUNE DAQ software.
Line 56: "cout" should not be used for output in DUNE DAQ software.
Line 71: "cout" should not be used for output in DUNE DAQ software.
Line 71: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 79: "cout" should not be used for output in DUNE DAQ software.
Line 161: "cout" should not be used for output in DUNE DAQ software.
Line 238: "cout" should not be used for output in DUNE DAQ software.
Line 245: "cout" should not be used for output in DUNE DAQ software.
Line 261: "cout" should not be used for output in DUNE DAQ software.
Line 263: "cout" should not be used for output in DUNE DAQ software.
Line 271: "cout" should not be used for output in DUNE DAQ software.
Line 288: "cout" should not be used for output in DUNE DAQ software.
Line 300: "cout" should not be used for output in DUNE DAQ software.
Line 304: "cout" should not be used for output in DUNE DAQ software.
Line 318: "cout" should not be used for output in DUNE DAQ software.
Line 325: "cout" should not be used for output in DUNE DAQ software.
Line 346: Small and focused functions are preferred: main() has 219 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 296: Add #include for vector<>
Line 175: Add #include for move
Line 307: Add #include for set<>

Warnings

Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 47: use nullptr
Line 68: do not declare C-style arrays, use std::array<> instead
Line 86: multiple declarations in a single statement reduces readability
Line 294: use auto when declaring iterators
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

apps/config_export_data.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 18: Found other header after system header. Should be: config_export_data.hh, other non-system headers, system headers.
Line 77: "cout" should not be used for output in DUNE DAQ software.
Line 92: "cerr" should not be used for output in DUNE DAQ software.
Line 171: "cout" should not be used for output in DUNE DAQ software.
Line 177: "cout" should not be used for output in DUNE DAQ software.
Line 181: "cout" should not be used for output in DUNE DAQ software.
Line 185: "cout" should not be used for output in DUNE DAQ software.
Line 189: Small and focused functions are preferred: main() has 143 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 149: Add #include for string
Line 120: Add #include for move

Warnings

Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 25: multiple declarations in a single statement reduces readability
Line 105: multiple declarations in a single statement reduces readability
Line 124: multiple declarations in a single statement reduces readability
Line 124: variable 'fix_pos' is not initialized
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

apps/config_export_schema.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 18: Found other header after system header. Should be: config_export_schema.hh, other non-system headers, system headers.
Line 67: "cout" should not be used for output in DUNE DAQ software.
Line 82: "cerr" should not be used for output in DUNE DAQ software.
Line 110: "cout" should not be used for output in DUNE DAQ software.
Line 116: "cout" should not be used for output in DUNE DAQ software.
Line 120: "cout" should not be used for output in DUNE DAQ software.
Line 124: "cout" should not be used for output in DUNE DAQ software.
Line 128: Small and focused functions are preferred: main() has 90 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 98: Add #include for string

Warnings

Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 25: multiple declarations in a single statement reduces readability
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

include/conffwk/Change.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CHANGE_HPP_
Line 133: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CHANGE_HPP_"
Line 108: Single-parameter constructors should be marked explicit.
Line 111: Access specifier "private" has already appeared in class ConfigurationChange

include/conffwk/ConfigAction.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGACTION_HPP_
Line 43: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGACTION_HPP_"
Line 13: Found other header after system header. Should be: ConfigAction.hh, other non-system headers, system headers.
Line 25: You don't need a ; after a }
Line 28: Add #include for vector<>

include/conffwk/ConfigObject.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 602: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 603: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 604: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 605: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGOBJECT_HPP_
Line 649: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGOBJECT_HPP_"
Line 24: Found other header after system header. Should be: ConfigObject.hh, other non-system headers, system headers.
Line 25: Found other header after system header. Should be: ConfigObject.hh, other non-system headers, system headers.
Line 88: Single-parameter constructors should be marked explicit.
Line 211: Access specifier "public" has already appeared in class ConfigObject
Line 337: Use int16/int64/etc, rather than the C type long
Line 618: Access specifier "private" has already appeared in class ConfigObject
Line 630: Access specifier "private" has already appeared in class ConfigObject
Line 571: Add #include for move

include/conffwk/ConfigObjectImpl.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 38: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 39: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 40: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 333: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 334: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 335: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 336: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 337: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGOBJECTIMPL_HPP_
Line 393: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGOBJECTIMPL_HPP_"
Line 23: Found other header after system header. Should be: ConfigObjectImpl.hh, other non-system headers, system headers.
Line 80: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 86: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 106: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 112: An unsigned integer appears to be used here.
Line 118: An unsigned integer appears to be used here.
Line 124: An unsigned integer appears to be used here.
Line 130: An unsigned integer appears to be used here.
Line 148: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 154: An unsigned integer appears to be used here.
Line 160: An unsigned integer appears to be used here.
Line 166: An unsigned integer appears to be used here.
Line 172: An unsigned integer appears to be used here.
Line 190: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 196: Use int16/int64/etc, rather than the C type long
Line 199: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 205: An unsigned integer appears to be used here.
Line 211: An unsigned integer appears to be used here.
Line 217: An unsigned integer appears to be used here.
Line 223: An unsigned integer appears to be used here.
Line 250: Access specifier "public" has already appeared in class ConfigObjectImpl
Line 256: An unsigned integer appears to be used here.
Line 262: An unsigned integer appears to be used here.
Line 268: An unsigned integer appears to be used here.
Line 274: An unsigned integer appears to be used here.
Line 331: Access specifier "protected:" appears after "private:", not before
Line 340: Access specifier "protected" has already appeared in class ConfigObjectImpl
Line 356: Access specifier "private" has already appeared in class ConfigObjectImpl
Line 361: An unsigned integer appears to be used here.
Line 363: An unsigned integer appears to be used here.
Line 365: An unsigned integer appears to be used here.
Line 367: An unsigned integer appears to be used here.
Line 375: An unsigned integer appears to be used here.
Line 377: An unsigned integer appears to be used here.
Line 379: An unsigned integer appears to be used here.
Line 381: An unsigned integer appears to be used here.
Line 307: Add #include for move

include/conffwk/ConfigPackages.doxygen.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 14: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGPACKAGES_DOXYGEN_HPP_
Line 1266: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGPACKAGES_DOXYGEN_HPP_"

include/conffwk/ConfigVersion.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 14: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGVERSION_HPP_
Line 120: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGVERSION_HPP_"
Line 52: Access specifier "public" has already appeared in class Version
Line 117: Namespace should be terminated with '// namespace conffwk '
Line 118: Namespace should be terminated with '// namespace dunedaq '

include/conffwk/Configuration.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 16: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGURATION_HPP_
Line 1763: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGURATION_HPP_"
Line 32: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 34: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 35: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 36: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 37: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 38: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 39: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 41: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 42: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 254: Single-parameter constructors should be marked explicit.
Line 284: Access specifier "public" has already appeared in class Configuration
Line 327: Access specifier "public" has already appeared in class Configuration
Line 410: Access specifier "private" has already appeared in class Configuration
Line 416: Access specifier "public" has already appeared in class Configuration
Line 461: Using C-style cast. Use one of the C++ cast operators instead
Line 557: Access specifier "private" has already appeared in class Configuration
Line 569: Access specifier "public" has already appeared in class Configuration
Line 665: Access specifier "public" has already appeared in class Configuration
Line 681: Use int16/int64/etc, rather than the C type long
Line 698: Use int16/int64/etc, rather than the C type long
Line 715: Use int16/int64/etc, rather than the C type long
Line 733: Use int16/int64/etc, rather than the C type long
Line 754: Use int16/int64/etc, rather than the C type long
Line 803: Use int16/int64/etc, rather than the C type long
Line 915: Use int16/int64/etc, rather than the C type long
Line 945: Use int16/int64/etc, rather than the C type long
Line 962: Access specifier "private" has already appeared in class Configuration
Line 965: Use int16/int64/etc, rather than the C type long
Line 968: Use int16/int64/etc, rather than the C type long
Line 977: Use int16/int64/etc, rather than the C type long
Line 993: Access specifier "public" has already appeared in class Configuration
Line 1056: Access specifier "private" has already appeared in class Configuration
Line 1070: Access specifier "public" has already appeared in class Configuration
Line 1244: Access specifier "public" has already appeared in class Configuration
Line 1278: Access specifier "public" has already appeared in class Configuration
Line 1293: Access specifier "private" has already appeared in class Configuration
Line 1302: Access specifier "public" has already appeared in class Configuration
Line 1336: Access specifier "public" has already appeared in class Configuration
Line 1414: Access specifier "public" has already appeared in class Configuration
Line 1427: Access specifier "private" has already appeared in class Configuration
Line 1434: Access specifier "private" has already appeared in class Configuration
Line 1448: Access specifier "public" has already appeared in class Configuration
Line 1463: Access specifier "private" has already appeared in class Configuration
Line 1470: Access specifier "public" has already appeared in class Configuration
Line 1600: Access specifier "private" has already appeared in class Configuration
Line 1649: Access specifier "public" has already appeared in class Configuration
Line 1666: Access specifier "private" has already appeared in class Configuration
Line 1680: Access specifier "private" has already appeared in class Configuration
Line 1696: Access specifier "public" has already appeared in class Configuration
Line 1706: Access specifier "private" has already appeared in class Configuration
Line 1712: Access specifier "private" has already appeared in class Configuration
Line 1723: Access specifier "private" has already appeared in class Configuration
Line 1728: Access specifier "public" has already appeared in class Configuration
Line 1446: Add #include for deque<>
Line 1685: Add #include for less<>
Line 1738: Add #include for unordered_map<>

include/conffwk/ConfigurationImpl.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGURATIONIMPL_HPP_
Line 293: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGURATIONIMPL_HPP_"
Line 24: Found other header after system header. Should be: ConfigurationImpl.hh, other non-system headers, system headers.
Line 25: Found other header after system header. Should be: ConfigurationImpl.hh, other non-system headers, system headers.
Line 26: Found other header after system header. Should be: ConfigurationImpl.hh, other non-system headers, system headers.
Line 69: Access specifier "public" has already appeared in class ConfigurationImpl
Line 134: Access specifier "public" has already appeared in class ConfigurationImpl
Line 138: Use int16/int64/etc, rather than the C type long
Line 142: Use int16/int64/etc, rather than the C type long
Line 146: Use int16/int64/etc, rather than the C type long
Line 150: Use int16/int64/etc, rather than the C type long
Line 155: Access specifier "public" has already appeared in class ConfigurationImpl
Line 172: Access specifier "public" has already appeared in class ConfigurationImpl
Line 185: Access specifier "public" has already appeared in class ConfigurationImpl
Line 219: Use int16/int64/etc, rather than the C type long
Line 220: Use int16/int64/etc, rather than the C type long
Line 223: Access specifier "protected:" appears after "private:", not before
Line 265: Access specifier "protected" has already appeared in class ConfigurationImpl
Line 275: Access specifier "public" has already appeared in class ConfigurationImpl
Line 282: Access specifier "public" has already appeared in class ConfigurationImpl

include/conffwk/ConfigurationPointer.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 81: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_CONFIGURATIONPOINTER_HPP_
Line 81: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_CONFIGURATIONPOINTER_HPP_"
Line 38: Single-parameter constructors should be marked explicit.
Line 42: Single-parameter constructors should be marked explicit.
Line 77: Namespace should be terminated with '// namespace python '
Line 38: Add #include for string

include/conffwk/DalFactory.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 1: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_DALFACTORY_HPP_
Line 128: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_DALFACTORY_HPP_"
Line 8: Found other header after system header. Should be: DalFactory.hh, other non-system headers, system headers.
Line 10: Found other header after system header. Should be: DalFactory.hh, other non-system headers, system headers.
Line 11: Found other header after system header. Should be: DalFactory.hh, other non-system headers, system headers.
Line 13: Found other header after system header. Should be: DalFactory.hh, other non-system headers, system headers.

include/conffwk/DalFactoryFunctions.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_DALFACTORYFUNCTIONS_HPP_
Line 95: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_DALFACTORYFUNCTIONS_HPP_"

include/conffwk/DalObject.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_DALOBJECT_HPP_
Line 517: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_DALOBJECT_HPP_"
Line 23: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 24: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 25: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 26: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 27: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 28: Found other header after system header. Should be: DalObject.hh, other non-system headers, system headers.
Line 112: Access specifier "protected" has already appeared in class DalObject
Line 129: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
Line 183: Use of Run Time Type Information not allowed unless this code is meant to test other code
Line 283: Access specifier "public" has already appeared in class DalObject
Line 344: Access specifier "protected" has already appeared in class DalObject
Line 403: Access specifier "protected" has already appeared in class DalObject
Line 429: Using C-style cast. Use one of the C++ cast operators instead
Line 263: Add #include for move
Line 453: Add #include for vector<>

include/conffwk/DalObjectPrint.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 14: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_DALOBJECTPRINT_HPP_
Line 156: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_DALOBJECTPRINT_HPP_"
Line 31: An unsigned integer appears to be used here.
Line 33: An unsigned integer appears to be used here.
Line 141: Add #include for string

include/conffwk/DalRegistry.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 233: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 1: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_DALREGISTRY_HPP_
Line 233: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_DALREGISTRY_HPP_"
Line 34: Single-parameter constructors should be marked explicit.
Line 94: Use int16/int64/etc, rather than the C type long
Line 184: Add #include for vector<>
Line 205: Add #include for string
Line 226: Add #include for unordered_map<>

include/conffwk/Errors.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_ERRORS_HPP_
Line 96: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_ERRORS_HPP_"
Line 94: Namespace should be terminated with '// namespace dunedaq '

include/conffwk/Schema.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 28: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 29: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 30: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 31: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 32: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 33: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 34: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 35: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 36: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 37: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 38: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 39: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 40: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 41: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 42: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 43: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 50: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 51: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 52: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 53: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 61: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 62: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 63: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 64: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 65: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 66: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 67: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 68: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 92: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 93: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 111: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 112: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 113: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 114: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 122: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 123: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 124: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 125: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 126: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 148: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 149: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 164: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 165: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 166: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 167: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 168: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 169: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 170: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 171: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 191: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 192: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_SCHEMA_HPP_
Line 206: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_SCHEMA_HPP_"
Line 203: Namespace should be terminated with '// namespace conffwk '
Line 204: Namespace should be terminated with '// namespace dunedaq '

include/conffwk/SubscriptionCriteria.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 15: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_SUBSCRIPTIONCRITERIA_HPP_
Line 159: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_SUBSCRIPTIONCRITERIA_HPP_"
Line 122: Access specifier "public" has already appeared in class ConfigurationSubscriptionCriteria
Line 129: Access specifier "public" has already appeared in class ConfigurationSubscriptionCriteria

include/conffwk/map.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_MAP_HPP_
Line 61: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_MAP_HPP_"
Line 50: Add #include for string
Line 39: Add #include for map<>

include/conffwk/set.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_SET_HPP_
Line 25: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_SET_HPP_"
Line 20: Add #include for string

include/conffwk/string_ptr.hpp

Errors

Line 0: The standard copyright message wasn't found.
Line 8: #ifndef header guard has wrong style, please use: CONFFWK_INCLUDE_CONFFWK_STRING_PTR_HPP_
Line 31: #endif line should be "#endif // CONFFWK_INCLUDE_CONFFWK_STRING_PTR_HPP_"
Line 26: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time

pybindsrc/config.cpp

Errors

Line 105: An unsigned integer appears to be used here.
Line 109: An unsigned integer appears to be used here.
Line 113: An unsigned integer appears to be used here.
Line 117: An unsigned integer appears to be used here.
Line 129: An unsigned integer appears to be used here.
Line 133: An unsigned integer appears to be used here.
Line 137: An unsigned integer appears to be used here.
Line 141: An unsigned integer appears to be used here.
Line 167: An unsigned integer appears to be used here.
Line 171: An unsigned integer appears to be used here.
Line 175: An unsigned integer appears to be used here.
Line 179: An unsigned integer appears to be used here.
Line 189: An unsigned integer appears to be used here.
Line 193: An unsigned integer appears to be used here.
Line 197: An unsigned integer appears to be used here.
Line 201: An unsigned integer appears to be used here.
Line 220: Small and focused functions are preferred: register_conffwkobject() has 135 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

src/ConfigObject.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 11: Found other header after system header. Should be: ConfigObject.hh, other non-system headers, system headers.
Line 12: Found other header after system header. Should be: ConfigObject.hh, other non-system headers, system headers.
Line 136: An unsigned integer appears to be used here.
Line 138: An unsigned integer appears to be used here.
Line 241: An unsigned integer appears to be used here.
Line 243: An unsigned integer appears to be used here.
Line 245: An unsigned integer appears to be used here.
Line 247: An unsigned integer appears to be used here.
Line 297: "cerr" should not be used for output in DUNE DAQ software.
Line 300: Small and focused functions are preferred: ConfigObject::print_ref() has 84 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 312: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 304: Add #include for string

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 28: declaration 'ConfigurationChange' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 29: declaration 'ConfigObject' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 30: no definition found for 'ConfigObjectImpl', but a definition with the same name 'ConfigObjectImpl' found in another namespace 'dunedaq::conffwk'
Line 32: nested namespaces can be concatenated
Line 69: redundant access specifier has the same accessibility as the previous access specifier
Line 134: redundant access specifier has the same accessibility as the previous access specifier
Line 138: consider replacing 'unsigned long' with 'uint64'
Line 142: consider replacing 'unsigned long' with 'uint64'
Line 146: consider replacing 'unsigned long' with 'uint64'
Line 150: consider replacing 'unsigned long' with 'uint64'
Line 155: redundant access specifier has the same accessibility as the previous access specifier
Line 172: redundant access specifier has the same accessibility as the previous access specifier
Line 185: redundant access specifier has the same accessibility as the previous access specifier
Line 219: consider replacing 'unsigned long' with 'uint64'
Line 220: consider replacing 'unsigned long' with 'uint64'
Line 265: redundant access specifier has the same accessibility as the previous access specifier
Line 282: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 17: nested namespaces can be concatenated
Line 152: use auto when initializing with a cast to avoid duplicating the type name
Line 152: do not use const_cast to remove const qualifier
Line 271: use auto when initializing with a cast to avoid duplicating the type name
Line 271: do not use const_cast to remove const qualifier
Line 306: use auto when initializing with new to avoid duplicating the type name

src/ConfigObjectImpl.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 22: Access specifier "public:" appears after one (or both) of "private:" and/or "protected:", not before
Line 28: Access specifier "public" has already appeared in class ConfigObjectDefault
Line 33: An unsigned integer appears to be used here.
Line 35: An unsigned integer appears to be used here.
Line 37: An unsigned integer appears to be used here.
Line 39: An unsigned integer appears to be used here.
Line 47: An unsigned integer appears to be used here.
Line 49: An unsigned integer appears to be used here.
Line 51: An unsigned integer appears to be used here.
Line 53: An unsigned integer appears to be used here.
Line 61: Use int16/int64/etc, rather than the C type long
Line 64: An unsigned integer appears to be used here.
Line 66: An unsigned integer appears to be used here.
Line 68: An unsigned integer appears to be used here.
Line 70: An unsigned integer appears to be used here.
Line 83: An unsigned integer appears to be used here.
Line 85: An unsigned integer appears to be used here.
Line 87: An unsigned integer appears to be used here.
Line 89: An unsigned integer appears to be used here.
Line 124: Add #include for string
Line 102: Add #include for vector<>
Line 104: Add #include for move

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 11: nested namespaces can be concatenated
Line 24: use nullptr
Line 28: redundant access specifier has the same accessibility as the previous access specifier
Line 61: consider replacing 'unsigned long' with 'uint64'
Line 124: initialization of 's_invalid' with static storage duration may throw an exception that cannot be caught

src/Configuration.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 16: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 17: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 19: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 20: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 21: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 22: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 23: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 24: Found other header after system header. Should be: Configuration.hh, other non-system headers, system headers.
Line 194: "cout" should not be used for output in DUNE DAQ software.
Line 234: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 247: Use int16/int64/etc, rather than the C type long
Line 254: Use int16/int64/etc, rather than the C type long
Line 269: Use int16/int64/etc, rather than the C type long
Line 289: Use int16/int64/etc, rather than the C type long
Line 403: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 406: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 415: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 417: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 426: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 429: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 782: Use int16/int64/etc, rather than the C type long
Line 931: If/else bodies with multiple statements require braces
Line 1151: An unsigned integer appears to be used here.
Line 1157: An unsigned integer appears to be used here.
Line 1163: An unsigned integer appears to be used here.
Line 1169: An unsigned integer appears to be used here.
Line 1198: Small and focused functions are preferred: Configuration::export_data() has 83 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 1287: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1312: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 1324: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 1328: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1333: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 1333: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1339: Using C-style cast. Use one of the C++ cast operators instead
Line 1346: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1349: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1429: Using C-style cast. Use one of the C++ cast operators instead
Line 1450: Using C-style cast. Use one of the C++ cast operators instead
Line 1470: Using C-style cast. Use one of the C++ cast operators instead
Line 1631: Using C-style cast. Use one of the C++ cast operators instead
Line 1653: Using C-style cast. Use one of the C++ cast operators instead
Line 1664: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
Line 1712: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1720: Using C-style cast. Use one of the C++ cast operators instead
Line 1734: A catch-all-exceptions construct was found in a file which doesn't contain int main(); this can only be used to wrap main()
Line 1740: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1747: Small and focused functions are preferred: Configuration::system_cb() has 128 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 1759: Using C-style cast. Use one of the C++ cast operators instead
Line 1799: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 1854: If/else bodies with multiple statements require braces
Line 1987: Use int16/int64/etc, rather than the C type long
Line 2063: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 2121: Add #include for string
Line 2113: Add #include for vector<>
Line 2101: Add #include for list<>
Line 727: Add #include for deque<>
Line 1380: Add #include for set<>
Line 1101: Add #include for unique_ptr<>
Line 951: Add #include for make_pair

Warnings

Line 16: declaration uses identifier 'CONFFWK_CONFIGURATION__CHANGE_H_', which is a reserved identifier
Line 22: nested namespaces can be concatenated
Line 111: redundant access specifier has the same accessibility as the previous access specifier
Line 15: nested namespaces can be concatenated
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 28: declaration 'ConfigurationChange' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 29: declaration 'ConfigObject' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 30: no definition found for 'ConfigObjectImpl', but a definition with the same name 'ConfigObjectImpl' found in another namespace 'dunedaq::conffwk'
Line 32: nested namespaces can be concatenated
Line 69: redundant access specifier has the same accessibility as the previous access specifier
Line 134: redundant access specifier has the same accessibility as the previous access specifier
Line 138: consider replacing 'unsigned long' with 'uint64'
Line 142: consider replacing 'unsigned long' with 'uint64'
Line 146: consider replacing 'unsigned long' with 'uint64'
Line 150: consider replacing 'unsigned long' with 'uint64'
Line 155: redundant access specifier has the same accessibility as the previous access specifier
Line 172: redundant access specifier has the same accessibility as the previous access specifier
Line 185: redundant access specifier has the same accessibility as the previous access specifier
Line 219: consider replacing 'unsigned long' with 'uint64'
Line 220: consider replacing 'unsigned long' with 'uint64'
Line 265: redundant access specifier has the same accessibility as the previous access specifier
Line 282: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 30: nested namespaces can be concatenated
Line 55: class 'DalFactoryFunctions' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI
Line 112: redundant access specifier has the same accessibility as the previous access specifier
Line 278: default arguments on virtual or override methods are prohibited
Line 283: redundant access specifier has the same accessibility as the previous access specifier
Line 417: do not use const_cast to remove const qualifier
Line 429: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 18: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 155: variable 'f' is not initialized
Line 157: do not use C-style cast to convert between unrelated types
Line 157: C-style casts are discouraged; use static_cast
Line 160: use nullptr
Line 162: use nullptr
Line 183: Called C++ object pointer is null
Line 235: use nullptr
Line 237: use nullptr
Line 247: consider replacing 'unsigned long' with 'uint64'
Line 254: consider replacing 'unsigned long' with 'uint64'
Line 269: consider replacing 'unsigned long' with 'uint64'
Line 289: consider replacing 'unsigned long' with 'uint64'
Line 324: use nullptr
Line 782: consider replacing 'unsigned long' with 'uint64'
Line 906: use auto when declaring iterators
Line 965: redundant get() call on smart pointer
Line 969: redundant get() call on smart pointer
Line 1046: do not use const_cast to remove const qualifier
Line 1050: do not use const_cast to remove const qualifier
Line 1077: do not use const_cast to remove const qualifier
Line 1093: do not use const_cast to remove const qualifier
Line 1101: multiple declarations in a single statement reduces readability
Line 1111: redundant get() call on smart pointer
Line 1115: redundant get() call on smart pointer
Line 1128: redundant get() call on smart pointer
Line 1130: redundant get() call on smart pointer
Line 1252: use nullptr
Line 1268: use auto when initializing with new to avoid duplicating the type name
Line 1302: use auto when initializing with new to avoid duplicating the type name
Line 1312: do not use reinterpret_cast
Line 1323: use auto when declaring iterators
Line 1324: use auto when declaring iterators
Line 1324: do not use reinterpret_cast
Line 1333: do not use reinterpret_cast
Line 1339: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 1420: use auto when declaring iterators
Line 1426: use auto when declaring iterators
Line 1441: use auto when declaring iterators
Line 1447: use auto when declaring iterators
Line 1461: use auto when declaring iterators
Line 1467: use auto when declaring iterators
Line 1500: use auto when declaring iterators
Line 1631: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 1678: use auto when declaring iterators
Line 1893: use auto when declaring iterators
Line 1987: consider replacing 'unsigned long' with 'uint64'

src/ConfigurationImpl.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 10: Found other header after system header. Should be: ConfigurationImpl.hh, other non-system headers, system headers.
Line 181: If an else has a brace on one side, it should have it on both
Line 191: If an else has a brace on one side, it should have it on both
Line 204: If an else has a brace on one side, it should have it on both
Line 215: If an else has a brace on one side, it should have it on both
Line 246: "cout" should not be used for output in DUNE DAQ software.
Line 283: If an else has a brace on one side, it should have it on both
Line 310: If an else has a brace on one side, it should have it on both
Line 320: If an else has a brace on one side, it should have it on both
Line 331: If an else has a brace on one side, it should have it on both
Line 350: If an else has a brace on one side, it should have it on both
Line 379: Using C-style cast. Use one of the C++ cast operators instead
Line 391: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 393: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 399: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 417: An unsigned integer appears to be used here.
Line 429: An unsigned integer appears to be used here.
Line 441: An unsigned integer appears to be used here.
Line 453: An unsigned integer appears to be used here.
Line 490: An unsigned integer appears to be used here.
Line 502: An unsigned integer appears to be used here.
Line 514: An unsigned integer appears to be used here.
Line 526: An unsigned integer appears to be used here.
Line 550: Add #include for string
Line 550: Add #include for vector<>

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 28: declaration 'ConfigurationChange' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 29: declaration 'ConfigObject' is never referenced, but a declaration with the same name found in another namespace 'dunedaq::conffwk'
Line 30: no definition found for 'ConfigObjectImpl', but a definition with the same name 'ConfigObjectImpl' found in another namespace 'dunedaq::conffwk'
Line 32: nested namespaces can be concatenated
Line 69: redundant access specifier has the same accessibility as the previous access specifier
Line 134: redundant access specifier has the same accessibility as the previous access specifier
Line 138: consider replacing 'unsigned long' with 'uint64'
Line 142: consider replacing 'unsigned long' with 'uint64'
Line 146: consider replacing 'unsigned long' with 'uint64'
Line 150: consider replacing 'unsigned long' with 'uint64'
Line 155: redundant access specifier has the same accessibility as the previous access specifier
Line 172: redundant access specifier has the same accessibility as the previous access specifier
Line 185: redundant access specifier has the same accessibility as the previous access specifier
Line 219: consider replacing 'unsigned long' with 'uint64'
Line 220: consider replacing 'unsigned long' with 'uint64'
Line 265: redundant access specifier has the same accessibility as the previous access specifier
Line 282: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 14: nested namespaces can be concatenated
Line 183: use auto when declaring iterators
Line 193: use auto when declaring iterators
Line 206: use auto when declaring iterators
Line 217: use auto when declaring iterators
Line 234: use nullptr
Line 256: use auto when declaring iterators
Line 261: use auto when declaring iterators
Line 292: use auto when declaring iterators
Line 295: use auto when declaring iterators
Line 298: use auto when declaring iterators
Line 344: use auto when declaring iterators
Line 351: use auto when initializing with new to avoid duplicating the type name
Line 361: use auto when declaring iterators
Line 365: use auto when declaring iterators

src/DalFactory.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 79: Using C-style cast. Use one of the C++ cast operators instead
Line 108: Using C-style cast. Use one of the C++ cast operators instead
Line 168: Add #include for string

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 13: nested namespaces can be concatenated
Line 57: unused parameter 'upcast_unregistered'
Line 89: unused parameter 'fallback_unregistred'
Line 136: unused parameter 'upcast_unregistered'

src/DalObject.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 105: Add #include for string
Line 25: Add #include for vector<>

Warnings

Line 16: declaration uses identifier 'CONFFWK_CONFIGURATION__CHANGE_H_', which is a reserved identifier
Line 22: nested namespaces can be concatenated
Line 111: redundant access specifier has the same accessibility as the previous access specifier
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 30: nested namespaces can be concatenated
Line 55: class 'DalFactoryFunctions' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI
Line 112: redundant access specifier has the same accessibility as the previous access specifier
Line 278: default arguments on virtual or override methods are prohibited
Line 283: redundant access specifier has the same accessibility as the previous access specifier
Line 417: do not use const_cast to remove const qualifier
Line 429: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 3: nested namespaces can be concatenated
Line 12: do not use const_cast to remove const qualifier

src/DalRegistry.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 73: Missing date in TODO comment; it should appear on same line as the TODO, preferably in a form like "Apr-14-2020"
Line 73: Missing author name in TODO comment; it should appear on the same line as the TODO, as Firstname Lastname
Line 73: Missing email address in TODO comment; it should appear on the same line as the TODO
Line 89: The delete operator appears to be used; owning memory should be done with a smart pointer rather than a raw pointer
Line 166: Use operator || instead of or
Line 167: Use operator || instead of or
Line 144: Add #include for vector<>
Line 198: Add #include for string

Warnings

Line 16: declaration uses identifier 'CONFFWK_CONFIGURATION__CHANGE_H_', which is a reserved identifier
Line 22: nested namespaces can be concatenated
Line 111: redundant access specifier has the same accessibility as the previous access specifier
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 30: nested namespaces can be concatenated
Line 55: class 'DalFactoryFunctions' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI
Line 112: redundant access specifier has the same accessibility as the previous access specifier
Line 278: default arguments on virtual or override methods are prohibited
Line 283: redundant access specifier has the same accessibility as the previous access specifier
Line 417: do not use const_cast to remove const qualifier
Line 429: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 4: nested namespaces can be concatenated

src/SubscriptionCriteria.cpp

Errors

Line 0: The standard copyright message wasn't found.
Line 39: Add #include for string

Warnings

Line 16: declaration uses identifier 'CONFFWK_CONFIGURATION__CHANGE_H_', which is a reserved identifier
Line 22: nested namespaces can be concatenated
Line 111: redundant access specifier has the same accessibility as the previous access specifier
Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 30: nested namespaces can be concatenated
Line 55: class 'DalFactoryFunctions' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI
Line 112: redundant access specifier has the same accessibility as the previous access specifier
Line 278: default arguments on virtual or override methods are prohibited
Line 283: redundant access specifier has the same accessibility as the previous access specifier
Line 417: do not use const_cast to remove const qualifier
Line 429: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 11: nested namespaces can be concatenated
Line 41: use auto when declaring iterators

test/apps/conffwk_check_inheritance.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 107: C-style comment syntax detected; please use either C++ style "//" or Doxygen style
Line 5: Found other header after system header. Should be: conffwk_check_inheritance.hh, other non-system headers, system headers.
Line 6: Found other header after system header. Should be: conffwk_check_inheritance.hh, other non-system headers, system headers.
Line 7: Found other header after system header. Should be: conffwk_check_inheritance.hh, other non-system headers, system headers.
Line 79: Add #include for string
Line 76: Add #include for deque<>
Line 76: Add #include for set<>
Line 79: Add #include for map<>

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

test/apps/config_subscriber.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 30: Found other header after system header. Should be: config_subscriber.hh, other non-system headers, system headers.
Line 31: Found other header after system header. Should be: config_subscriber.hh, other non-system headers, system headers.
Line 32: Found other header after system header. Should be: config_subscriber.hh, other non-system headers, system headers.
Line 44: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 46: "cout" should not be used for output in DUNE DAQ software.
Line 53: "cout" should not be used for output in DUNE DAQ software.
Line 57: "cout" should not be used for output in DUNE DAQ software.
Line 65: "cout" should not be used for output in DUNE DAQ software.
Line 70: "cout" should not be used for output in DUNE DAQ software.
Line 77: "cout" should not be used for output in DUNE DAQ software.
Line 88: "cout" should not be used for output in DUNE DAQ software.
Line 103: "cout" should not be used for output in DUNE DAQ software.
Line 128: If an else has a brace on one side, it should have it on both
Line 129: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 130: "cerr" should not be used for output in DUNE DAQ software.
Line 133: If an else has a brace on one side, it should have it on both
Line 137: If an else has a brace on one side, it should have it on both
Line 138: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 139: "cerr" should not be used for output in DUNE DAQ software.
Line 142: If an else has a brace on one side, it should have it on both
Line 146: If an else has a brace on one side, it should have it on both
Line 153: If an else has a brace on one side, it should have it on both
Line 154: "cerr" should not be used for output in DUNE DAQ software.
Line 171: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 179: Use of reinterpret_cast can be dangerous. If there's no way to avoid its use add " // NOLINT" to the end of this line so this script will ignore it next time
Line 190: "cout" should not be used for output in DUNE DAQ software.
Line 195: "cerr" should not be used for output in DUNE DAQ software.
Line 42: Add #include for vector<>
Line 117: Add #include for string
Line 117: Add #include for list<>

Warnings

Line 24: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead
Line 124: do not use pointer arithmetic
Line 124: do not use pointer arithmetic
Line 128: do not use pointer arithmetic
Line 128: do not use pointer arithmetic
Line 134: do not use pointer arithmetic
Line 137: do not use pointer arithmetic
Line 137: do not use pointer arithmetic
Line 145: do not use pointer arithmetic
Line 171: do not use reinterpret_cast

test/apps/config_test_object.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 13: Found other header after system header. Should be: config_test_object.hh, other non-system headers, system headers.
Line 14: Found other header after system header. Should be: config_test_object.hh, other non-system headers, system headers.
Line 34: "cout" should not be used for output in DUNE DAQ software.
Line 72: If an else has a brace on one side, it should have it on both
Line 73: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 75: If an else has a brace on one side, it should have it on both
Line 76: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 78: If an else has a brace on one side, it should have it on both
Line 79: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 81: If an else has a brace on one side, it should have it on both
Line 108: "cout" should not be used for output in DUNE DAQ software.
Line 110: If an else has a brace on one side, it should have it on both
Line 111: "cout" should not be used for output in DUNE DAQ software.

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 61: use nullptr
Line 62: use nullptr
Line 63: use nullptr
Line 66: do not use pointer arithmetic
Line 73: do not use pointer arithmetic
Line 76: do not use pointer arithmetic
Line 79: do not use pointer arithmetic

test/apps/config_test_rw.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 14: Found other header after system header. Should be: config_test_rw.hh, other non-system headers, system headers.
Line 15: Found other header after system header. Should be: config_test_rw.hh, other non-system headers, system headers.
Line 35: "cout" should not be used for output in DUNE DAQ software.
Line 73: "cerr" should not be used for output in DUNE DAQ software.
Line 75: If an else has a brace on one side, it should have it on both
Line 76: "cout" should not be used for output in DUNE DAQ software.
Line 86: "cerr" should not be used for output in DUNE DAQ software.
Line 89: If an else has a brace on one side, it should have it on both
Line 91: "cerr" should not be used for output in DUNE DAQ software.
Line 93: If an else has a brace on one side, it should have it on both
Line 95: "cerr" should not be used for output in DUNE DAQ software.
Line 100: "cout" should not be used for output in DUNE DAQ software.
Line 110: "cerr" should not be used for output in DUNE DAQ software.
Line 112: If an else has a brace on one side, it should have it on both
Line 115: "cerr" should not be used for output in DUNE DAQ software.
Line 120: "cout" should not be used for output in DUNE DAQ software.
Line 122: "cout" should not be used for output in DUNE DAQ software.
Line 123: "cout" should not be used for output in DUNE DAQ software.
Line 125: "cout" should not be used for output in DUNE DAQ software.
Line 132: "cout" should not be used for output in DUNE DAQ software.
Line 136: "cout" should not be used for output in DUNE DAQ software.
Line 140: "cout" should not be used for output in DUNE DAQ software.
Line 147: "cout" should not be used for output in DUNE DAQ software.
Line 151: "cout" should not be used for output in DUNE DAQ software.
Line 155: "cout" should not be used for output in DUNE DAQ software.
Line 160: #define appears to be used. Macros should generally be avoided if there's an alternative to them.
Line 162: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 182: If an else has a brace on one side, it should have it on both
Line 183: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 185: If an else has a brace on one side, it should have it on both
Line 186: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 188: If an else has a brace on one side, it should have it on both
Line 189: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 191: If an else has a brace on one side, it should have it on both
Line 250: An unsigned integer appears to be used here.
Line 252: An unsigned integer appears to be used here.
Line 254: An unsigned integer appears to be used here.
Line 255: An unsigned integer appears to be used here.
Line 256: An unsigned integer appears to be used here.
Line 265: An unsigned integer appears to be used here.
Line 267: An unsigned integer appears to be used here.
Line 269: An unsigned integer appears to be used here.
Line 271: An unsigned integer appears to be used here.
Line 280: An unsigned integer appears to be used here.
Line 282: An unsigned integer appears to be used here.
Line 286: An unsigned integer appears to be used here.
Line 295: An unsigned integer appears to be used here.
Line 297: An unsigned integer appears to be used here.
Line 299: An unsigned integer appears to be used here.
Line 301: An unsigned integer appears to be used here.
Line 331: An unsigned integer appears to be used here.
Line 333: An unsigned integer appears to be used here.
Line 335: An unsigned integer appears to be used here.
Line 337: An unsigned integer appears to be used here.
Line 345: An unsigned integer appears to be used here.
Line 347: An unsigned integer appears to be used here.
Line 351: An unsigned integer appears to be used here.
Line 378: "cout" should not be used for output in DUNE DAQ software.
Line 380: "cout" should not be used for output in DUNE DAQ software.
Line 444: "cout" should not be used for output in DUNE DAQ software.
Line 451: "cout" should not be used for output in DUNE DAQ software.
Line 458: "cout" should not be used for output in DUNE DAQ software.
Line 462: "cout" should not be used for output in DUNE DAQ software.
Line 468: "cout" should not be used for output in DUNE DAQ software.
Line 472: "cout" should not be used for output in DUNE DAQ software.
Line 475: "cout" should not be used for output in DUNE DAQ software.
Line 478: "cout" should not be used for output in DUNE DAQ software.
Line 485: "cout" should not be used for output in DUNE DAQ software.
Line 492: "cout" should not be used for output in DUNE DAQ software.
Line 500: "cout" should not be used for output in DUNE DAQ software.
Line 504: "cout" should not be used for output in DUNE DAQ software.
Line 510: "cout" should not be used for output in DUNE DAQ software.
Line 514: "cout" should not be used for output in DUNE DAQ software.
Line 517: "cout" should not be used for output in DUNE DAQ software.
Line 521: "cout" should not be used for output in DUNE DAQ software.
Line 526: "cout" should not be used for output in DUNE DAQ software.
Line 528: "cout" should not be used for output in DUNE DAQ software.
Line 530: "cout" should not be used for output in DUNE DAQ software.
Line 535: "cout" should not be used for output in DUNE DAQ software.
Line 537: "cout" should not be used for output in DUNE DAQ software.
Line 539: "cout" should not be used for output in DUNE DAQ software.
Line 542: "cout" should not be used for output in DUNE DAQ software.
Line 549: "cout" should not be used for output in DUNE DAQ software.
Line 553: "cout" should not be used for output in DUNE DAQ software.
Line 563: Small and focused functions are preferred: main() has 317 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 310: Add #include for vector<>
Line 523: Add #include for list<>
Line 271: Add #include for numeric_limits<>

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 9: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead
Line 84: use nullptr
Line 160: function-like macro 'INIT' used; consider a 'constexpr' template function
Line 161: macro argument should be enclosed in parentheses
Line 161: macro argument should be enclosed in parentheses
Line 162: macro argument should be enclosed in parentheses
Line 171: use nullptr
Line 172: use nullptr
Line 173: use nullptr
Line 176: do not use pointer arithmetic
Line 183: do not use pointer arithmetic
Line 186: do not use pointer arithmetic
Line 189: do not use pointer arithmetic
Line 254: narrowing conversion from constant value 4294967295 (0xFFFFFFFF) of type 'unsigned int' to signed type 'int32_t' (aka 'int') is implementation-defined
Line 255: C-style casts are discouraged; use static_cast
Line 256: use auto when initializing with a cast to avoid duplicating the type name
Line 256: C-style casts are discouraged; use static_cast
Line 274: use emplace_back instead of push_back
Line 274: use emplace_back instead of push_back
Line 274: use emplace_back instead of push_back
Line 275: use emplace_back instead of push_back
Line 275: use emplace_back instead of push_back
Line 275: use emplace_back instead of push_back
Line 276: use emplace_back instead of push_back
Line 276: use emplace_back instead of push_back
Line 276: use emplace_back instead of push_back
Line 321: use nullptr
Line 326: use nullptr
Line 366: use nullptr
Line 379: use auto when declaring iterators
Line 415: do not declare C-style arrays, use std::array<> instead
Line 435: do not use array subscript when the index is not an integer constant expression
Line 435: do not use array subscript when the index is not an integer constant expression
Line 436: do not use array subscript when the index is not an integer constant expression
Line 448: do not declare C-style arrays, use std::array<> instead
Line 451: do not use array subscript when the index is not an integer constant expression
Line 455: do not use array subscript when the index is not an integer constant expression
Line 457: do not use array subscript when the index is not an integer constant expression
Line 457: do not use array subscript when the index is not an integer constant expression
Line 467: do not use array subscript when the index is not an integer constant expression
Line 467: do not use array subscript when the index is not an integer constant expression
Line 480: do not declare C-style arrays, use std::array<> instead
Line 481: do not declare C-style arrays, use std::array<> instead
Line 492: do not use array subscript when the index is not an integer constant expression
Line 497: do not use array subscript when the index is not an integer constant expression
Line 499: do not use array subscript when the index is not an integer constant expression
Line 499: do not use array subscript when the index is not an integer constant expression
Line 509: do not use array subscript when the index is not an integer constant expression
Line 509: do not use array subscript when the index is not an integer constant expression

test/apps/config_time_test.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 17: Found other header after system header. Should be: config_time_test.hh, other non-system headers, system headers.
Line 18: Found other header after system header. Should be: config_time_test.hh, other non-system headers, system headers.
Line 19: Found other header after system header. Should be: config_time_test.hh, other non-system headers, system headers.
Line 49: "cout" should not be used for output in DUNE DAQ software.
Line 62: "cout" should not be used for output in DUNE DAQ software.
Line 73: If an else has a brace on one side, it should have it on both
Line 74: Increment/decrement operator should appear alone on its line unless in a while/for loop head
Line 76: If an else has a brace on one side, it should have it on both
Line 96: "cout" should not be used for output in DUNE DAQ software.
Line 112: "cout" should not be used for output in DUNE DAQ software.
Line 144: "cout" should not be used for output in DUNE DAQ software.
Line 149: "cout" should not be used for output in DUNE DAQ software.
Line 165: "cout" should not be used for output in DUNE DAQ software.
Line 168: "cout" should not be used for output in DUNE DAQ software.
Line 179: "cout" should not be used for output in DUNE DAQ software.
Line 185: If an else has a brace on one side, it should have it on both
Line 203: Small and focused functions are preferred: main() has 102 non-comment lines (error triggered by exceeding 80 lines) (disable this by putting "// NOLINT" after the function's closing brace.)
Line 167: Add #include for set<>
Line 187: Add #include for vector<>

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast
Line 8: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead
Line 9: inclusion of deprecated C++ header 'time.h'; consider using 'ctime' instead
Line 55: use nullptr
Line 59: do not use pointer arithmetic
Line 74: do not use pointer arithmetic
Line 107: use auto when declaring iterators
Line 115: use auto when declaring iterators
Line 130: use auto when declaring iterators
Line 136: use auto when declaring iterators
Line 160: use auto when declaring iterators
Line 167: use auto when declaring iterators
Line 181: use auto when declaring iterators
Line 187: use auto when declaring iterators

test/apps/dal_resolve_libs.cxx

Errors

Line 0: The standard copyright message wasn't found.
Line 6: Found other header after system header. Should be: dal_resolve_libs.hh, other non-system headers, system headers.
Line 7: Found other header after system header. Should be: dal_resolve_libs.hh, other non-system headers, system headers.
Line 8: Found other header after system header. Should be: dal_resolve_libs.hh, other non-system headers, system headers.
Line 41: Add #include for string

Warnings

Line 27: nested namespaces can be concatenated
Line 248: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 256: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 337: consider replacing 'unsigned long' with 'uint64'
Line 630: redundant access specifier has the same accessibility as the previous access specifier
Line 25: nested namespaces can be concatenated
Line 86: redundant access specifier has the same accessibility as the previous access specifier
Line 104: return type 'const std::string' (aka 'const basic_string') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness
Line 106: redundant access specifier has the same accessibility as the previous access specifier
Line 148: redundant access specifier has the same accessibility as the previous access specifier
Line 190: redundant access specifier has the same accessibility as the previous access specifier
Line 196: consider replacing 'unsigned long' with 'uint64'
Line 199: redundant access specifier has the same accessibility as the previous access specifier
Line 250: redundant access specifier has the same accessibility as the previous access specifier
Line 324: do not use const_cast to remove const qualifier
Line 340: redundant access specifier has the same accessibility as the previous access specifier
Line 21: nested namespaces can be concatenated
Line 52: redundant access specifier has the same accessibility as the previous access specifier
Line 44: nested namespaces can be concatenated
Line 284: redundant access specifier has the same accessibility as the previous access specifier
Line 394: use nullptr
Line 665: redundant access specifier has the same accessibility as the previous access specifier
Line 681: consider replacing 'unsigned long' with 'uint64'
Line 681: use nullptr
Line 698: consider replacing 'unsigned long' with 'uint64'
Line 698: use nullptr
Line 715: consider replacing 'unsigned long' with 'uint64'
Line 715: use nullptr
Line 733: consider replacing 'unsigned long' with 'uint64'
Line 733: use nullptr
Line 754: consider replacing 'unsigned long' with 'uint64'
Line 754: use nullptr
Line 803: consider replacing 'unsigned long' with 'uint64'
Line 803: use nullptr
Line 915: consider replacing 'unsigned long' with 'uint64'
Line 945: consider replacing 'unsigned long' with 'uint64'
Line 965: consider replacing 'unsigned long' with 'uint64'
Line 968: consider replacing 'unsigned long' with 'uint64'
Line 968: use nullptr
Line 977: consider replacing 'unsigned long' with 'uint64'
Line 977: use nullptr
Line 1244: redundant access specifier has the same accessibility as the previous access specifier
Line 1278: redundant access specifier has the same accessibility as the previous access specifier
Line 1336: redundant access specifier has the same accessibility as the previous access specifier
Line 1414: redundant access specifier has the same accessibility as the previous access specifier
Line 1434: redundant access specifier has the same accessibility as the previous access specifier
Line 1680: redundant access specifier has the same accessibility as the previous access specifier
Line 1712: redundant access specifier has the same accessibility as the previous access specifier
Line 1723: redundant access specifier has the same accessibility as the previous access specifier
Line 16: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HPP__', which is a reserved identifier
Line 7: nested namespaces can be concatenated
Line 94: consider replacing 'unsigned long' with 'uint64'
Line 22: nested namespaces can be concatenated
Line 16: declaration uses identifier 'CONFFWK_SUBSCRIPTION__CRITERIA_H_', which is a reserved identifier
Line 23: nested namespaces can be concatenated
Line 122: redundant access specifier has the same accessibility as the previous access specifier
Line 129: redundant access specifier has the same accessibility as the previous access specifier
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_CONFIGURATION_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 32: consider replacing 'unsigned long' with 'uint64'
Line 65: consider replacing 'unsigned long' with 'uint64'
Line 140: consider replacing 'unsigned long' with 'uint64'
Line 377: use nullptr
Line 389: use auto when declaring iterators
Line 403: use auto when declaring iterators
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALFACTORY_HXX__', which is a reserved identifier
Line 4: nested namespaces can be concatenated
Line 2: declaration uses identifier '__DUNEDAQ_CONFFWK_DALREGISTRY_HXX__', which is a reserved identifier
Line 6: nested namespaces can be concatenated
Line 67: consider replacing 'unsigned long' with 'uint64'
Line 137: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast
Line 14: nested namespaces can be concatenated
Line 14: nested namespaces can be concatenated
Line 13: nested namespaces can be concatenated
Line 26: do not use reinterpret_cast

Navigation

Repo Summaries

conffwk

Unit Tests

Clang Formatting

apps/config_dump.cxx

Errors

Warnings

apps/config_export_data.cxx

Errors

Warnings

apps/config_export_schema.cxx

Errors

Warnings

include/conffwk/Change.hpp

Errors

include/conffwk/ConfigAction.hpp

Errors

include/conffwk/ConfigObject.hpp

Errors

include/conffwk/ConfigObjectImpl.hpp

Errors

include/conffwk/ConfigPackages.doxygen.hpp

Errors

include/conffwk/ConfigVersion.hpp

Errors

include/conffwk/Configuration.hpp

Errors

include/conffwk/ConfigurationImpl.hpp

Errors

include/conffwk/ConfigurationPointer.hpp

Errors

include/conffwk/DalFactory.hpp

Errors

include/conffwk/DalFactoryFunctions.hpp

Errors

include/conffwk/DalObject.hpp

Errors

include/conffwk/DalObjectPrint.hpp

Errors

include/conffwk/DalRegistry.hpp

Errors

include/conffwk/Errors.hpp

Errors

include/conffwk/Schema.hpp

Errors

include/conffwk/SubscriptionCriteria.hpp

Errors

include/conffwk/map.hpp

Errors

include/conffwk/set.hpp

Errors

include/conffwk/string_ptr.hpp

Errors

pybindsrc/config.cpp

Errors

Warnings

src/ConfigObject.cpp

Errors

Warnings

src/ConfigObjectImpl.cpp

Errors

Warnings

src/Configuration.cpp

Errors

Warnings

src/ConfigurationImpl.cpp

Errors

Warnings

src/DalFactory.cpp

Errors

Warnings

src/DalObject.cpp

Errors

Warnings

src/DalRegistry.cpp

Errors

Warnings

src/SubscriptionCriteria.cpp

Errors