appfwk

Unit Tests

Test	Status
Application_test	✅ Passed
CommandLineInterpreter_test	✅ Passed
DAQModuleManager_test	✅ Passed
DAQModule_test	✅ Passed

Errors in Documentation Links

docs/Daq-Application.md

• [ERROR] file://dir_containing_files_of_type_app_name_command.json/ File not found. Check if file exists and path is correct

docs/README.md

• [404] https://github.com/DUNE-DAQ/appfwk/blob/develop/include/appfwk/NamedObject.hpp Rejected status code: 404 Not Found
• [404] https://github.com/DUNE-DAQ/readoutmodules/blob/develop/plugins/FakeCardReader.hpp Rejected status code: 404 Not Found

Clang Formatting

File	Status
apps/daq_application.cxx	✅ Already formatted
include/appfwk/ConfigurationManager.hpp	✅ Already formatted
include/appfwk/DAQModule.hpp	❌ Needs formatting
include/appfwk/ValidationReport.hpp	❌ Needs formatting
include/appfwk/cmd/Nljs.hpp	❌ Needs formatting
include/appfwk/cmd/Structs.hpp	❌ Needs formatting
include/appfwk/detail/DAQModule.hxx	✅ Already formatted
src/Application.cpp	❌ Needs formatting
src/Application.hpp	❌ Needs formatting
src/CommandLineInterpreter.hpp	✅ Already formatted
src/ConfigurationManager.cpp	❌ Needs formatting
src/ConfigurationManagerOwner.hpp	✅ Already formatted
src/DAQModule.cpp	✅ Already formatted
src/DAQModuleManager.cpp	✅ Already formatted
src/DAQModuleManager.hpp	✅ Already formatted
test/apps/check_action_plans.cxx	❌ Needs formatting
test/apps/dummy_module_test.cxx	✅ Already formatted
test/plugins/DummyModule.cpp	✅ Already formatted
test/plugins/DummyModule.hpp	✅ Already formatted
test/plugins/ExtraModule.cpp	✅ Already formatted
unittest/Application_test.cxx	✅ Already formatted
unittest/CommandLineInterpreter_test.cxx	✅ Already formatted
unittest/DAQModuleManager_test.cxx	✅ Already formatted
unittest/DAQModule_test.cxx	✅ Already formatted

apps/daq_application.cxx

Warnings

• Line 14: nested namespaces can be concatenated

src/Application.cpp

Warnings

• Line 14: nested namespaces can be concatenated

src/ConfigurationManager.cpp

Errors

• Line 54: Add #include for make_shared<>
• Line 60: Add #include for vector<>

Warnings

• Line 14: nested namespaces can be concatenated

src/DAQModule.cpp

Warnings

• Line 14: nested namespaces can be concatenated

src/DAQModuleManager.cpp

Warnings

• Line 14: nested namespaces can be concatenated

test/apps/check_action_plans.cxx

Warnings

• Line 63: Null pointer passed to 1st parameter expecting 'nonnull'
• Line 14: nested namespaces can be concatenated

test/apps/dummy_module_test.cxx

Warnings

• Line 14: nested namespaces can be concatenated

test/plugins/DummyModule.cpp

Warnings

• Line 14: nested namespaces can be concatenated

test/plugins/DummyModule.hpp

Errors

• Line 101: Add #include for move

test/plugins/ExtraModule.cpp

Warnings

• Line 14: nested namespaces can be concatenated

unittest/Application_test.cxx

Warnings

• Line 14: nested namespaces can be concatenated

unittest/DAQModuleManager_test.cxx

Warnings

• Line 14: nested namespaces can be concatenated

unittest/DAQModule_test.cxx

Errors

• Line 86: Add #include for shared_ptr<>

Warnings

• Line 14: nested namespaces can be concatenated
• Line 21: unused variable 'queue_timeout'